Re: [tor-bugs] #33594 [Applications/Tor Browser]: Fenix Use of Glean

[Tor Bug Tracker & Wiki]

#33594: Fenix Use of Glean
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, gitlab-tb-  |  Actual Points:
  fenix  |
Parent ID:  #33184   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by sysrqb):

 * cc: boklm (removed)
 * keywords:  tbb-mobile, Android => tbb-mobile, Android, gitlab-tb-fenix


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33594 [Applications/Tor Browser]: Fenix Use of Glean

[Tor Bug Tracker & Wiki]

#33594: Fenix Use of Glean
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:  Sponsor58-must
--+

Comment (by sysrqb):

 Replying to [comment:5 sisbell]:
 > In fenix, app/build.gradle we have options for disabling crash reporting
 and telemetry. They are only disabled for debug builds but I can patch
 this.
 >
 >
 > {{{
 >
 > if (!isDebug) {
 > buildConfigField 'boolean', 'TELEMETRY', 'true'
 > } else {
 > buildConfigField 'boolean', 'TELEMETRY', 'false'
 > }
 > }}}

 I'm concerned about something being added in the future that initializes a
 MetricController (or another piece of Glean) and ignoring this build-time
 flag. In the future, I hope we can use something like the above but only
 after we audit the implementation and ensure it is proxy-safe. Telemetry
 pings over Tor aren't good, but they aren't as disastrous as bypassing the
 proxy.

 I have a patch that changes Glean to a compileOnly dependency. This means
 that it is used at build time, but the dependency is not included in the
 final package. I think this is a relatively clean solution.

 I opened a Github Issue requesting feedback:
 https://github.com/mozilla-mobile/fenix/issues/10125

 and the patch:
 https://github.com/sysrqb/fenix/commit/fd426371204f84298c89176f7a58bf6199d9aef0

 Note, with this patch, it still includes glean. We'll need a patch for
 `buildSrc/src/main/java/Config.kt` that flips `includeGlean` from `true`
 to `false`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33594 [Applications/Tor Browser]: Fenix Use of Glean

[Tor Bug Tracker & Wiki]

#33594: Fenix Use of Glean
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sisbell):

 In fenix, app/build.gradle we have options for disabling crash reporting
 and telemetry. They are only disabled for debug builds but I can patch
 this.


 {{{
 buildConfigField 'String', 'SENTRY_TOKEN', 'null'
 if (!isDebug) {
 buildConfigField 'boolean', 'CRASH_REPORTING', 'true'
 // Reading sentry token from local file (if it exists). In a
 release task on taskcluster it will be available.
 try {
 def token = new File("${rootDir}/.sentry_token").text.trim()
 buildConfigField 'String', 'SENTRY_TOKEN', '"' + token + '"'
 } catch (FileNotFoundException ignored) {}
 } else {
 buildConfigField 'boolean', 'CRASH_REPORTING', 'false'
 }

 if (!isDebug) {
 buildConfigField 'boolean', 'TELEMETRY', 'true'
 } else {
 buildConfigField 'boolean', 'TELEMETRY', 'false'
 }

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33594 [Applications/Tor Browser]: Fenix Use of Glean

[Tor Bug Tracker & Wiki]

#33594: Fenix Use of Glean
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sisbell):

 Replying to [comment:3 boklm]:
 > > (2) also seems a bit of a pain because the android-components is going
 through heavy development would require redoing the patches each time.
 >
 > Could we add a configure flag to disable this, and submit the patch to
 Mozilla so we don't have to redo the patch for each release?
 That's a good idea, let me see how feasible this looks in the code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33594 [Applications/Tor Browser]: Fenix Use of Glean

[Tor Bug Tracker & Wiki]

#33594: Fenix Use of Glean
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 > (2) also seems a bit of a pain because the android-components is going
 through heavy development would require redoing the patches each time.

 Could we add a configure flag to disable this, and submit the patch to
 Mozilla so we don't have to redo the patch for each release?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33594 [Applications/Tor Browser]: Fenix Use of Glean

[Tor Bug Tracker & Wiki]

#33594: Fenix Use of Glean
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sisbell):

 Excluding Samples and the Glean module we have the following kotlin files
 with a dependency in android-components

 {{{
 buildSrc/src/main/java/Dependencies.kt
 
components/lib/crash/src/main/java/mozilla/components/lib/crash/service/SentryService.kt
 
components/lib/crash/src/main/java/mozilla/components/lib/crash/service/GleanCrashReporterService.kt
 
components/lib/crash/src/test/java/mozilla/components/lib/crash/service/SentryServiceTest.kt
 
components/lib/crash/src/test/java/mozilla/components/lib/crash/service/GleanCrashReporterServiceTest.kt
 components/tooling/glean-gradle-
 plugin/src/main/java/mozilla/components/tooling/glean-gradle-
 plugin/GleanGradlePlugin.kt
 components/service/firefox-
 
accounts/src/main/java/mozilla/components/service/fxa/sync/WorkManagerSyncManager.kt
 
components/service/experiments/src/main/java/mozilla/components/service/experiments/Experiments.kt
 
components/service/experiments/src/test/java/mozilla/components/service/experiments/ExperimentsTest.kt
 
components/service/experiments/src/test/java/mozilla/components/service/experiments/debug/ExperimentsDebugActivityTest.kt
 components/browser/engine-gecko-
 
beta/src/main/java/mozilla/components/browser/engine/gecko/glean/GeckoAdapter.kt
 components/browser/engine-gecko-
 
nightly/src/main/java/mozilla/components/browser/engine/gecko/glean/GeckoAdapter.kt
 components/browser/engine-
 
gecko/src/main/java/mozilla/components/browser/engine/gecko/glean/GeckoAdapter.kt
 components/support/sync-
 
telemetry/src/main/java/mozilla/components/support/sync/telemetry/BaseGleanSyncPing.kt
 components/support/sync-
 
telemetry/src/main/java/mozilla/components/support/sync/telemetry/SyncTelemetry.kt
 components/support/sync-
 
telemetry/src/test/java/mozilla/components/support/sync/telemetry/SyncTelemetryTest.kt
 components/support/base/src/main/java/mozilla/components/Build.kt
 
components/support/migration/src/main/java/mozilla/components/support/migration/FennecMigrator.kt

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33594 [Applications/Tor Browser]: Fenix Use of Glean

[Tor Bug Tracker & Wiki]

#33594: Fenix Use of Glean
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sisbell):

 * type:  defect => task


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33594 [Applications/Tor Browser]: Fenix Use of Glean

[Tor Bug Tracker & Wiki]

#33594: Fenix Use of Glean
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile,
  |  Android
Actual Points:|  Parent ID:  #33184
   Points:|   Reviewer:
  Sponsor:|
--+
 Glean is the telemetry library that Fenix uses, which I think we don't
 want to add to the final apk.

 There two ways to handle this

  1. Create a TBB project for glean and include it as a compile time
 dependency in android-components. Then we just don't include the aar in
 the final project, which disables the feature.
 2. Patch the Fenix project to not use glean

 I'm not that keen on (1) since we have to pull in and configure rust. (2)
 also seems a bit of a pain because the android-components is going through
 heavy development would require redoing the patches each time.

 I have pref for (2). Thoughts?

 Remark from components/browser/engine-gecko-nightly/build.gradle

 {{{
     // We only compile against Glean. It's up to the app to add those
 dependencies
     // if it wants to collect !GeckoView telemetry through the Glean SDK.
 }}}

 Project: https://github.com/mozilla/glean

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs