Re: [tor-bugs] #33672 [Applications/Tor Browser]: Force include https-everywhere in incremental mar update

[Tor Bug Tracker & Wiki]

#33672: Force include https-everywhere in incremental mar update
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  wontfix
 Keywords:  TorBrowserTeam202003R |  Actual Points:  0.3
Parent ID:| Points:
 Reviewer:  brade, mcs|Sponsor:
--+--
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => wontfix


Comment:

 Downgrading http-everywhere is not easy to do on all platforms, and the
 bug that we want to avoid is in a feature that is not enabled by default,
 so we decided to release 9.0.7 with the new http-everywhere version.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33672 [Applications/Tor Browser]: Force include https-everywhere in incremental mar update

[Tor Bug Tracker & Wiki]

#33672: Force include https-everywhere in incremental mar update
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202003R |  Actual Points:  0.3
Parent ID:| Points:
 Reviewer:  brade, mcs|Sponsor:
--+--
Changes (by mcs):

 * actualpoints:  .2 => 0.3


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33672 [Applications/Tor Browser]: Force include https-everywhere in incremental mar update

[Tor Bug Tracker & Wiki]

#33672: Force include https-everywhere in incremental mar update
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202003R |  Actual Points:  .2
Parent ID:| Points:
 Reviewer:  brade, mcs|Sponsor:
--+--

Comment (by sysrqb):

 That's disappointing. I looked at staged extensions, instead of
 distribution addons, but I believe you are correct.

 [https://gitweb.torproject.org/tor-
 browser.git/tree/toolkit/mozapps/extensions/internal/XPIInstall.jsm?h=tor-
 browser-68.6.0esr-9.5-1#n3768 XPIInstall.jsm::installDistributionAddon]

 {{{
 let state = location.get(id);

 if (state) {
   try {
 let existingAddon = await loadManifestFromFile(state.file,
 location);

 if (Services.vc.compare(addon.version, existingAddon.version) <=
 0) {
   return null;
 }
 }}}

 Which is called from `XPIProvider::installDistributionAddons`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33672 [Applications/Tor Browser]: Force include https-everywhere in incremental mar update

[Tor Bug Tracker & Wiki]

#33672: Force include https-everywhere in incremental mar update
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202003R |  Actual Points:  .2
Parent ID:| Points:
 Reviewer:  brade, mcs|Sponsor:
--+--

Comment (by mcs):

 On macOS, I do not think it will help to include an older version of
 HTTPS-E under `Contents/Resources/distribution/extensions/`. The .xpi will
 not be copied into the user's profile unless it is a newer version than
 what is already in the profile. I think the following is the relevant
 code:
 https://gitweb.torproject.org/tor-
 browser.git/tree/toolkit/mozapps/extensions/internal/XPIProvider.jsm?h
 =tor-browser-68.6.0esr-9.5-1#n2788

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33672 [Applications/Tor Browser]: Force include https-everywhere in incremental mar update

[Tor Bug Tracker & Wiki]

#33672: Force include https-everywhere in incremental mar update
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202003R |  Actual Points:  .2
Parent ID:| Points:
 Reviewer:  brade, mcs|Sponsor:
--+--
Changes (by boklm):

 * status:  new => needs_review
 * keywords:   => TorBrowserTeam202003R
 * actualpoints:   => .2


Comment:

 After generating incremental mars with this patch, in the
 `updatev3.manifest` from linux, windows, macos incremental mars, I can see
 an `add` line for `https-everywhere-...@eff.org.xpi`, so this seems to be
 working.

 I rebased the two patches on `maint-9.0` in branch `bug_33672-maint-9.0`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 
build.git/commit/?h=bug_33672-maint-9.0&id=03858651f89915f2e266f66ff0b07343c1196bfd

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33672 [Applications/Tor Browser]: Force include https-everywhere in incremental mar update

[Tor Bug Tracker & Wiki]

#33672: Force include https-everywhere in incremental mar update
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  brade, mcs|Sponsor:
--+--

Comment (by boklm):

 I made two patches for option 2. in branch `bug_33672`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_33672&id=9fd30760d4fa95a497f94f235f0df804f8d39579

 I am currently generating incremental mars with this patch to check if it
 correctly includes https-everywhere.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33672 [Applications/Tor Browser]: Force include https-everywhere in incremental mar update

[Tor Bug Tracker & Wiki]

#33672: Force include https-everywhere in incremental mar update
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:  brade, mcs
  Sponsor:|
--+
 We should include an older version of https-everywhere in the upcoming
 release. This won't be a problem for new installations. However, any
 recently run instance of Tor Browser mostlikely automatically upgraded to
 the newest https-e version (2020.3.16), so we should include the older
 version (2019.11.7) in our incremental mar files.

 2019.11.7 is the version we included in the last Tor Browser version, so
 it won't be included in the incrementals. It seems like we can force
 inclusion in `make_incremental_update.sh`.

 I see two options:
   1. (tor-browser) Patch `tools/update-
 packaging/make_incremental_update.sh` so it always include https-
 everywhere (and then we revert/drop that patch at the next rebase)
   1. (tor-browser-build) Patch `tools/update-responses/gen_incrementals`
 so it passes `-f $ext_path/$https_everywhere_dir/* $packed_https_e_path`
 (with appropriate paths) when it calls `make_incremental_update.sh`?

 If there are alternatives, we can consider those, too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs