Re: [tor-bugs] #33788 [Core Tor/Tor]: Check the return value of tor_inet_ntop() and tor_inet_ntoa()

[Tor Bug Tracker & Wiki]

#33788: Check the return value of tor_inet_ntop() and tor_inet_ntoa()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, 044-should, security-  |  implemented
  low, 035-backport, 041-backport,   |  Actual Points:
  042-backport, 043-backport, outreachy-ipv6,|
  ipv6, 044-must |
Parent ID:  #33768   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-can
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Looks good now. Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33788 [Core Tor/Tor]: Check the return value of tor_inet_ntop() and tor_inet_ntoa()

[Tor Bug Tracker & Wiki]

#33788: Check the return value of tor_inet_ntop() and tor_inet_ntoa()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, 044-should, security-  |  Actual Points:
  low, 035-backport, 041-backport,   |
  042-backport, 043-backport, outreachy-ipv6,|
  ipv6, 044-must |
Parent ID:  #33768   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-can
-+-
Changes (by rl1987):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33788 [Core Tor/Tor]: Check the return value of tor_inet_ntop() and tor_inet_ntoa()

[Tor Bug Tracker & Wiki]

#33788: Check the return value of tor_inet_ntop() and tor_inet_ntoa()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, 044-should, security-  |  Actual Points:
  low, 035-backport, 041-backport,   |
  042-backport, 043-backport, outreachy-ipv6,|
  ipv6, 044-must |
Parent ID:  #33768   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-can
-+-
Changes (by nickm):

 * sponsor:  Sponsor55-must => Sponsor55-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33788 [Core Tor/Tor]: Check the return value of tor_inet_ntop() and tor_inet_ntoa()

[Tor Bug Tracker & Wiki]

#33788: Check the return value of tor_inet_ntop() and tor_inet_ntoa()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, 044-should, security-  |  Actual Points:
  low, 035-backport, 041-backport,   |
  042-backport, 043-backport, outreachy-ipv6,|
  ipv6, 044-must |
Parent ID:  #33768   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-must
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Looks mostly okay, but some of the checks are incorrect.  I've left
 comments on the code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33788 [Core Tor/Tor]: Check the return value of tor_inet_ntop() and tor_inet_ntoa()

[Tor Bug Tracker & Wiki]

#33788: Check the return value of tor_inet_ntop() and tor_inet_ntoa()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, 044-should, security-  |  Actual Points:
  low, 035-backport, 041-backport,   |
  042-backport, 043-backport, outreachy-ipv6,|
  ipv6, 044-must |
Parent ID:  #33768   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-must
-+-
Changes (by asn):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33788 [Core Tor/Tor]: Check the return value of tor_inet_ntop() and tor_inet_ntoa()

[Tor Bug Tracker & Wiki]

#33788: Check the return value of tor_inet_ntop() and tor_inet_ntoa()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, 044-should, security-  |  Actual Points:
  low, 035-backport, 041-backport,   |
  042-backport, 043-backport, outreachy-ipv6,|
  ipv6   |
Parent ID:  #33768   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-must
-+-
Changes (by rl1987):

 * status:  needs_revision => needs_review


Comment:

 https://github.com/torproject/tor/pull/1902

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33788 [Core Tor/Tor]: Check the return value of tor_inet_ntop() and tor_inet_ntoa()

[Tor Bug Tracker & Wiki]

#33788: Check the return value of tor_inet_ntop() and tor_inet_ntoa()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, 044-should, security-  |  Actual Points:
  low, 035-backport, 041-backport,   |
  042-backport, 043-backport, outreachy-ipv6,|
  ipv6   |
Parent ID:  #33768   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * keywords:
 044-should, security-low, 035-backport, 041-backport, 042-backport,
 043-backport, outreachy-ipv6, ipv6
 =>
 extra-review, 044-should, security-low, 035-backport, 041-backport,
 042-backport, 043-backport, outreachy-ipv6, ipv6
 * reviewer:  teor =>
 * status:  needs_review => needs_revision


Comment:

 Sorry it's taken a while for me to do this review, things have been a bit
 chaotic recently.

 I think this code looks good, but it's also a bit complicated. And I'm not
 sure if we have test coverage for all these changes.

 There are also some conflicts with master.

 So I'd like someone else to review, once you've resolved those conflicts.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33788 [Core Tor/Tor]: Check the return value of tor_inet_ntop() and tor_inet_ntoa()

[Tor Bug Tracker & Wiki]

#33788: Check the return value of tor_inet_ntop() and tor_inet_ntoa()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  044-should, security-low,|  Actual Points:
  035-backport, 041-backport, 042-backport,  |
  043-backport, outreachy-ipv6, ipv6 |
Parent ID:  #33768   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor55-must
-+-
Changes (by asn):

 * reviewer:   => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33788 [Core Tor/Tor]: Check the return value of tor_inet_ntop() and tor_inet_ntoa()

[Tor Bug Tracker & Wiki]

#33788: Check the return value of tor_inet_ntop() and tor_inet_ntoa()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  044-should, security-low,|  Actual Points:
  035-backport, 041-backport, 042-backport,  |
  043-backport, outreachy-ipv6, ipv6 |
Parent ID:  #33768   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-must
-+-
Changes (by rl1987):

 * status:  new => needs_review


Comment:

 https://github.com/torproject/tor/pull/1859

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33788 [Core Tor/Tor]: Check the return value of tor_inet_ntop() and tor_inet_ntoa() (was: Check the return value of tor_inet_ntop())

[Tor Bug Tracker & Wiki]

#33788: Check the return value of tor_inet_ntop() and tor_inet_ntoa()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  044-should, security-low,|  Actual Points:
  035-backport, 041-backport, 042-backport,  |
  043-backport, outreachy-ipv6, ipv6 |
Parent ID:  #33768   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-must
-+-

Old description:

> The following functions don't check the return value of tor_inet_ntop():
> * tor_dup_ip(), IPv4 only, unlikely to be a serious bug
> * evdns_callback(), multiple times, IPv6, could be serious
>
> These functions should log a bug log using BUG(), and return an error.
>
> We will also need to make their callers check for the error.

New description:

 The following functions don't check the return value of tor_inet_ntop() or
 tor_inet_ntoa():

 IPv6, could be serious:
 * evdns_callback(), multiple times

 IPv4 only, unlikely to be a serious bug:
 * tor_dup_ip()
 * fmt_addr32()
 * evdns_wildcard_check_callback()

 These functions should log a bug log using BUG() or tor_assert_nonfatal(),
 and return an error. (Or for the formatting functions, a sensible
 placeholder string.)

 We will also need to make their callers check for the error.

--

Comment (by teor):

 Also fix tor_inet_ntoa().

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs