[tor-bugs] #33890 [Applications/Tor Browser]: Rename .xul to .xhtml

[Tor Bug Tracker & Wiki]

#33890: Rename .xul to .xhtml
--+
 Reporter:  acat  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
  |  TorBrowserTeam202004
Actual Points:|  Parent ID:  #33533
   Points:|   Reviewer:
  Sponsor:|
--+
 Firefox did a mass rename of all .xul files to .xhtml in
 https://bugzilla.mozilla.org/show_bug.cgi?id=1579952. We need to do the
 same in torbutton and tor-launcher, as well as in several Tor Browser
 patches that involve UI.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33890 [Applications/Tor Browser]: Rename .xul to .xhtml

[Tor Bug Tracker & Wiki]

#33890: Rename .xul to .xhtml
--+--
 Reporter:  acat  |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202004R |  Actual Points:
Parent ID:  #33533| Points:
 Reviewer:|Sponsor:
--+--
Changes (by acat):

 * keywords:  TorBrowserTeam202004 => TorBrowserTeam202004R
 * status:  new => needs_review


Comment:

 torbutton patch:
 
https://github.com/acatarineu/torbutton/commit/782cc4b27d580c43d3db78690f9ab0803eb854af

 tor-launcher patch: https://github.com/acatarineu/tor-
 launcher/commit/0bd09322f4af1b36e9ee60411a9fae608132d92a

 For Tor Browser patches, this is already done in #33533, so perhaps this
 can be reviewed there.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33890 [Applications/Tor Browser]: Rename .xul to .xhtml

[Tor Bug Tracker & Wiki]

#33890: Rename .xul to .xhtml
--+
 Reporter:  acat  |  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202004  |  Actual Points:
Parent ID:  #33533| Points:
 Reviewer:|Sponsor:
--+
Changes (by mcs):

 * status:  needs_review => needs_revision
 * keywords:  TorBrowserTeam202004R => TorBrowserTeam202004


Comment:

 Replying to [comment:1 acat]:
 > torbutton patch:
 
https://github.com/acatarineu/torbutton/commit/782cc4b27d580c43d3db78690f9ab0803eb854af

 Looks good. Just a couple of things:
 * Please edit the comment in tor-circuit-display.js that refers to
 "torbutton.xul" to instead point to browser/base/content/browser.xhtml.
 * Is there a ticket that covers general cleanup of torbutton.css and
 related files? For example, does #tor-button still exist anywhere? Maybe
 this is covered by #28745?

 > tor-launcher patch: https://github.com/acatarineu/tor-
 launcher/commit/0bd09322f4af1b36e9ee60411a9fae608132d92a

 In src/install.rdf, please also remove the commented out block with
 . It has never been used and keeping it causes grep to find
 a reference to xul.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33890 [Applications/Tor Browser]: Rename .xul to .xhtml

[Tor Bug Tracker & Wiki]

#33890: Rename .xul to .xhtml
--+--
 Reporter:  acat  |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202004R |  Actual Points:
Parent ID:  #33533| Points:
 Reviewer:|Sponsor:
--+--
Changes (by acat):

 * keywords:  TorBrowserTeam202004 => TorBrowserTeam202004R
 * status:  needs_revision => needs_review


Comment:

 Thanks, revised in

 
https://github.com/acatarineu/torbutton/commit/3541943d842162641100741cb6b08cb45058038f

 and

 https://github.com/acatarineu/tor-
 launcher/commit/de405aee1a4e5c848905b9f52bccc2764cdbb8c7

 Replying to [comment:2 mcs]:
 > * Is there a ticket that covers general cleanup of torbutton.css and
 related files? For example, does #tor-button still exist anywhere? Maybe
 this is covered by #28745?

 Yes, from the most recent branch in that ticket (28745+5),
 
https://github.com/acatarineu/torbutton/commit/8070594b1eeed499eae5b18980d6d1c363090cf1
 should deal with that cleanup.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33890 [Applications/Tor Browser]: Rename .xul to .xhtml

[Tor Bug Tracker & Wiki]

#33890: Rename .xul to .xhtml
--+--
 Reporter:  acat  |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202004R |  Actual Points:  0.1
Parent ID:  #33533| Points:
 Reviewer:|Sponsor:
--+--
Changes (by acat):

 * actualpoints:   => 0.1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33890 [Applications/Tor Browser]: Rename .xul to .xhtml

[Tor Bug Tracker & Wiki]

#33890: Rename .xul to .xhtml
--+-
 Reporter:  acat  |  Owner:  tbb-team
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202004R |  Actual Points:  0.1
Parent ID:  #33533| Points:
 Reviewer:|Sponsor:
--+-
Changes (by mcs):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:3 acat]:
 > Thanks, revised in
 >
 >
 
https://github.com/acatarineu/torbutton/commit/3541943d842162641100741cb6b08cb45058038f
 >
 > and
 >
 > https://github.com/acatarineu/tor-
 launcher/commit/de405aee1a4e5c848905b9f52bccc2764cdbb8c7

 r=brade,r=mcs
 Looks good. Thanks for making the changes we requested.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33890 [Applications/Tor Browser]: Rename .xul to .xhtml

[Tor Bug Tracker & Wiki]

#33890: Rename .xul to .xhtml
--+-
 Reporter:  acat  |  Owner:  tbb-team
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202006R |  Actual Points:  0.1
Parent ID:  #33533| Points:
 Reviewer:|Sponsor:
--+-

Comment (by gk):

 The `tor-launcher` change landed on `master` (commit
 `de405aee1a4e5c848905b9f52bccc2764cdbb8c7`).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs