Re: [tor-bugs] #20875 [Core Tor/Tor]: Non-fatal assertion !(delay == INT_MAX) failed in next_random_exponential_delay at src/or/directory.c:3792

[Tor Bug Tracker & Wiki]

#20875: Non-fatal assertion !(delay == INT_MAX) failed in
next_random_exponential_delay at src/or/directory.c:3792
--+
 Reporter:  arma  |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.5-alpha
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 Changes above look good to me; applied as
 0815f96416676ace7cfdb5c29000d8cd6ee3459f

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20875 [Core Tor/Tor]: Non-fatal assertion !(delay == INT_MAX) failed in next_random_exponential_delay at src/or/directory.c:3792

[Tor Bug Tracker & Wiki]

#20875: Non-fatal assertion !(delay == INT_MAX) failed in
next_random_exponential_delay at src/or/directory.c:3792
--+
 Reporter:  arma  |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  High  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.5-alpha
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20875 [Core Tor/Tor]: Non-fatal assertion !(delay == INT_MAX) failed in next_random_exponential_delay at src/or/directory.c:3792

[Tor Bug Tracker & Wiki]

#20875: Non-fatal assertion !(delay == INT_MAX) failed in
next_random_exponential_delay at src/or/directory.c:3792
--+
 Reporter:  arma  |  Owner:
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.5-alpha
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * priority:  Medium => High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20875 [Core Tor/Tor]: Non-fatal assertion !(delay == INT_MAX) failed in next_random_exponential_delay at src/or/directory.c:3792

[Tor Bug Tracker & Wiki]

#20875: Non-fatal assertion !(delay == INT_MAX) failed in
next_random_exponential_delay at src/or/directory.c:3792
--+
 Reporter:  arma  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.5-alpha
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * version:   => Tor: 0.2.9.5-alpha
 * points:   => 0.1


Comment:

 I think we introduced this one in 0.2.9.5-alpha.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20875 [Core Tor/Tor]: Non-fatal assertion !(delay == INT_MAX) failed in next_random_exponential_delay at src/or/directory.c:3792

[Tor Bug Tracker & Wiki]

#20875: Non-fatal assertion !(delay == INT_MAX) failed in
next_random_exponential_delay at src/or/directory.c:3792
--+
 Reporter:  arma  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by teor):

 Having delay == INT_MAX is entirely reasonable, and isn't a bug.
 It happens every time the last delay was INT_MAX.

 I think we should turn:
 {{{
  if (BUG(delay == INT_MAX))
delay -= 1; /* prevent overflow */
 }}}

 Into:
 {{{
  if (delay == INT_MAX)
delay -= 1; /* prevent overflow */
 }}}

 Or:
 {{{
  if (delay == INT_MAX)
return INT_MAX;
 }}}

 I also think we should add a precondition right at the top:
 {{{
  if (BUG(max_delay < 0))
max_delay = 0;
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs