Re: [tor-bugs] #22550 [Core Tor/Tor]: pkg-config fails to find static library for zstd

[Tor Bug Tracker & Wiki]

#22550: pkg-config fails to find static library for zstd
--+
 Reporter:  yurivict271   |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  not a bug
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by yurivict271):

 * status:  accepted => closed
 * resolution:   => not a bug


Comment:

 It wasn't a problem of pkg-config or Tor. It was a faulty build that
 somehow produced libzstd.a with stripped symbols.

 I will update the FreeBSD port.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22550 [Core Tor/Tor]: pkg-config fails to find static library for zstd

[Tor Bug Tracker & Wiki]

#22550: pkg-config fails to find static library for zstd
--+
 Reporter:  yurivict271   |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  High  |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by yurivict271):

 It doesn't seem like pkgconfig supports static libraries. Since tor
 supports static build, pkgconfig appears to be a bad choice.

 Why don't you just use AC_SEARCH_LIBS from autotools to search for
 libraries instead?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22550 [Core Tor/Tor]: pkg-config fails to find static library for zstd

[Tor Bug Tracker & Wiki]

#22550: pkg-config fails to find static library for zstd
--+
 Reporter:  yurivict271   |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  High  |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted
 * priority:  Medium => High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22550 [Core Tor/Tor]: pkg-config fails to find static library for zstd

[Tor Bug Tracker & Wiki]

#22550: pkg-config fails to find static library for zstd
--+
 Reporter:  yurivict271   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 We should make sure to write and upstream such a patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22550 [Core Tor/Tor]: pkg-config fails to find static library for zstd

[Tor Bug Tracker & Wiki]

#22550: pkg-config fails to find static library for zstd
--+
 Reporter:  yurivict271   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by yurivict271):

 Replying to [comment:2 teor]:
 > We have two options for a workaround here:
 > * try to find the static library without pkg-config
 > * check at configure time for the library we want to use, and
 automatically disable zstd if it isn't available (or ask the user to
 disable zstd)

 Another option is to fix .pc and submit a PR to
 facebook:https://github.com/facebook/zstd/issues/719


 > FreeBSD has disabled *both* zstd and lzma compression due to this bug.

 I will enable lzma, no worries.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22550 [Core Tor/Tor]: pkg-config fails to find static library for zstd

[Tor Bug Tracker & Wiki]

#22550: pkg-config fails to find static library for zstd
--+
 Reporter:  yurivict271   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by teor):

 We have two options for a workaround here:
 * try to find the static library without pkg-config
 * check at configure time for the library we want to use, and
 automatically disable zstd if it isn't available (or ask the user to
 disable zstd)

 FreeBSD has disabled *both* zstd and lzma compression due to this bug.
 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219864
 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219571

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22550 [Core Tor/Tor]: pkg-config fails to find static library for zstd

[Tor Bug Tracker & Wiki]

#22550: pkg-config fails to find static library for zstd
--+
 Reporter:  yurivict271   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * component:  - Select a component => Core Tor/Tor
 * milestone:   => Tor: 0.3.1.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs