Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  implemented
  best-practice unit-testing new-developers  |  Actual Points:  1
  travis review-group-21 |
Parent ID:   | Points:  .5
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 {{{
 m
  e
   r
g
 e
  d
 }}}
 !

 Now let's see what happens.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  1
  best-practice unit-testing new-developers  |
  travis review-group-21 |
Parent ID:   | Points:  .5
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 Replying to [comment:24 isis]:
 > Replying to [comment:21 nickm]:
 > > Hi!  I have some questions:
 > >   - If we merge this, will it start spamming the #tor-bots IRC?
 >
 > It will spam #tor-bots when someone makes a commit which breaks things
 when the commit's parent was previously working, and it will also spam for
 a commit which fixes things when the commit's parent was previously
 broken.  Do we want different behaviour?

 Maybe we only want that for some people? I don't think we care if some
 person we've never heard of starts breaking their github tor branches.

 > >   - Do we want to consider adding --enable-fragile-hardening?
 >
 > We can do that, if that is what we expect to pass. (I think that's a
 reasonable expectation. Also, side note, we should make sure to document
 our expectations in doc/HACKING better!) Added in
 
[https://gitweb.torproject.org/user/isis/tor.git/commit/?h=bug22636=c91a57ccf90308c6728184b43519f96b61acb95d
 commit] `c91a57ccf9`.

 Cool

 > >   - Should we install the optional dependencies (zstd, lzma2, scrypt,
 ...)
 >
 > Sure, done in
 
[https://gitweb.torproject.org/user/isis/tor.git/commit/?h=bug22636=1bb00fb812c0df7a574ed62e9f53b0e8192c7d04
 commit] `1bb00fb812`. (Except, for some reason, Ubuntu Trusty doesn't have
 a libzstd package available.)

 Well, at least we tried :)

 > >   - In the homebrew stanza, should all of those lines have "brew
 outdated openssl" or only the openssl one?
 >
 > Oh oops, good catch. Fixed in
 
[https://gitweb.torproject.org/user/isis/tor.git/commit/?h=bug22636=8f8689f70235dc19cbc5092ea148af5772a9cdc3
 commit] `8f8689f70235`.
 >
 > >   - Should we skip rust installation if we won't be building with
 rust, in order to save time?
 >
 > Yes, this is a great idea. Done in
 
[https://gitweb.torproject.org/user/isis/tor.git/commit/?h=bug22636=e5dd07a4c64fd2a4132ab1f6dec64640a95da35e
 commit] `e5dd07a4c64`. It doesn't seem to save any time though, probably
 if I had to guess because there's some transparent proxy setup with a
 cache.
 >
 > I've updated `bug22636_0.2.4_squashed` and `bug22636_0.3.1_squashed` and
 tests [https://travis-ci.org/isislovecruft/tor/builds/257127758 are]
 [https://travis-ci.org/isislovecruft/tor/builds/257126606 passing]
 respectively.
 >
 > Replying to [comment:23 nickm]:
 > > Oh, one more thing:
 > >
 > >   --enable-fatal-warnings was called --enable-gcc-warnings before
 0.2.9.x
 >
 > Oh right. Thanks! There's now a `bug22636_0.2.9`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug22636_0.2.9
 branch] for 0.2.9 and 0.3.0 which contains everything from the
 `bug22636_0.2.4_squashed` branch, except it uses --enable-fatal-warnings
 instead. `bug22636_0.2.4_squashed` has now been changed to use --enable-
 gcc-warnings.

 Sounds good!  I'll give it all another look over, and merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  1
  best-practice unit-testing new-developers  |
  travis review-group-21 |
Parent ID:   | Points:  .5
 Reviewer:  nickm|Sponsor:
-+-
Changes (by isis):

 * status:  needs_revision => needs_review
 * actualpoints:  .5 => 1


Comment:

 Replying to [comment:21 nickm]:
 > Hi!  I have some questions:
 >   - If we merge this, will it start spamming the #tor-bots IRC?

 It will spam #tor-bots when someone makes a commit which breaks things
 when the commit's parent was previously working, and it will also spam for
 a commit which fixes things when the commit's parent was previously
 broken.  Do we want different behaviour?

 >   - Do we want to consider adding --enable-fragile-hardening?

 We can do that, if that is what we expect to pass. (I think that's a
 reasonable expectation. Also, side note, we should make sure to document
 our expectations in doc/HACKING better!) Added in
 
[https://gitweb.torproject.org/user/isis/tor.git/commit/?h=bug22636=c91a57ccf90308c6728184b43519f96b61acb95d
 commit] `c91a57ccf9`.

 >   - Should we install the optional dependencies (zstd, lzma2, scrypt,
 ...)

 Sure, done in
 
[https://gitweb.torproject.org/user/isis/tor.git/commit/?h=bug22636=1bb00fb812c0df7a574ed62e9f53b0e8192c7d04
 commit] `1bb00fb812`. (Except, for some reason, Ubuntu Trusty doesn't have
 a libzstd package available.)

 >   - In the homebrew stanza, should all of those lines have "brew
 outdated openssl" or only the openssl one?

 Oh oops, good catch. Fixed in
 
[https://gitweb.torproject.org/user/isis/tor.git/commit/?h=bug22636=8f8689f70235dc19cbc5092ea148af5772a9cdc3
 commit] `8f8689f70235`.

 >   - Should we skip rust installation if we won't be building with rust,
 in order to save time?

 Yes, this is a great idea. Done in
 
[https://gitweb.torproject.org/user/isis/tor.git/commit/?h=bug22636=e5dd07a4c64fd2a4132ab1f6dec64640a95da35e
 commit] `e5dd07a4c64`. It doesn't seem to save any time though, probably
 if I had to guess because there's some transparent proxy setup with a
 cache.

 I've updated `bug22636_0.2.4_squashed` and `bug22636_0.3.1_squashed` and
 tests [https://travis-ci.org/isislovecruft/tor/builds/257127758 are]
 [https://travis-ci.org/isislovecruft/tor/builds/257126606 passing]
 respectively.

 Replying to [comment:23 nickm]:
 > Oh, one more thing:
 >
 >   --enable-fatal-warnings was called --enable-gcc-warnings before
 0.2.9.x

 Oh right. Thanks! There's now a `bug22636_0.2.9`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug22636_0.2.9
 branch] for 0.2.9 and 0.3.0 which contains everything from the
 `bug22636_0.2.4_squashed` branch, except it uses --enable-gcc-warnings
 instead.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis review-group-21 |
Parent ID:   | Points:  .5
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 Oh, one more thing:

* --enable-fatal-warnings was called --enable-gcc-warnings before
 0.2.9.x

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis review-group-21 |
Parent ID:   | Points:  .5
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Putting this in needs_revision, but please feel free to put it back into
 needs_review if there are no problems above.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis review-group-21 |
Parent ID:   | Points:  .5
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 Hi!  I have some questions:
   - If we merge this, will it start spamming the #tor-bots IRC?
   - Do we want to consider adding --enable-fragile-hardening?
   - Should we install the optional dependencies (zstd, lzma2, scrypt, ...)
   - In the homebrew stanza, should all of those lines have "brew outdated
 openssl" or only the openssl one?
   - Should we skip rust installation if we won't be building with rust, in
 order to save time?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis review-group-21 |
Parent ID:   | Points:  .5
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by isis):

 Note that the squashed branches are now `bug22636_0.2.4_squashed`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug22636_0.2.4_squashed
 here] and `bug22636_0.3.1_squashed`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug22636_0.3.1_squashed
 here]. CI for [https://travis-ci.org/isislovecruft/tor/builds/254627602
 each] [https://travis-ci.org/isislovecruft/tor/builds/254627297 one] pass
 (because the 0.3.1 branch is now based on a version of `maint-0.3.1` that
 includes the patch for #22830).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis review-group-21 |
Parent ID:   | Points:  .5
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by isis):

 * keywords:
 continuous-integration ci testing best-practice unit-testing new-
 developers travis
 =>
 continuous-integration ci testing best-practice unit-testing new-
 developers travis review-group-21


Comment:

 Selfishly putting tickets I care about in review-group-21. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:  .5
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by isis):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:  .5
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by isis):

 Replying to [comment:15 isis]:
 > Replying to [comment:14 catalyst]:
 > > Thanks!  This is very useful to have.  Technically this looks mostly
 good to me, with a few minor (mostly documentation) nits.
 > >
 > > I have a GitHub account with Travis CI enabled.  I confirm that tests
 on `bug22636_0.3.1` [https://travis-ci.org/tlyu/tor/builds/254404828 pass]
 and tests on `bug22636_0.2.4` [https://travis-
 ci.org/tlyu/tor/builds/254484617 pass].
 > >
 > > I'm trying to understand the differences between this and our Jenkins
 configurations.  It looks like our Jenkins config turns on `--disable-
 silent-rules` to get a bit more verbosity on the compile lines; should we
 do likewise?
 >
 > Yes, this is a good idea.

 Okay, this is done in
 
[https://gitweb.torproject.org/user/isis/tor.git/commit/?h=bug22636=63928a0b1294324249c69c8165e13c808e11a335
 commit] `63928a0b1294324249c69c8165e13c808e11a335`.

 > > Jenkins also does `make check` instead of `make check-spaces` and
 `make test`.  Is there some reason to not do `make check`?  I think that
 doesn't significantly increase the run time, but I haven't measured the
 difference yet.
 >
 > This is probably a good idea, as it tests more. The output might be a
 bit tricky to get, because the way it is configured right now, if some
 step fails, the whole CI build will fail fast.  So e.g. if compilation
 failed, don't waste more time testing.  Also if `make check-spaces` fails,
 your commit needs to be fixed up anyway, so again don't bother wasting
 time testing.  Whereas if we run `make check` it does all this in one go,
 and if it fails some step, it only reports that at the end of everything.
 Also, all the output that we'd need in order to see what failed gets
 shoved into a file (but possibly I can get that output with a `after-
 script` stanza?).

 This is also done in
 
[https://gitweb.torproject.org/user/isis/tor.git/commit/?h=bug22636=63928a0b1294324249c69c8165e13c808e11a335
 commit] `63928a0b1294324249c69c8165e13c808e11a335`.

 > > Commenting the `.travis.yml` with brief explanations of these choices
 might be a good idea.  Also, squashing the commits somewhat would be good.
 Some of the commit messages, like the ones involving Rust config choices,
 might work better as comments in `.travis.yml`.
 >
 > Yes, this is a great idea.

 Done in
 
[https://gitweb.torproject.org/user/isis/tor.git/commit/?h=bug22636=ca4168ea98818b1f291449596a7885671aefeded
 commit] `ca4168ea98818b1f291449596a7885671aefeded`.

 I'll squash all the branches once these new changes are approved.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:  .5
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by isis):

 Replying to [comment:14 catalyst]:
 > Thanks!  This is very useful to have.  Technically this looks mostly
 good to me, with a few minor (mostly documentation) nits.
 >
 > I have a GitHub account with Travis CI enabled.  I confirm that tests on
 `bug22636_0.3.1` [https://travis-ci.org/tlyu/tor/builds/254404828 pass]
 and tests on `bug22636_0.2.4` [https://travis-
 ci.org/tlyu/tor/builds/254484617 pass].
 >
 > I'm trying to understand the differences between this and our Jenkins
 configurations.  It looks like our Jenkins config turns on `--disable-
 silent-rules` to get a bit more verbosity on the compile lines; should we
 do likewise?

 Yes, this is a good idea.

 > Jenkins also does `make check` instead of `make check-spaces` and `make
 test`.  Is there some reason to not do `make check`?  I think that doesn't
 significantly increase the run time, but I haven't measured the difference
 yet.

 This is probably a good idea, as it tests more. The output might be a bit
 tricky to get, because the way it is configured right now, if some step
 fails, the whole CI build will fail fast.  So e.g. if compilation failed,
 don't waste more time testing.  Also if `make check-spaces` fails, your
 commit needs to be fixed up anyway, so again don't bother wasting time
 testing.  Whereas if we run `make check` it does all this in one go, and
 if it fails some step, it only reports that at the end of everything.
 Also, all the output that we'd need in order to see what failed gets
 shoved into a file (but possibly I can get that output with a `after-
 script` stanza?).

 > Commenting the `.travis.yml` with brief explanations of these choices
 might be a good idea.  Also, squashing the commits somewhat would be good.
 Some of the commit messages, like the ones involving Rust config choices,
 might work better as comments in `.travis.yml`.

 Yes, this is a great idea.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:  .5
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Thanks!  This is very useful to have.  Technically this looks mostly good
 to me, with a few minor (mostly documentation) nits.

 I have a GitHub account with Travis CI enabled.  I confirm that tests on
 `bug22636_0.3.1` [https://travis-ci.org/tlyu/tor/builds/254404828 pass]
 and tests on `bug22636_0.2.4` [https://travis-
 ci.org/tlyu/tor/builds/254484617 pass].

 I'm trying to understand the differences between this and our Jenkins
 configurations.  It looks like our Jenkins config turns on `--disable-
 silent-rules` to get a bit more verbosity on the compile lines; should we
 do likewise?  Jenkins also does `make check` instead of `make check-
 spaces` and `make test`.  Is there some reason to not do `make check`?  I
 think that doesn't significantly increase the run time, but I haven't
 measured the difference yet.

 Commenting the `.travis.yml` with brief explanations of these choices
 might be a good idea.  Also, squashing the commits somewhat would be good.
 Some of the commit messages, like the ones involving Rust config choices,
 might work better as comments in `.travis.yml`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:  .5
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by isis):

 Replying to [comment:12 nickm]:
 > Sounds fine -- actually, if you just do a backport to 0.2.4, then when I
 merge to maint-0.2.4, it should merge forward cleanly to everything else.

 Okay, done in my `bug22636_0.2.4`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug22636_0.2.4
 branch]. This is for 0.2.4 through 0.3.0.  I rebased out all the rust
 toolchain stuff, since that would fail and also waste time. [https
 ://travis-ci.org/isislovecruft/tor/builds/253404823 Tests pass].

 My `bug22636_0.3.1`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug22636_0.3.1
 branch] is for 0.3.1. [https://travis-
 ci.org/isislovecruft/tor/builds/253406184 Tests pass].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:  .5
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by nickm):

 Sounds fine -- actually, if you just do a backport to 0.2.4, then when I
 merge to maint-0.2.4, it should merge forward cleanly to everything else.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:  .5
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by catalyst):

 * reviewer:   => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:  .5
 Reviewer:   |Sponsor:
-+-

Comment (by isis):

 Also this is totally safe to back-port to… well everything. (Not only
 safe, but potentially an improvement for people trying to make bugfixes on
 older releases.) Should I make branches to port it back to everything
 listed in
 
https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/CoreTorReleases#Current
 ?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:  .5
 Reviewer:   |Sponsor:
-+-

Comment (by isis):

 Replying to [comment:8 isis]:
 > Oh actually, this needs a changes file.  Let me do that.

 Okay done.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:  .5
 Reviewer:   |Sponsor:
-+-

Comment (by isis):

 Oh actually, this needs a changes file.  Let me do that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:  .5
 Reviewer:   |Sponsor:
-+-
Changes (by isis):

 * status:  assigned => needs_review
 * points:   => .5
 * actualpoints:   => .5
 * milestone:  Tor: unspecified => Tor: 0.3.2.x-final


Comment:

 Hi! Patrick (patrickod) did a bunch of work on this, and I did a bit of
 work on top of that. Our changes are in my `bug22636`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug22636 branch],
 and as you can see, [https://travis-
 ci.org/isislovecruft/tor/builds/252621270 CI is passing]. :)

 Note that it passing depends on the minor fix for #22830 (changing `$HOME`
 to `$CARGO_HOME` in `src/rust/tor_util/include.am`, which I've included in
 this branch in
 
[https://gitweb.torproject.org/user/isis/tor.git/commit/?h=bug22636=4c580a609e06b93a1ba3bb73ff4df959084a86dd
 commit] `4c580a609e`.

 If you have any questions about the whats or the whys of any of the
 directives in `.travis.yml`, please feel free to ask.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by isis):

 * status:  new => assigned
 * owner:   => patrickod


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * priority:  Medium => High
 * keywords:  ci =>
 continuous-integration ci testing best-practice unit-testing new-
 developers travis


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
--+--
 Reporter:  catalyst  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ci|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by patrickod):

 Yep still interested in tackling this. I'll hopefully have time in the
 coming week to get this done.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
--+--
 Reporter:  catalyst  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ci|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by isis):

 One of the things we've been talking about in the Rust channel is that it
 would be great if the .travis.yml had a target in it's build matrix for
 building with rust support. (See
 https://trac.torproject.org/projects/tor/wiki/RustInTor for how to build.)
 I'm not sure the best Travis way to do this, as it may involve adding a
 pre-build section which does rustup, or just say that rust is the target
 language and expect it to also have a decent gcc installed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
--+--
 Reporter:  catalyst  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ci|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by dgoulet):

 * milestone:   => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
--+-
 Reporter:  catalyst  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ci|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by isis):

 * keywords:   => ci
 * cc: patrickod (added)


Comment:

 CCing Patrick from NoiseTor on this, since (IIRC) it was originally his
 idea and I believe he is still interested in working on this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs