Re: [tor-bugs] #23215 [Metrics/CollecTor]: set annotation from descriptor during sync-runs

[Tor Bug Tracker & Wiki]

#23215: set annotation from descriptor during sync-runs
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  CollecTor 1.3.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Tweaked the change log a bit, rebased to master, and pushed.

 Regarding variable names, I think we shouldn't use abbreviations other
 than commonly known ones like IP or HTTP etc. It's true that there are
 quite a few `sb` and `is` and so on in the code. We might replace them
 with more meaningful names.

 Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23215 [Metrics/CollecTor]: set annotation from descriptor during sync-runs

[Tor Bug Tracker & Wiki]

#23215: set annotation from descriptor during sync-runs
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  CollecTor 1.3.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 I added a little more test variety and the changelog entry as
 [https://gitweb.torproject.org/user/iwakeh/collector.git/log/?h=task-23215
 another commit to the above branch].

 Regarding the nitpick:  I find it easier to distinguish between "anno" and
 annos" than "annotation" and "annotations"; in general very long variable
 names feel/look like cluttering.  I changed a few occurrences, but would
 not want to make it a rule.  Anyway, there are all these 'sb', 'is',
 'bais', etc. all over the codebases.  It is true though, that 'anno' might
 be misunderstood as year.

 Setting this to merge ready as I only made very minor changes.  Please
 check again before merging.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23215 [Metrics/CollecTor]: set annotation from descriptor during sync-runs

[Tor Bug Tracker & Wiki]

#23215: set annotation from descriptor during sync-runs
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  CollecTor 1.3.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by karsten):

 Looks good!

 Nitpick: let's avoid abbreviations in variable names and write
 "annotations" instead of "annos" and "result" instead of "res". It'll cost
 5 seconds more to write this code but save at least 5 seconds each time
 somebody reads this code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23215 [Metrics/CollecTor]: set annotation from descriptor during sync-runs

[Tor Bug Tracker & Wiki]

#23215: set annotation from descriptor during sync-runs
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  CollecTor 1.3.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by iwakeh):

 * status:  accepted => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23215 [Metrics/CollecTor]: set annotation from descriptor during sync-runs

[Tor Bug Tracker & Wiki]

#23215: set annotation from descriptor during sync-runs
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  CollecTor 1.3.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by iwakeh):

 Please take a look at the two commits on top of
 [https://gitweb.torproject.org/user/iwakeh/collector.git/log/?h=task-23215
 this branch].

 When the change and test data make sense I'll add more test data with
 currently valid annotations and the corresponding changelog entry.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23215 [Metrics/CollecTor]: set annotation from descriptor during sync-runs

[Tor Bug Tracker & Wiki]

#23215: set annotation from descriptor during sync-runs
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  CollecTor 1.3.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by iwakeh):

 * owner:  metrics-team => iwakeh
 * status:  needs_information => accepted


Comment:

 Fine, implementation patch follows.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23215 [Metrics/CollecTor]: set annotation from descriptor during sync-runs

[Tor Bug Tracker & Wiki]

#23215: set annotation from descriptor during sync-runs
---+---
 Reporter:  iwakeh |  Owner:  metrics-team
 Type:  defect | Status:  needs_information
 Priority:  Medium |  Milestone:  CollecTor 1.3.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by karsten):

 It does sound plausible, though I'd have to see the code to be sure.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23215 [Metrics/CollecTor]: set annotation from descriptor during sync-runs

[Tor Bug Tracker & Wiki]

#23215: set annotation from descriptor during sync-runs
---+---
 Reporter:  iwakeh |  Owner:  metrics-team
 Type:  defect | Status:  needs_information
 Priority:  Medium |  Milestone:  CollecTor 1.3.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by iwakeh):

 Is the above approach ok?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23215 [Metrics/CollecTor]: set annotation from descriptor during sync-runs

[Tor Bug Tracker & Wiki]

#23215: set annotation from descriptor during sync-runs
---+---
 Reporter:  iwakeh |  Owner:  metrics-team
 Type:  defect | Status:  needs_information
 Priority:  Medium |  Milestone:  CollecTor 1.3.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by iwakeh):

 * status:  new => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs