Re: [tor-bugs] #24197 [Applications/Tor Browser]: Building Windows 64 firefox with the sandbox enabled fails

[Tor Bug Tracker & Wiki]

#24197: Building Windows 64 firefox with the sandbox enabled fails
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, GeorgKoppen201805,  |  Actual Points:
  TorBrowserTeam201806   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:15 tom]:
 > Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1461421

 We cherry-picked the proposed fix (commit
 a64a7c2de648ad87f392e407a92589515a72b0ef on `tor-browser-60.0.1esr-8.0-1)
 and are good for now. We'll backport later on the fix that actually
 landed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24197 [Applications/Tor Browser]: Building Windows 64 firefox with the sandbox enabled fails

[Tor Bug Tracker & Wiki]

#24197: Building Windows 64 firefox with the sandbox enabled fails
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201805,   |  Actual Points:
  GeorgKoppen201805  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by tom):

 Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1461421

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24197 [Applications/Tor Browser]: Building Windows 64 firefox with the sandbox enabled fails

[Tor Bug Tracker & Wiki]

#24197: Building Windows 64 firefox with the sandbox enabled fails
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201801,   |  Actual Points:
  GeorgKoppen201801  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 The two attached patches look good. I put them onto our new alpha branch,
 `tor-browser-52.5.2esr-8.0-1` as commits
 bc76eaae7a83e73d7e5ba5e759829afa9df7bf5b and
 15939efc6cbd64ca1f20e826e2ab0329bc42a659.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24197 [Applications/Tor Browser]: Building Windows 64 firefox with the sandbox enabled fails

[Tor Bug Tracker & Wiki]

#24197: Building Windows 64 firefox with the sandbox enabled fails
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201801,   |  Actual Points:
  GeorgKoppen201801  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm => tbb-rbm, TorBrowserTeam201801, GeorgKoppen201801


Comment:

 Replying to [comment:4 boklm]:
 > Those patches are fixing the build, however it seems it is not enough to
 get the sandbox working on Windows 64. After starting the browser the
 `about:page` tab stays blank. When trying to load a web page in a new tab,
 the tab also stays blank. After changing `security.sandbox.content.level`
 from `1` to `0` in `about:config` and restarting, the browser is working
 correctly.
 >
 > To try to debug this I tried setting `security.sandbox.windows.log` and
 `security.sandbox.logging.enabled` to `true`, but didn't see anything
 related to sandbox in the browser console.

 Hm. Maybe I did not fix all the issues in #16010 then? Let me look closer
 at that...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24197 [Applications/Tor Browser]: Building Windows 64 firefox with the sandbox enabled fails

[Tor Bug Tracker & Wiki]

#24197: Building Windows 64 firefox with the sandbox enabled fails
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 Those patches are fixing the build, however it seems it is not enough to
 get the sandbox working on Windows 64. After starting the browser the
 `about:page` tab stays blank. When trying to load a web page in a new tab,
 the tab also stays blank. After changing `security.sandbox.content.level`
 from `1` to `0` in `about:config` and restarting, the browser is working
 correctly.

 To try to debug this I tried setting `security.sandbox.windows.log` and
 `security.sandbox.logging.enabled` to `true`, but didn't see anything
 related to sandbox in the browser console.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24197 [Applications/Tor Browser]: Building Windows 64 firefox with the sandbox enabled fails

[Tor Bug Tracker & Wiki]

#24197: Building Windows 64 firefox with the sandbox enabled fails
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 Replying to [comment:2 gk]:
 > I guess that's one of the usual uppercase/lowercase issues. We have e.g.
 > {{{
 > -#include "sandbox/win/src/wow64.h"
 > +#include "sandbox/win/src/Wow64.h"
 > }}}
 > in our already included sandbox patch in `interception.cc`.

 Thanks. After changing `wow64.h` to `Wow64.h` I was able to finish a
 build.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24197 [Applications/Tor Browser]: Building Windows 64 firefox with the sandbox enabled fails

[Tor Bug Tracker & Wiki]

#24197: Building Windows 64 firefox with the sandbox enabled fails
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by boklm):

 * Attachment "0001-Bug-24197-fix-uppercase-lowercase-issue-in-
 Wow64.h-i.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24197 [Applications/Tor Browser]: Building Windows 64 firefox with the sandbox enabled fails

[Tor Bug Tracker & Wiki]

#24197: Building Windows 64 firefox with the sandbox enabled fails
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 I guess that's one of the usual uppercase/lowercase issues. We have e.g.
 {{{
 -#include "sandbox/win/src/wow64.h"
 +#include "sandbox/win/src/Wow64.h"
 }}}
 in our already included sandbox patch in `interception.cc`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24197 [Applications/Tor Browser]: Building Windows 64 firefox with the sandbox enabled fails

[Tor Bug Tracker & Wiki]

#24197: Building Windows 64 firefox with the sandbox enabled fails
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 It looks like this patch from chromium is fixing the build issue we have
 in `security/sandbox/chromium/base/containers/hash_tables.h`:
 
https://chromium.googlesource.com/chromium/src/+/411d3f7a3a18335713a46d9022ce25e018a19e47%5E%21/

 I attached it as `bug24197.patch` after removing from the patch the
 changes to the files that are not included in firefox.

 However, we now have a different build error:
 {{{
 /var/tmp/dist/mingw-w64/helpers/x86_64-w64-mingw32-g++ -std=gnu++11
 -mwindows -o Wow64_64.o -c   -DNDEBUG=1 -DTRIMMED=1 -DUNICODE -D_UNICODE
 -DNS_NO_XPCOM -D_CRT_RAND_S
 -DCHROMIUM_SANDBOX_BUILD -I/var/tmp/build/firefox-
 dca73c105071/security/sandbox -I/var/tmp/build/firefox-dca73c105071/obj-
 mingw/security/sandbox -I/var/tmp/build/firefox
 -dca73c105071/security/sandbox/chromium-shim -I/var/tmp/build/firefox-
 dca73c105071/security/sandbox/chromium -I/var/tmp/build/firefox-
 dca73c105071/nsprpub -I/var/tmp/bui
 ld/firefox-dca73c105071/obj-mingw/dist/include  -I/var/tmp/build/firefox-
 dca73c105071/obj-mingw/dist/include/nspr -I/var/tmp/build/firefox-
 dca73c105071/obj-mingw/dist/in
 clude/nss -DMOZILLA_CLIENT -include /var/tmp/build/firefox-
 dca73c105071/obj-mingw/mozilla-config.h -MD -MP -MF .deps/Wow64_64.o.pp
 -Wall -Wc++11-compat -Wempty-
 body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-
 compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-
 offsetof -Wc++14-compat -Wno-
 error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error
 =array-bounds -Wno-format -fno-lifetime-dse -fno-exceptions -fno-strict-
 aliasing -mms-bitfields -f
 no-rtti -fno-exceptions -fno-math-errno -pipe  -g -O -fomit-frame-pointer
 /var/tmp/build/firefox-
 dca73c105071/security/sandbox/chromium/sandbox/win/src/Wow64_64.cc
 /var/tmp/build/firefox-
 dca73c105071/security/sandbox/chromium/sandbox/win/src/Wow64_64.cc:7:35:
 fatal error: sandbox/win/src/wow64.h: No such file or directory
 compilation terminated.
 make[5]: *** [Wow64_64.o] Error 1
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24197 [Applications/Tor Browser]: Building Windows 64 firefox with the sandbox enabled fails

[Tor Bug Tracker & Wiki]

#24197: Building Windows 64 firefox with the sandbox enabled fails
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by boklm):

 * Attachment "bug24197.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs