Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Branches merged to tor master and to torspec.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by nickm):

 Replying to [comment:14 teor]:
 > Sure, I think that doing it on a timer is sensible.

 I've opened #30301 for this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:13 nickm]:
 > The code changes and the spec changes look like they do what they're
 supposed to do.  Quick question, though: is this actually an improvement?
 We're making a GETINFO result less accurate. Maybe doing this on a timer
 would be more sensible?  If so I'll merge this, then do another ticket to
 add a timer.

 Sure, I think that doing it on a timer is sensible.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by nickm):

 The code changes and the spec changes look like they do what they're
 supposed to do.  Quick question, though: is this actually an improvement?
 We're making a GETINFO result less accurate. Maybe doing this on a timer
 would be more sensible?  If so I'll merge this, then do another ticket to
 add a timer.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 I think the spec change looks good and as far as I can tell you addressed
 the concerns teor had with the code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 There are two pull requests in this ticket:
 Code: https://github.com/torproject/tor/pull/889
 Spec: https://github.com/torproject/torspec/pull/76

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by teor):

 * milestone:  Tor: unspecified => Tor: 0.4.1.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by neel):

 I have made the changes.

 The torspec PR is here: https://github.com/torproject/torspec/pull/76

 I believe the changes had to be made in control-spec, not dir-spec.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Hi neel, thanks, but I wasn't finished with my review.

 I have numbered the changes that we need to make.

 Replying to [comment:6 ahf]:
 > I think the code looks good, but I'm not marking it as ready for merge
 yet. I've just asked the other network team members about how we should
 review the exceptions file for practracker.

 1. I think we can put most of the new flag-setting code in voteflags.c:
 https://github.com/torproject/tor/pull/889/files#r274725520

 In fact, we might not even need a new callback:

 > I've also asked the current bridge auth administrator how they handle
 this currently.

 I bet it just works for them, and they don't know how it works :-)

 v3 (non-bridge) directory authorities update the Running flag when they
 vote.

 But for bridges, the Running flag gets updated in the getinfo function.

 2. For consistency, let's update the bridge Running flag in
 networkstatus_dump_bridge_status_to_file(), before calling
 networkstatus_getinfo_by_purpose().

 Authorities also update the running flag in list_server_status_v1(),
 another control port function.

 3. For consistency, let's stop updating the Running flag in
 list_server_status_v1(), and just let it be updated when the vote/bridge-
 status is written.

 4. For each function we modify, let's update the function documentation.

 5. Let's also update the dir-spec, to document the old and new behaviour.
 The first version with the new behaviour will be 0.4.1.1-alpha, let's put
 that in the spec.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by neel):

 I noticed that teor gave reviews to my PR. I have pushed the revisions.
 Still needs to pass CI, however.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by ahf):

 I think the code looks good, but I'm not marking it as ready for merge
 yet. I've just asked the other network team members about how we should
 review the exceptions file for practracker. I've also asked the current
 bridge auth administrator how they handle this currently.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * status:  assigned => needs_review


Comment:

 My PR is here: https://github.com/torproject/tor/pull/889

 Setting as needs_review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * owner:  (none) => neel
 * cc: neel (added)
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * cc: isis (added)


Comment:

 What we need to do to fix this bug is to move the call that sets bridges
 running somewhere else, so that this function doesn't have any side
 effects.

 This might mean that we need to make the call happen as a scheduled task,
 because none of the controller GETINFO code should change state.

 Maybe isis will have an opinion on how best to fix this?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, intro, refactor, code- |  Actual Points:
  correctness|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * cc: ffmancera (added)


Comment:

 Replying to ffmancera from #tor-dev:

 No, I am not working on this.
 It's a bug komlo and I discovered at the recent Tor meeting.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs