Re: [tor-bugs] #24726 [Core Tor/Fallback Scripts]: Make sure a comma never appears anywhere in a fallback entry

[Tor Bug Tracker & Wiki]

#24726: Make sure a comma never appears anywhere in a fallback entry
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.3.x-final
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal | Resolution:
 Keywords:  fallback   |  Actual Points:  0.1
Parent ID:  #22271 | Points:  0.1
 Reviewer: |Sponsor:
---+---
Changes (by teor):

 * status:  assigned => needs_review
 * type:  defect => enhancement
 * actualpoints:   => 0.1


Comment:

 This could confuse parsers, so we don't allow it.

 Please see my branch ticket24726.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24726 [Core Tor/Fallback Scripts]: Make sure a comma never appears anywhere in a fallback entry

[Tor Bug Tracker & Wiki]

#24726: Make sure a comma never appears anywhere in a fallback entry
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.3.x-final
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal | Resolution:
 Keywords:  fallback   |  Actual Points:  0.1
Parent ID:  #22271 | Points:  0.1
 Reviewer: |Sponsor:
---+---

Comment (by teor):

 See fallback-format-2-v2, which also removes equals signs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24726 [Core Tor/Fallback Scripts]: Make sure a comma never appears anywhere in a fallback entry

[Tor Bug Tracker & Wiki]

#24726: Make sure a comma never appears anywhere in a fallback entry
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.3.x-final
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal | Resolution:
 Keywords:  fallback, review-group-28  |  Actual Points:  0.1
Parent ID:  #22271 | Points:  0.1
 Reviewer: |Sponsor:
---+---
Changes (by pastly):

 * status:  needs_review => merge_ready


Comment:

 Commas are in fact removed Tested by adding `as,df` to all nicknames and
 verifying output nicknames only had `asdf` added. Also visually checked
 code that all `%s` formatters in the fallback entry code had a call to
 `cleanse_c_string`.

 LGTM, but make sure all `fallback-format-2-v4` are merge_ready.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs