Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

[Tor Bug Tracker & Wiki]

#25429: Need something better than client's `checkForStaleness`
--+
 Reporter:  arlolra   |  Owner:  cohosh
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Circumvention/Snowflake   |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  anti-censorship-roadmap-2020  |  Actual Points:
Parent ID:  #19001| Points:
 Reviewer:|Sponsor:  Sponsor28-must
--+
Changes (by cohosh):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged at [https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/commit/?id=bbf11a97e4728ca41ecb7c34117ec407de4988ec
 bbf11a]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

[Tor Bug Tracker & Wiki]

#25429: Need something better than client's `checkForStaleness`
--+
 Reporter:  arlolra   |  Owner:  cohosh
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Circumvention/Snowflake   |Version:
 Severity:  Normal| Resolution:
 Keywords:  anti-censorship-roadmap-2020  |  Actual Points:
Parent ID:  #19001| Points:
 Reviewer:|Sponsor:  Sponsor28-must
--+
Changes (by dcf):

 * status:  needs_review => merge_ready


Comment:

 Okay with me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

[Tor Bug Tracker & Wiki]

#25429: Need something better than client's `checkForStaleness`
+--
 Reporter:  arlolra |  Owner:  cohosh
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-2020Q1  |  Actual Points:
Parent ID:  #19001  | Points:
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--
Changes (by cohosh):

 * status:  new => needs_review


Comment:

 Alright well, reducing it to 20 seconds might improve quality of life a
 bit. Here's a patch for that and then I think we can call this ticket
 done.

 https://github.com/cohosh/snowflake/pull/29

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

[Tor Bug Tracker & Wiki]

#25429: Need something better than client's `checkForStaleness`
+--
 Reporter:  arlolra |  Owner:  cohosh
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-2020Q1  |  Actual Points:
Parent ID:  #19001  | Points:
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--

Comment (by dcf):

 Replying to [comment:21 cohosh]:
 > Ah nice! Thanks. So I guess all there is to do here is decide whether we
 want to shorten this 30 second timeout to say 15 seconds or leave it. I
 don't think it matters too much.

 Agreed, I don't think it matters too much. My intuition says it's good to
 allow for at least one dropped or delayed keepalive ping before dropping a
 proxy.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

[Tor Bug Tracker & Wiki]

#25429: Need something better than client's `checkForStaleness`
+--
 Reporter:  arlolra |  Owner:  cohosh
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-2020Q1  |  Actual Points:
Parent ID:  #19001  | Points:
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--

Comment (by cohosh):

 Replying to [comment:20 dcf]:
 > Replying to [comment:19 cohosh]:
 > > It looks like there's another value for `KeepAliveTimeout` in the
 [https://github.com/xtaci/smux/blob/v1.5.12/mux.go#L45 defaultConfig] and
 the session will close itself if it hasn't received any data during this
 timeout
 
[https://github.com/xtaci/smux/blob/c6969d8a76874342611f4b544d05b1590f1a76b1/session.go#L393
 here]. This defaults to 30 seconds (which is the same as our current check
 for staleness).
 >
 > We override `KeepAliveTimeout` to 10 minutes
 [https://gitweb.torproject.org/pluggable-
 
transports/snowflake.git/tree/client/lib/snowflake.go?id=7043a055f9fb0680281ecffd7d458a43f2ce65b5#n83
 here (client)] and [https://gitweb.torproject.org/pluggable-
 
transports/snowflake.git/tree/server/server.go?id=7043a055f9fb0680281ecffd7d458a43f2ce65b5#n303
 here (server)]. If 10 minutes expire, it does indeed kill your session and
 close the SOCKS connection, but it takes many proxy failures in a row for
 that to happen.
 Ah nice! Thanks. So I guess all there is to do here is decide whether we
 want to shorten this 30 second timeout to say 15 seconds or leave it. I
 don't think it matters too much.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

[Tor Bug Tracker & Wiki]

#25429: Need something better than client's `checkForStaleness`
+--
 Reporter:  arlolra |  Owner:  cohosh
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-2020Q1  |  Actual Points:
Parent ID:  #19001  | Points:
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--

Comment (by dcf):

 Replying to [comment:19 cohosh]:
 > It looks like there's another value for `KeepAliveTimeout` in the
 [https://github.com/xtaci/smux/blob/v1.5.12/mux.go#L45 defaultConfig] and
 the session will close itself if it hasn't received any data during this
 timeout
 
[https://github.com/xtaci/smux/blob/c6969d8a76874342611f4b544d05b1590f1a76b1/session.go#L393
 here]. This defaults to 30 seconds (which is the same as our current check
 for staleness).

 We override `KeepAliveTimeout` to 10 minutes
 [https://gitweb.torproject.org/pluggable-
 
transports/snowflake.git/tree/client/lib/snowflake.go?id=7043a055f9fb0680281ecffd7d458a43f2ce65b5#n83
 here (client)] and [https://gitweb.torproject.org/pluggable-
 
transports/snowflake.git/tree/server/server.go?id=7043a055f9fb0680281ecffd7d458a43f2ce65b5#n303
 here (server)]. If 10 minutes expire, it does indeed kill your session and
 close the SOCKS connection, but it takes many proxy failures in a row for
 that to happen.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

[Tor Bug Tracker & Wiki]

#25429: Need something better than client's `checkForStaleness`
+--
 Reporter:  arlolra |  Owner:  cohosh
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-2020Q1  |  Actual Points:
Parent ID:  #19001  | Points:
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--

Comment (by cohosh):

 Replying to [comment:18 dcf]:
 > Replying to [ticket:25429 arlolra]:
 > > but there's no heartbeat at this level of abstraction so the
 connection is constantly being reset anytime the user pauses their
 activity (for example, to read a webpage).
 >
 > This statement is no longer true since #33745; smux sends a heartbeat
 every 10 seconds in both directions (inherited from
 [https://github.com/xtaci/smux/blob/v1.5.12/mux.go#L40 smux.DefaultConfig]
 [https://gitweb.torproject.org/pluggable-
 
transports/snowflake.git/tree/client/lib/snowflake.go?id=7043a055f9fb0680281ecffd7d458a43f2ce65b5#n81
 here] and [https://gitweb.torproject.org/pluggable-
 
transports/snowflake.git/tree/server/server.go?id=7043a055f9fb0680281ecffd7d458a43f2ce65b5#n300
 here]).
 >
 > The problem is also mitigated by #34042, which uses a different
 (shorter) timeout to discard a non-working proxy originally. It still
 takes 30 seconds via `checkForStaleness` to give up on a proxy that was
 once working.

 Cool.

 It looks like there's another value for `KeepAliveTimeout` in the
 [https://github.com/xtaci/smux/blob/v1.5.12/mux.go#L45 defaultConfig] and
 the session will close itself if it hasn't received any data during this
 timeout
 
[https://github.com/xtaci/smux/blob/c6969d8a76874342611f4b544d05b1590f1a76b1/session.go#L393
 here]. This defaults to 30 seconds (which is the same as our current check
 for staleness).

 Although if the session closes, it should cause the main copy loop to
 break [https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/tree/client/lib/snowflake.go#n161 here]. It seems
 like we don't want this to happen if our snowflake stops working, and
 instead we want to try to get new snowflakes before our session fails.

 So now that we have keep-alive pings, we should be able to shorten this
 staleness check. Does it make sense to shorten the pings to every 5s and
 make the staleness check 10s? This would allow for 2 additional snowflake
 tries before our session breaks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

[Tor Bug Tracker & Wiki]

#25429: Need something better than client's `checkForStaleness`
+--
 Reporter:  arlolra |  Owner:  cohosh
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-2020Q1  |  Actual Points:
Parent ID:  #19001  | Points:
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--

Comment (by dcf):

 Replying to [ticket:25429 arlolra]:
 > but there's no heartbeat at this level of abstraction so the connection
 is constantly being reset anytime the user pauses their activity (for
 example, to read a webpage).

 This statement is no longer true since #33745; smux sends a heartbeat
 every 10 seconds in both directions (inherited from
 [https://github.com/xtaci/smux/blob/v1.5.12/mux.go#L40 smux.DefaultConfig]
 [https://gitweb.torproject.org/pluggable-
 
transports/snowflake.git/tree/client/lib/snowflake.go?id=7043a055f9fb0680281ecffd7d458a43f2ce65b5#n81
 here] and [https://gitweb.torproject.org/pluggable-
 
transports/snowflake.git/tree/server/server.go?id=7043a055f9fb0680281ecffd7d458a43f2ce65b5#n300
 here]).

 The problem is also mitigated by #34042, which uses a different (shorter)
 timeout to discard a non-working proxy originally. It still takes 30
 seconds via `checkForStaleness` to give up on a proxy that was once
 working.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

[Tor Bug Tracker & Wiki]

#25429: Need something better than client's `checkForStaleness`
+--
 Reporter:  arlolra |  Owner:  cohosh
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-2020Q1  |  Actual Points:
Parent ID:  #19001  | Points:
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--
Changes (by cohosh):

 * parent:  #29206 => #19001


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

[Tor Bug Tracker & Wiki]

#25429: Need something better than client's `checkForStaleness`
+--
 Reporter:  arlolra |  Owner:  cohosh
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-2020Q1  |  Actual Points:
Parent ID:  #29206  | Points:
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--
Changes (by cohosh):

 * status:  assigned => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

[Tor Bug Tracker & Wiki]

#25429: Need something better than client's `checkForStaleness`
+--
 Reporter:  arlolra |  Owner:  cohosh
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-2020Q1  |  Actual Points:
Parent ID:  #29206  | Points:
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--
Changes (by gaba):

 * keywords:  anti-censorship-roadmap-september => anti-censorship-roadmap-
 2020Q1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

[Tor Bug Tracker & Wiki]

#25429: Need something better than client's `checkForStaleness`
---+---
 Reporter:  arlolra|  Owner:  cohosh
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID:  #29206 | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by gaba):

 * parent:   => #29206


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

[Tor Bug Tracker & Wiki]

#25429: Need something better than client's `checkForStaleness`
---+---
 Reporter:  arlolra|  Owner:  cohosh
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by gaba):

 * keywords:  ex-sponsor-19, anti-censorship-roadmap => anti-censorship-
 roadmap-september
 * sponsor:  Sponsor28-can => Sponsor28-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

[Tor Bug Tracker & Wiki]

#25429: Need something better than client's `checkForStaleness`
-+-
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ex-sponsor-19, anti-censorship-  |  Actual Points:
  roadmap|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-can
-+-
Changes (by gaba):

 * keywords:  ex-sponsor-19 => ex-sponsor-19, anti-censorship-roadmap


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

[Tor Bug Tracker & Wiki]

#25429: Need something better than client's `checkForStaleness`
-+---
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  Sponsor19
-+---

Comment (by cohosh):

 I'm going to move the discussion of the sequencing and reliability layer
 over to #29206.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs