Re: [tor-bugs] #25860 [Applications/Tor Browser]: Clean up OpenSSL's configure options for Windows

[Tor Bug Tracker & Wiki]

#25860: Clean up OpenSSL's configure options for Windows
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201806R,  |  Actual Points:
  boklm201806|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good. Merged to `master` as commit
 ba7b30a920172233392fd9dc176631c3da25d5f0.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25860 [Applications/Tor Browser]: Clean up OpenSSL's configure options for Windows

[Tor Bug Tracker & Wiki]

#25860: Clean up OpenSSL's configure options for Windows
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806R,  |  Actual Points:
  boklm201806|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, TorBrowserTeam201806, boklm201806 => tbb-rbm,
 TorBrowserTeam201806R, boklm201806
 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:8 gk]:
 > Looks mostly good. I think you have a typo in your commit message:
 "Avoid duplicating Windows CFLAGS and CFLAGS". The second "CFLAGS" was
 probably meant to be "LDFLAGS"?

 Yes, I fixed that in branch `bug_25860_v5`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25860_v5&id=ba7b30a920172233392fd9dc176631c3da25d5f0

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25860 [Applications/Tor Browser]: Clean up OpenSSL's configure options for Windows

[Tor Bug Tracker & Wiki]

#25860: Clean up OpenSSL's configure options for Windows
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201806   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, boklm201805, TorBrowserTeam201806R => tbb-rbm,
 boklm201805, TorBrowserTeam201806
 * status:  needs_review => needs_revision


Comment:

 Looks mostly good. I think you have a typo in your commit message: "Avoid
 duplicating Windows CFLAGS and CFLAGS". The second "CFLAGS" was probably
 meant to be "LDFLAGS"?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25860 [Applications/Tor Browser]: Clean up OpenSSL's configure options for Windows

[Tor Bug Tracker & Wiki]

#25860: Clean up OpenSSL's configure options for Windows
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 The branch `bug_25860_v4` has the patch rebased on master:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25860_v4&id=f60070a29e8c3b7307fb30218b2fa454190f9b5e

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25860 [Applications/Tor Browser]: Clean up OpenSSL's configure options for Windows

[Tor Bug Tracker & Wiki]

#25860: Clean up OpenSSL's configure options for Windows
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 The branch `bug_25860_v2` is based on `bug_16472_v15` so it will need to
 be cherry-picked if #16472 needs revision.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25860 [Applications/Tor Browser]: Clean up OpenSSL's configure options for Windows

[Tor Bug Tracker & Wiki]

#25860: Clean up OpenSSL's configure options for Windows
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, boklm201805, TorBrowserTeam201805 => tbb-rbm,
 boklm201805, TorBrowserTeam201805R
 * status:  new => needs_review


Comment:

 There is a patch for review in branch `bug_25860_v2`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25860_v2&id=3ae603d4cac4466a0c74f46bc26cc83239872004

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25860 [Applications/Tor Browser]: Clean up OpenSSL's configure options for Windows

[Tor Bug Tracker & Wiki]

#25860: Clean up OpenSSL's configure options for Windows
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm => tbb-rbm, boklm201805, TorBrowserTeam201805


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25860 [Applications/Tor Browser]: Clean up OpenSSL's configure options for Windows

[Tor Bug Tracker & Wiki]

#25860: Clean up OpenSSL's configure options for Windows
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 Yes, I think using the `CFLAGS` and `LDFLAGS` from `rbm.conf` makes sense.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25860 [Applications/Tor Browser]: Clean up OpenSSL's configure options for Windows

[Tor Bug Tracker & Wiki]

#25860: Clean up OpenSSL's configure options for Windows
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * type:  defect => enhancement


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs