Re: [tor-bugs] #25894 [Applications/Tor Browser]: Get a rust cross-compiler for Windows

[Tor Bug Tracker & Wiki]

#25894: Get a rust cross-compiler for Windows
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, ff60-esr, boklm201805,  |  Actual Points:
  TorBrowserTeam201806R  |
Parent ID:  #25849   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 This looks good. I pushed this patch to master as commit
 `4d5e3d2ba5422b931a2e32a9498feabec6ecc23e`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25894 [Applications/Tor Browser]: Get a rust cross-compiler for Windows

[Tor Bug Tracker & Wiki]

#25894: Get a rust cross-compiler for Windows
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201805R, boklm201805 |
Parent ID:  #25849   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 This patch looks good to me. I rebased it on master and #25832, fixing the
 conflicts with the macOS patch:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25894_v2&id=4d5e3d2ba5422b931a2e32a9498feabec6ecc23e

 And I am now trying a build of rust with this branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25894 [Applications/Tor Browser]: Get a rust cross-compiler for Windows

[Tor Bug Tracker & Wiki]

#25894: Get a rust cross-compiler for Windows
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr, boklm201804,  |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #25849   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 `bug_25894_v2` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_25894_v2&id=ca6caf8da23588aeef0602cf3ab07289b20bdcaa)
 fixes some typos, please use that one for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25894 [Applications/Tor Browser]: Get a rust cross-compiler for Windows

[Tor Bug Tracker & Wiki]

#25894: Get a rust cross-compiler for Windows
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr, boklm201804,  |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #25849   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  new => needs_review
 * keywords:  tbb-rbm, ff60-esr, boklm201804, TorBrowserTeam201804 => tbb-
 rbm, ff60-esr, boklm201804, TorBrowserTeam201804R
 * priority:  Medium => High


Comment:

 Okay, a patch for review is up at `bug_25894`
 (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_25894&id=5d6c53155f6fc8d49185dde166ac0471ba2347ae)
 in my public tor-browser-build repo. It needs #25862 and #25832 fixed
 before, though (which we want to have anyway for switching to ESR 60 I
 think).

 The 32bit cross-compilation has been a huge pain in the butt because it is
 essentially broken right now. For details, see: https://github.com/rust-
 lang/rust/issues/12859. Thanks to the help of Alex Crichton and Manish
 Goregaokar I was able to come up with a minimal patch that works around
 that problem.

 I verified that the resulting x86_64 Rust toolchain is able to compile the
 necessary Rust bits shipped in ESR 60.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs