Re: [tor-bugs] #27157 [Webpages/Website]: Update Tor FAQ - Tor has directory guards

[Tor Bug Tracker & Wiki]

#27157: Update Tor FAQ - Tor has directory guards
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  easy doc, FAQ |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by traumschule):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27157 [Webpages/Website]: Update Tor FAQ - Tor has directory guards

[Tor Bug Tracker & Wiki]

#27157: Update Tor FAQ - Tor has directory guards
--+-
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy doc, FAQ |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by traumschule):

 * reviewer:  hiro =>


Comment:

 Thanks for the very helpful feedback, abandoning my WIP approach for this
 one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27157 [Webpages/Website]: Update Tor FAQ - Tor has directory guards

[Tor Bug Tracker & Wiki]

#27157: Update Tor FAQ - Tor has directory guards
--+-
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy doc, FAQ |  Actual Points:
Parent ID:| Points:
 Reviewer:  hiro  |Sponsor:
--+-

Comment (by irl):

 traumschule: I can't speak for hiro but I know that I prefer to review
 small changes. If you pile up a whole load of commits in one PR then I
 would probably ignore it until it's too old to consider rebasing it and
 then it would never be merged. Small PRs are easy to review and improve
 your chances that it is merged.

 There are also quite a few people (I count 13 people) that can review and
 merge website changes, not just hiro. By setting the reviewer you will
 cause others that might have looked at your changes to ignore them until
 hiro is able to look at them. The reviewer field should really only be set
 by the person that is taking the review, or if you've already discussed
 with them the specific ticket.

 If all the changes you're making are in the same file (like the FAQ) then
 you could put all these together in the same PR especially if they are
 each only small changes in that file. As soon as you start touching
 unrelated things this should always be in a separate branch. Even so, I
 could see that your first change could already be merged while you're
 still working on other changes. There is no reason to artificially cause
 delays here.

 FWIW,
 
[[https://github.com/torproject/webwml/pull/13/commits/e2e7bc662a5c6e584a3b379964156aac8f4fad25|commit
 e2e7bc6]] looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27157 [Webpages/Website]: Update Tor FAQ - Tor has directory guards

[Tor Bug Tracker & Wiki]

#27157: Update Tor FAQ - Tor has directory guards
--+-
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy doc, FAQ |  Actual Points:
Parent ID:| Points:
 Reviewer:  hiro  |Sponsor:
--+-
Changes (by traumschule):

 * reviewer:   => hiro


Comment:

 I need to explain myself better. I titled the current pull request as work
 in progress with the intention to collect more commits, each fixing
 another issue referenced with '(fixes #bugnumber)'.
 Instead I could open a new PR for each ticket, but then it's more work to
 review them in git I guess. Will wait to see what hiro thinks when she is
 back.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27157 [Webpages/Website]: Update Tor FAQ - Tor has directory guards

[Tor Bug Tracker & Wiki]

#27157: Update Tor FAQ - Tor has directory guards
--+-
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy doc, FAQ |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by teor):

 New tickets are cheap, and small changes are easy to review and merge.

 So I recommend you open new tickets for each new topic (or new reviewer).
 And make a new commit for every change to a different section.

 You should also ask hiro or whoever merges your work what they prefer.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27157 [Webpages/Website]: Update Tor FAQ - Tor has directory guards

[Tor Bug Tracker & Wiki]

#27157: Update Tor FAQ - Tor has directory guards
--+-
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy doc, FAQ |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by traumschule):

 Thanks for reviewing this patch. Do you prefer to get this merged fast or
 shall I collect more FAQ related commits in the PR?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27157 [Webpages/Website]: Update Tor FAQ - Tor has directory guards

[Tor Bug Tracker & Wiki]

#27157: Update Tor FAQ - Tor has directory guards
--+-
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy doc, FAQ |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Thanks, looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27157 [Webpages/Website]: Update Tor FAQ - Tor has directory guards

[Tor Bug Tracker & Wiki]

#27157: Update Tor FAQ - Tor has directory guards
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy doc, FAQ |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by traumschule):

 * status:  new => needs_review
 * keywords:  easy doc => easy doc, FAQ


Comment:

 https://github.com/torproject/webwml/pull/13

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs