Re: [tor-bugs] #27163 [Metrics]: Regular expression for valid AS numbers doesn't allow for AS 0

[Tor Bug Tracker & Wiki]

#27163: Regular expression for valid AS numbers doesn't allow for AS 0
-+
 Reporter:  nusenu   |  Owner:  irl
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  karsten  |Sponsor:
-+
Changes (by karsten):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good! Merged. Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27163 [Metrics]: Regular expression for valid AS numbers doesn't allow for AS 0

[Tor Bug Tracker & Wiki]

#27163: Regular expression for valid AS numbers doesn't allow for AS 0
-+--
 Reporter:  nusenu   |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  karsten  |Sponsor:
-+--
Changes (by karsten):

 * reviewer:   => karsten


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27163 [Metrics]: Regular expression for valid AS numbers doesn't allow for AS 0

[Tor Bug Tracker & Wiki]

#27163: Regular expression for valid AS numbers doesn't allow for AS 0
-+--
 Reporter:  nusenu   |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * status:  accepted => needs_review


Comment:

 Please review
 
[[https://gitweb.torproject.org/user/irl/onionoo.git/commit/?h=task/27163=405faa26c694f0d3c323357f0b3d501a3edd0b7d|commit
 405faa2 in my task/27163 branch]].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27163 [Metrics]: Regular expression for valid AS numbers doesn't allow for AS 0

[Tor Bug Tracker & Wiki]

#27163: Regular expression for valid AS numbers doesn't allow for AS 0
-+--
 Reporter:  nusenu   |  Owner:  irl
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by irl):

 I think probably we would have to do this tomorrow. I would like to have
 the time to write some extra test cases and also think about other fields
 that could do with more test cases.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27163 [Metrics]: Regular expression for valid AS numbers doesn't allow for AS 0

[Tor Bug Tracker & Wiki]

#27163: Regular expression for valid AS numbers doesn't allow for AS 0
-+--
 Reporter:  nusenu   |  Owner:  irl
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Oops. Should we put out a 6.2-1.17.1 with a fix and deploy that today or
 tomorrow?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27163 [Metrics]: Regular expression for valid AS numbers doesn't allow for AS 0

[Tor Bug Tracker & Wiki]

#27163: Regular expression for valid AS numbers doesn't allow for AS 0
-+--
 Reporter:  nusenu   |  Owner:  irl
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * status:  new => accepted
 * owner:  metrics-team => irl


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27163 [Metrics]: Regular expression for valid AS numbers doesn't allow for AS 0 (was: search/as:AS0 --> HTTP 400)

[Tor Bug Tracker & Wiki]

#27163: Regular expression for valid AS numbers doesn't allow for AS 0
-+--
 Reporter:  nusenu   |  Owner:  metrics-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by irl):

 Broken when we added support for lists of AS numbers in #23713.

 {{{
 private static Pattern asNumberParameterPattern =
   Pattern.compile("((^|,)([aA][sS])?[1-9][0-9]{0,9})+$");
 }}}

 Should have been parse as a long and check it's 0 <= x <= 4294967295.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs