Re: [tor-bugs] #27178 [Applications/Tor Browser]: Generating of incremental MAR files fails due to new compression format

[Tor Bug Tracker & Wiki]

#27178: Generating of incremental MAR files fails due to new compression format
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201808R  |  Actual Points:
Parent ID:  #26050  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by boklm):

 I filled #27182 and #27183 for the 8.0.1 and 8.0.2 updates.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27178 [Applications/Tor Browser]: Generating of incremental MAR files fails due to new compression format

[Tor Bug Tracker & Wiki]

#27178: Generating of incremental MAR files fails due to new compression format
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201808R  |  Actual Points:
Parent ID:  #26050  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed
 * parent:   => #26050


Comment:

 Works for me. Applied to `master` (commit
 93acbf12b01c83facfb6fb023ceff10d9f601b98). We should file follow-up bugs
 to adapt this patch during the whole watershed thing (and mark those bugs
 as child bugs for #26050). I'll file the one for 8.0a10->8.0a11 (or
 8.0a10-8.5a1 if 8.0a10 will be the last alpha) incremental creation.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27178 [Applications/Tor Browser]: Generating of incremental MAR files fails due to new compression format

[Tor Bug Tracker & Wiki]

#27178: Generating of incremental MAR files fails due to new compression format
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201808R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by boklm):

 Replying to [comment:1 boklm]:
 >
 > We are not checking that xz is used in the generated incrementals as
 this would require extracting them again after they are created. But we
 are using the `mar-tools` from the new version, and `MAR_OLD_FORMAT` is
 not set, so I think it should get used.

 After manually extracting one of the generated incremental, I see that the
 files are indeed compressed with xz.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27178 [Applications/Tor Browser]: Generating of incremental MAR files fails due to new compression format

[Tor Bug Tracker & Wiki]

#27178: Generating of incremental MAR files fails due to new compression format
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201808R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by boklm):

 * keywords:  tbb-rbm, TorBrowserTeam201808 => tbb-rbm,
   TorBrowserTeam201808R
 * status:  new => needs_review


Comment:

 There is a patch for review in branch `bug_27178`, adding an option to
 select the format:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_27178=93acbf12b01c83facfb6fb023ceff10d9f601b98

 We are not checking that xz is used in the generated incrementals as this
 would require extracting them again after they are created. But we are
 using the `mar-tools` from the new version, and `MAR_OLD_FORMAT` is not
 set, so I think it should get used.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs