Re: [tor-bugs] #27241 [Core Tor/Tor]: Extract information from more kinds of wedged directory connections.

[Tor Bug Tracker & Wiki]

#27241: Extract information from more kinds of wedged directory connections.
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, 035-deferred-20180930, |  Actual Points:
  040-deferred-201915|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mikeperry):

 * status:  needs_information => needs_revision


Comment:

 Also setting this as needs_revision, because my questions were answered,
 except for the handing edge conn one, which I am pretty sure remains an
 actual problem.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27241 [Core Tor/Tor]: Extract information from more kinds of wedged directory connections.

[Tor Bug Tracker & Wiki]

#27241: Extract information from more kinds of wedged directory connections.
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, 035-deferred-20180930, |  Actual Points:
  040-deferred-201915|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mikeperry):

 FTR - this ticket could be merged, but if so I think we should file a new
 ticket to add some logic to always close underlying edge connections if
 their dir connections are closed first. We maybe should do that anyway, as
 that may be one of the things causing #8387.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27241 [Core Tor/Tor]: Extract information from more kinds of wedged directory connections.

[Tor Bug Tracker & Wiki]

#27241: Extract information from more kinds of wedged directory connections.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, 035-deferred-20180930  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  mikeperry|Sponsor:
-+-
Changes (by gaba):

 * sponsor:  Sponsor8-can =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27241 [Core Tor/Tor]: Extract information from more kinds of wedged directory connections.

[Tor Bug Tracker & Wiki]

#27241: Extract information from more kinds of wedged directory connections.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  mikeperry |Sponsor:  Sponsor8-can
--+

Comment (by nickm):

 Are the issues here reasons to not merge the original patch?  Does this
 still belong in needs_information?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27241 [Core Tor/Tor]: Extract information from more kinds of wedged directory connections.

[Tor Bug Tracker & Wiki]

#27241: Extract information from more kinds of wedged directory connections.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  mikeperry |Sponsor:  Sponsor8-can
--+

Comment (by mikeperry):

 Ok I strongly suspect that #8387 is being caused by us not properly
 closing edge conns for dirconns underneath. We can use that bug for the
 dirconn/edgeconn piece, I guess.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27241 [Core Tor/Tor]: Extract information from more kinds of wedged directory connections.

[Tor Bug Tracker & Wiki]

#27241: Extract information from more kinds of wedged directory connections.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  mikeperry |Sponsor:  Sponsor8-can
--+

Comment (by mikeperry):

 Replying to [comment:6 nickm]:
 > Replying to [comment:5 mikeperry]:
 > > To help me understand the consequences of this (and to figure out if I
 need to also do anything here for #25573), I have the following questions:
 > >
 > > 3. When the dirconn is closed first (such as here or elsewhere in the
 code), where in the code do we decide to mark/clean up/close the
 corresponding linked edge conn? I could not find this..
 >
 > Hmm. I wonder if nothing closes it, actually. Can you think of some
 experiment we could do to find out?

 I am not sure. Do we have a way to trigger this bug?

 > > For #25573, I'm particularly concerned about multihop hsdir dirconns.
 But if we ever make regular directory activity multihop, this could apply
 there too. Plus the linked conn close conditions may be relevant to this
 bug?

 I've been digging and I still cannot find anything that closes the edge
 conn when it times out. This is fine for #25573, since it only deals with
 edge conns, but if we change that, we'll want to update #23373.

 For purposes of this bug, I think the only question that remains is if
 we've exposed  handle_response_fetch_microdesc() and
 router_load_extrainfo_from_string() to partial descriptors before.

 I think the dirconn closing issue can be an orthogonal bug.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27241 [Core Tor/Tor]: Extract information from more kinds of wedged directory connections.

[Tor Bug Tracker & Wiki]

#27241: Extract information from more kinds of wedged directory connections.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  mikeperry |Sponsor:  Sponsor8-can
--+

Comment (by teor):

 Replying to [comment:5 mikeperry]:
 > ...
 > For #25573, I'm particularly concerned about multihop hsdir dirconns.
 But if we ever make regular directory activity multihop, this could apply
 there too. Plus the linked conn close conditions may be relevant to this
 bug?

 In some cases, bridge clients fetch authority certificates over multihop
 connections:
 
https://github.com/torproject/tor/blob/94605f08fb89ea79409225362d2fa0f8a07435d7/src/feature/nodelist/routerlist.c#L952

 And do most other actions over multihop connections:
 
https://github.com/torproject/tor/blob/48632455a5bd679d5f97c5137f24f91e564abad6/src/feature/dircache/directory.c#L185

 And bridge relays upload descriptors over multihop connections:
 
https://github.com/torproject/tor/blob/48632455a5bd679d5f97c5137f24f91e564abad6/src/feature/dircache/directory.c#L379

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27241 [Core Tor/Tor]: Extract information from more kinds of wedged directory connections.

[Tor Bug Tracker & Wiki]

#27241: Extract information from more kinds of wedged directory connections.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  mikeperry |Sponsor:  Sponsor8-can
--+

Comment (by nickm):

 Replying to [comment:5 mikeperry]:
 > To help me understand the consequences of this (and to figure out if I
 need to also do anything here for #25573), I have the following questions:
 >
 > 1. How do stalled dirconns translate to their linked edge_connection_ts?
 Can the edge connection "stall" first and/or get closed somewhere else, or
 will the dirconn always be the thing that stalls?

 I don't think we have any logic for an edge_connection_t to time out; in
 princple you can keep an ssh connection running over Tor indefinitely.
 Directory connections, however, do time out.


 > 2. What are the consequences to the dir conn if some other code marks
 the edge connnection is closed first?

 When one of a pair of linked connections is finally closed from
 connection_unlink in main.c, the other connection gets unlinked from it,
 and told to read all of its data from its input.

 So if something else closes the edge connection, the dir connection will
 get one last chance to handle any data queued on it before it is closed.

 > 3. When the dirconn is closed first (such as here or elsewhere in the
 code), where in the code do we decide to mark/clean up/close the
 corresponding linked edge conn? I could not find this..

 Hmm. I wonder if nothing closes it, actually. Can you think of some
 experiment we could do to find out?

 > For #25573, I'm particularly concerned about multihop hsdir dirconns.
 But if we ever make regular directory activity multihop, this could apply
 there too. Plus the linked conn close conditions may be relevant to this
 bug?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27241 [Core Tor/Tor]: Extract information from more kinds of wedged directory connections.

[Tor Bug Tracker & Wiki]

#27241: Extract information from more kinds of wedged directory connections.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  mikeperry |Sponsor:  Sponsor8-can
--+

Comment (by mikeperry):

 To help me understand the consequences of this (and to figure out if I
 need to also do anything here for #25573), I have the following questions:

 1. How do stalled dirconns translate to their linked edge_connection_ts?
 Can the edge connection "stall" first and/or get closed somewhere else, or
 will the dirconn always be the thing that stalls?
 2. What are the consequences to the dir conn if some other code marks the
 edge connnection is closed first?
 3. When the dirconn is closed first (such as here or elsewhere in the
 code), where in the code do we decide to mark/clean up/close the
 corresponding linked edge conn? I could not find this..

 For #25573, I'm particularly concerned about multihop hsdir dirconns. But
 if we ever make regular directory activity multihop, this could apply
 there too. Plus the linked conn close conditions may be relevant to this
 bug?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27241 [Core Tor/Tor]: Extract information from more kinds of wedged directory connections.

[Tor Bug Tracker & Wiki]

#27241: Extract information from more kinds of wedged directory connections.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  mikeperry |Sponsor:  Sponsor8-can
--+
Changes (by mikeperry):

 * status:  needs_review => needs_information


Comment:

 I'm wondering if we test various kinds of partial descriptor parsing for
 microdescs and extrainfo.

 Particularly handle_response_fetch_microdesc() and
 router_load_extrainfo_from_string().

 Have these functions been exposed to partial downloads and various kinds
 of fragmented descriptors before?

 If not, we should test them for that first. If so, then this is fine by
 me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27241 [Core Tor/Tor]: Extract information from more kinds of wedged directory connections.

[Tor Bug Tracker & Wiki]

#27241: Extract information from more kinds of wedged directory connections.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  mikeperry |Sponsor:  Sponsor8-can
--+
Changes (by dgoulet):

 * reviewer:   => mikeperry


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27241 [Core Tor/Tor]: Extract information from more kinds of wedged directory connections.

[Tor Bug Tracker & Wiki]

#27241: Extract information from more kinds of wedged directory connections.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor8-can
--+
Changes (by nickm):

 * status:  accepted => needs_review
 * sponsor:   => Sponsor8-can


Comment:

 See branch `feature_27241`, PR at
 https://github.com/torproject/tor/pull/286

 (Calling this sponsor8 since it should help save BW)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27241 [Core Tor/Tor]: Extract information from more kinds of wedged directory connections.

[Tor Bug Tracker & Wiki]

#27241: Extract information from more kinds of wedged directory connections.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * owner:  (none) => nickm
 * status:  assigned => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs