Re: [tor-bugs] #27461 [Core Tor/Tor]: Windows: cast between incompatible function types in main

[Tor Bug Tracker & Wiki]

#27461: Windows: cast between incompatible function types in main
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.23-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  035-must, 034-must, 034-backport,|  Actual Points:
  033-backport, 032-backport, 029-backport   |
Parent ID:  #27389   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 I think you meant bug27461-029 and bug27461-032 -- I merged those.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27461 [Core Tor/Tor]: Windows: cast between incompatible function types in main

[Tor Bug Tracker & Wiki]

#27461: Windows: cast between incompatible function types in main
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.23-alpha
 Severity:  Normal   | Resolution:
 Keywords:  035-must, 034-must, 034-backport,|  Actual Points:
  033-backport, 032-backport, 029-backport   |
Parent ID:  #27389   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => needs_review
 * keywords:  035-must, 034-must, 034-backport =>
 035-must, 034-must, 034-backport, 033-backport, 032-backport,
 029-backport
 * version:  Tor: 0.3.4.1-alpha => Tor: 0.2.2.23-alpha


Comment:

 Please see my branches bug27463-029 and bug27463-032 on
 ​https://github.com/teor2345/tor.git

 The 032 branch fixes a minor merge conflict due to an #endif comment.

 The CI is here, but it will fail Appveyor until all the children of #27389
 are merged:
 * 0.3.4:
   * https://ci.appveyor.com/project/teor2345/tor/build/1.0.160
   * https://travis-ci.org/teor2345/tor/builds/425552509
 * 0.3.2:
   * https://travis-ci.org/teor2345/tor/builds/425552403
 * 0.2.9:
   * https://travis-ci.org/teor2345/tor/builds/425552011

 The passing CI for all the #27389 fixes on 0.3.4 is here:
 * https://ci.appveyor.com/project/teor2345/tor/build/1.0.156
 * ​https://travis-ci.org/teor2345/tor/builds/425096670

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27461 [Core Tor/Tor]: Windows: cast between incompatible function types in main

[Tor Bug Tracker & Wiki]

#27461: Windows: cast between incompatible function types in main
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.4.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  035-must, 034-must, 034-backport  |  Actual Points:
Parent ID:  #27389| Points:
 Reviewer:|Sponsor:
--+

Comment (by teor):

 Replying to [comment:3 nickm]:
 > We talked about this in #tor-dev -- casting FARPROC through 'void (*)()'
 is probably the answer.

 In this specific case, I think we can stop calling the function on 64-bit
 Windows, because it will never work there.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27461 [Core Tor/Tor]: Windows: cast between incompatible function types in main

[Tor Bug Tracker & Wiki]

#27461: Windows: cast between incompatible function types in main
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.4.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  035-must, 034-must, 034-backport  |  Actual Points:
Parent ID:  #27389| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 We talked about this in #tor-dev -- casting FARPROC through 'void (*)()'
 is probably the answer.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27461 [Core Tor/Tor]: Windows: cast between incompatible function types in main (was: Appveyor: cast between incompatible function types in main)

[Tor Bug Tracker & Wiki]

#27461: Windows: cast between incompatible function types in main
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.4.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  035-must, 034-must, 034-backport  |  Actual Points:
Parent ID:  #27389| Points:
 Reviewer:|Sponsor:
--+

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs