Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:  0.5
 Reviewer:  sysrqb, boklm|Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:20 sisbell]:
 > Removed the white space at beginning of lines and removed libtinfo
 dependency since this is now included in rbm.conf
 >
 > https://github.com/sisbell/tor-browser-build/commits/bug-28764

 This looks good to me. I cherry-picked the patch to master as commit
 `b380d694e605e46500e411c792602e08cdbb6fb2`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:  0.5
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:  0.5
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by sisbell):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202002R => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202003R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002R  |
Parent ID:  #28704   | Points:  0.5
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202002 => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202002R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:  0.5
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by sisbell):

 * status:  needs_revision => needs_review


Comment:

 Removed the white space at beginning of lines and removed libtinfo
 dependency since this is now included in rbm.conf

 https://github.com/sisbell/tor-browser-build/commits/bug-28764

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:  0.5
 Reviewer:  sysrqb, boklm|Sponsor:
-+-

Comment (by sysrqb):

 This is based on commit b06af71cf1aed690da281e4eb2f89294d48dcb15 from
 ticket:28704#comment:23.

 {{{
 -make
 -make DESTDIR="$distdir" install
 + make
 + make DESTDIR="$distdir" install
 }}}
 nit: Please delete the new space introduced at the beginning of the line.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202001   |
Parent ID:  #28704   | Points:  0.5
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202001R => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202001
 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201912R, tbb-parity  |
Parent ID:  #28704   | Points:  0.5
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by sysrqb):

 * reviewer:   => sysrqb, boklm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201912R, tbb-parity  |
Parent ID:  #28704   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by sisbell):

 * status:  assigned => needs_review
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam201912, tbb-parity => tbb-
 mobile, tbb-rbm, TorBrowserTeam201912R, tbb-parity


Comment:

 I verified it builds on all 4 targets. I have not verified
 reproducibility.

 https://github.com/sisbell/tor-browser-
 build/commit/a4d6fdcdee0217197216b3d82705d91f0ebc6190

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201912, tbb-parity   |
Parent ID:  #28704   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Useful reference for this issue

 https://github.com/openssl/openssl/blob/master/NOTES.ANDROID

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201912, tbb-parity   |
Parent ID:  #28704   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * cc: tbb-team (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201912, tbb-parity   |
Parent ID:  #28704   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * owner:  tbb-team => sisbell
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam201812, tbb-parity => tbb-
 mobile, tbb-rbm, TorBrowserTeam201912, tbb-parity
 * status:  needs_revision => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, tbb-parity   |
Parent ID:  #28704   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by eighthave):

 FYI, I tried building with enable-ec_nistp_64_gcc_128 using Android NDK
 r20, which only has ''clang'' and it failed.  It seems that ''clang''
 lacks some feature needed to build with enable-ec_nistp_64_gcc_128.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, tbb-parity   |
Parent ID:  #28704   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Of course the same issues are still a problem, but just including the
 commit for reference.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, tbb-parity   |
Parent ID:  #28704   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 This is a really old commit from Dec 7th (branch 1219) so I'll need to
 update and test with what we have now but the following was working at the
 time.

 https://github.com/sisbell/tor-browser-
 build/commit/c00bf3abba168b3462b2f93ed95e2ad1b530ec87

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, tbb-parity   |
Parent ID:  #28704   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * points:   => 0.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, tbb-parity   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Recheck `enable-ec_nistp_64_gcc_128`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, tbb-parity   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 https://wiki.openssl.org/index.php/Android

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam201812R => tbb-mobile, tbb-
 rbm, TorBrowserTeam201812


Comment:

 Three things we should think about here:

 1) The OpenSSL output is not build reproducibly. The .a creation is not
 deterministic as it seems to contain timestamps, see:
 {{{
 0007ce70:      6001  0b00  ..`.
  0007ce80:      0100    
  0007ce90:  7373 6c5f 7574 7374 2e6f 2f20 2020  ..ssl_utst.o/
 -0007cea0: 2020 3135 3434 3532 3132 3032 2020 31301544521202  10
 +0007cea0: 2020 3135 3434 3532 3035 3032 2020 31301544520502  10
  0007ceb0: 3030 2020 3130 3030 2020 3130 3036 3434  00  1000  100644
  0007cec0: 2020 3736 3420 2020 2020 2020 600a 7f45764   `..E
  0007ced0: 4c46 0101 0100     0100  LF..
 }}}
 I wonder why that is necessary here. Maybe the cross-toolchain for Android
 does not have something like `-Wl,--no-insert-timestamp`?

 2) Do we really need all the exported env variables in the build script?
 The build seemed to work for me e.g. without declaring `RANLIB`?

 3) The comment in the config file should we wrapped so that we have it on
 two lines instead of one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812R  |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam201812 => tbb-mobile, tbb-
 rbm, TorBrowserTeam201812R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

[Tor Bug Tracker & Wiki]

#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sisbell):

 * status:  new => needs_review


Comment:

 Initial commit for review (android-1207)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs