Re: [tor-bugs] #28859 [Metrics/ExoneraTor]: Use Java 8 date-time functionality in ExoneraTor

[Tor Bug Tracker & Wiki]

#28859: Use Java 8 date-time functionality in ExoneraTor
+-
 Reporter:  karsten |  Owner:  karsten
 Type:  enhancement | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Metrics/ExoneraTor  |Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  |  Actual Points:
Parent ID:  #23752  | Points:
 Reviewer:  irl |Sponsor:
+-
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:3 irl]:
 > Ok. I think this is somewhat like UTF-8 encoding/decoding in that we
 should be explicit whenever times come into and leave the application that
 they are converted to "local" time where this is the local time for the
 application, and for our use this will always be UTC. Let's just watch out
 for this.

 Makes sense. It's something to document clearly.

 > The patch looks good to me.

 Great, thanks for looking! Merged. Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28859 [Metrics/ExoneraTor]: Use Java 8 date-time functionality in ExoneraTor

[Tor Bug Tracker & Wiki]

#28859: Use Java 8 date-time functionality in ExoneraTor
+-
 Reporter:  karsten |  Owner:  karsten
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Metrics/ExoneraTor  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  #23752  | Points:
 Reviewer:  irl |Sponsor:
+-
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 Ok. I think this is somewhat like UTF-8 encoding/decoding in that we
 should be explicit whenever times come into and leave the application that
 they are converted to "local" time where this is the local time for the
 application, and for our use this will always be UTC. Let's just watch out
 for this.

 The patch looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28859 [Metrics/ExoneraTor]: Use Java 8 date-time functionality in ExoneraTor

[Tor Bug Tracker & Wiki]

#28859: Use Java 8 date-time functionality in ExoneraTor
+--
 Reporter:  karsten |  Owner:  karsten
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Metrics/ExoneraTor  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  #23752  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by karsten):

 * status:  assigned => needs_review


Comment:

 Please review
 
[https://gitweb.torproject.org/user/karsten/exonerator.git/commit/?h=task-28859=714862c3ecde23b44076c7dca42f8366714f8c11
 commit 714862c in my task-28859 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs