Re: [tor-bugs] #29204 [Core Tor/Tor]: Inspect circuit queue during padidng decisions

[Tor Bug Tracker & Wiki]

#29204: Inspect circuit queue during padidng decisions
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, 041-proposed, network-  |  Actual Points:
  team-roadmap-2019-Q1Q2, nickm-merge|
Parent ID:  #28634   | Points:  5
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor2
-+-
Changes (by teor):

 * milestone:   => Tor: 0.4.1.x-final


Comment:

 I think this is an unreleased bug, and it belongs in master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29204 [Core Tor/Tor]: Inspect circuit queue during padidng decisions

[Tor Bug Tracker & Wiki]

#29204: Inspect circuit queue during padidng decisions
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Very High|  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, 041-proposed, network-  |  Actual Points:
  team-roadmap-2019-Q1Q2, nickm-merge|
Parent ID:  #28634   | Points:  5
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor2
-+-
Changes (by dgoulet):

 * cc: dgoulet (removed)
 * keywords:  wtf-pad, 041-proposed, network-team-roadmap-2019-Q1Q2 => wtf-
 pad, 041-proposed, network-team-roadmap-2019-Q1Q2, nickm-merge
 * status:  needs_review => merge_ready


Comment:

 Once CI passes, this lgtm! Spec as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29204 [Core Tor/Tor]: Inspect circuit queue during padidng decisions

[Tor Bug Tracker & Wiki]

#29204: Inspect circuit queue during padidng decisions
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, 041-proposed, network-  |  Actual Points:
  team-roadmap-2019-Q1Q2 |
Parent ID:  #28634   | Points:  5
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor2
-+-
Changes (by mikeperry):

 * status:  needs_revision => needs_review


Comment:

 Ok. https://github.com/torproject/torspec/pull/62 for the spec. Updated
 https://github.com/torproject/tor/pull/719 to remove the flag update,
 which technically doesn't matter either way since the timer checks its own
 flag internally, and #28821 will unify that around the timer's flag.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29204 [Core Tor/Tor]: Inspect circuit queue during padidng decisions

[Tor Bug Tracker & Wiki]

#29204: Inspect circuit queue during padidng decisions
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, 041-proposed, network-  |  Actual Points:
  team-roadmap-2019-Q1Q2 |
Parent ID:  #28634   | Points:  5
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor2
-+-

Comment (by dgoulet):

 So after discussion with Mike on IRC, the approach in the patch is good.
 It is correct to only look at the circuit queue since circuit padding
 needs to pad on a per-circuit level.

 Two things. First, I think this is an artifact that shouldn't be in the
 patch:

 {{{
   mi->is_padding_timer_scheduled = 0;
 }}}

 Second, because this adds a new consensus param so we'll need a
 torspec.git patch before we release stable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29204 [Core Tor/Tor]: Inspect circuit queue during padidng decisions

[Tor Bug Tracker & Wiki]

#29204: Inspect circuit queue during padidng decisions
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, 041-proposed, network-  |  Actual Points:
  team-roadmap-2019-Q1Q2 |
Parent ID:  #28634   | Points:  5
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor2
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 One single comment in the PR :).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29204 [Core Tor/Tor]: Inspect circuit queue during padidng decisions

[Tor Bug Tracker & Wiki]

#29204: Inspect circuit queue during padidng decisions
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, 041-proposed, network-  |  Actual Points:
  team-roadmap-2019-Q1Q2 |
Parent ID:  #28634   | Points:  5
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor2
-+-
Changes (by mikeperry):

 * status:  new => needs_review
 * reviewer:   => dgoulet


Comment:

 https://github.com/torproject/tor/pull/719 - the simplest possible fix, to
 avoid OOM only.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29204 [Core Tor/Tor]: Inspect circuit queue during padidng decisions

[Tor Bug Tracker & Wiki]

#29204: Inspect circuit queue during padidng decisions
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, 041-proposed, network-  |  Actual Points:
  team-roadmap-2019-Q1Q2 |
Parent ID:  #28634   | Points:  5
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-
Changes (by asn):

 * parent:   => #28634


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29204 [Core Tor/Tor]: Inspect circuit queue during padidng decisions

[Tor Bug Tracker & Wiki]

#29204: Inspect circuit queue during padidng decisions
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, 041-proposed, network-  |  Actual Points:
  team-roadmap-2019-Q1Q2 |
Parent ID:   | Points:  5
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-

Comment (by mikeperry):

 Ok I think the first thing to do is to make this be a simple fix that
 prevents us from triggering OOM conditions. The simplest way to do this is
 to inspect the circuitmux queue and if it is too full, just not send the
 padding cell, emit a log, and tell the padding system we did send a
 padding cell. I filed #29494 for optimizing this solution, which we may or
 may not need to do depending on the padding machines we make.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29204 [Core Tor/Tor]: Inspect circuit queue during padidng decisions

[Tor Bug Tracker & Wiki]

#29204: Inspect circuit queue during padidng decisions
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, 041-proposed, network-  |  Actual Points:
  team-roadmap-2019-Q1Q2 |
Parent ID:   | Points:  5
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-
Changes (by gaba):

 * milestone:  Network Team 2019 Q1Q2 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29204 [Core Tor/Tor]: Inspect circuit queue during padidng decisions

[Tor Bug Tracker & Wiki]

#29204: Inspect circuit queue during padidng decisions
---+--
 Reporter:  mikeperry  |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Very High  |  Milestone:  2019Q1Q2
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  wtf-pad, 041-proposed  |  Actual Points:
Parent ID: | Points:  5
 Reviewer: |Sponsor:  Sponsor2
---+--
Changes (by gaba):

 * milestone:   => 2019Q1Q2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29204 [Core Tor/Tor]: Inspect circuit queue during padidng decisions

[Tor Bug Tracker & Wiki]

#29204: Inspect circuit queue during padidng decisions
---+--
 Reporter:  mikeperry  |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Very High  |  Milestone:
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  wtf-pad, 041-proposed  |  Actual Points:
Parent ID: | Points:  5
 Reviewer: |Sponsor:  Sponsor2
---+--
Changes (by mikeperry):

 * Attachment "Tor-Cell-Flow.jpeg" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs