Re: [tor-bugs] #29238 [Applications/Tor Browser]: TBA: Prevent crash following upgrade

[Tor Bug Tracker & Wiki]

#29238: TBA: Prevent crash following upgrade
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201904R, tbb-8.5-must|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_information => closed
 * resolution:   => fixed


Comment:

 Okay, I tried quite a bit but was not able to reproduce the original
 issue. :( However, the patch works for me and the change is simple enough,
 thus I cherry-picked it onto `tor-browser-60.6.1esr-8.5-1` as commit
 bfa54eb8ac5dc923527f07e48d0a390314991fd3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29238 [Applications/Tor Browser]: TBA: Prevent crash following upgrade

[Tor Bug Tracker & Wiki]

#29238: TBA: Prevent crash following upgrade
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201904R, tbb-8.5-must|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sysrqb):

 Yes, install a previous version of the app and run it, then install this
 patched version. It should not crash after installation and opening the
 app again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29238 [Applications/Tor Browser]: TBA: Prevent crash following upgrade

[Tor Bug Tracker & Wiki]

#29238: TBA: Prevent crash following upgrade
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201904R, tbb-8.5-must|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-mobile, TBA-a3, TorBrowserTeam201903, tbb-8.5-must => tbb-
 mobile, TBA-a3, TorBrowserTeam201904R, tbb-8.5-must
 * status:  needs_review => needs_information


Comment:

 Replying to [comment:9 sysrqb]:
 > Branch `bug29238` for review.

 The patch looks good. Do you have some instructions on how to test whether
 that's actually fixing the problem?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29238 [Applications/Tor Browser]: TBA: Prevent crash following upgrade

[Tor Bug Tracker & Wiki]

#29238: TBA: Prevent crash following upgrade
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201903, tbb-8.5-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * status:  new => needs_review


Comment:

 Branch `bug29238` for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29238 [Applications/Tor Browser]: TBA: Prevent crash following upgrade

[Tor Bug Tracker & Wiki]

#29238: TBA: Prevent crash following upgrade
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * priority:  Medium => High
 * keywords:  tbb-mobile, TBA-a3 => tbb-mobile, TBA-a3, TorBrowserTeam201901


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29238 [Applications/Tor Browser]: TBA: Prevent crash following upgrade

[Tor Bug Tracker & Wiki]

#29238: TBA: Prevent crash following upgrade
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TBA-a3|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sysrqb):

 I think we should disable this. We don't **need** it, it's simply a nice
 feature. Mozilla changed how they handle this in 63.
 [https://bugzilla.mozilla.org/show_bug.cgi?id=1467840 Bug 1467840].
 [https://hg.mozilla.org/mozilla-central/rev/90f3740655ea Upstream patch].

 This came from a run-time limitation introduced in
 [https://developer.android.com/about/versions/oreo/android-8.0-changes
 #back-all Android 8].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29238 [Applications/Tor Browser]: TBA: Prevent crash following upgrade

[Tor Bug Tracker & Wiki]

#29238: TBA: Prevent crash following upgrade
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TBA-a3|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sysrqb):

 Right. I had a feeling this was added so Fennec would load Gecko in the
 background after upgrade. This provides a pre-loaded Gecko runtiime, ready
 when the user opens the browser.

 {{{
 commit 60a646160ef9cba38952e0d4d6175bc16e7797ae
 Author: Jim Chen 
 Date:   Wed Feb 15 17:13:05 2017 -0500

 Bug 1339160 - 4. Use GeckoService to extract libs on update; r=esawin

 Use the GeckoService load-libs action to load and extract new
 libraries
 when we receive the update broadcast. This makes us not block the UI
 thread to extract libs, and lets Fennec run normally if the user
 launches Fennec right after updating.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29238 [Applications/Tor Browser]: TBA: Prevent crash following upgrade

[Tor Bug Tracker & Wiki]

#29238: TBA: Prevent crash following upgrade
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TBA-a3|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sysrqb):

 This is coming from [https://gitweb.torproject.org/tor-
 
browser.git/tree/mobile/android/base/java/org/mozilla/gecko/PackageReplacedReceiver.java?h
 =tor-browser-60.5.0esr-8.5-1 PackageReplacedReceiver] which is declared in
 the [https://gitweb.torproject.org/tor-
 browser.git/tree/mobile/android/base/AndroidManifest.xml.in?h=tor-
 browser-60.5.0esr-8.5-1#n418 manifest]. There's also
 [https://gitweb.torproject.org/tor-
 browser.git/tree/mobile/android/base/AndroidManifest.xml.in?h=tor-
 browser-60.5.0esr-8.5-1#n258 WhatsNew], but that doesn't crash, at least.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs