Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by cohosh):

 * status:  merge_ready => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  merge_ready
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---

Comment (by cohosh):

 Merged at `3bdcc3408ea`: https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/commit/?id=3bdcc3408ea2e5946dd27699e0f77e3f0f3816b2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  merge_ready
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by phw):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:13 cohosh]:
 > Here are some test additions and touch-ups to existing go unit testing
 code: https://github.com/cohosh/snowflake/pull/16
 [[br]]
 Looks good to me!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---

Comment (by cohosh):

 Okay I added a few code coverage visualizations. Obviously that's not the
 full story here, but I'm going to recommend calling this ticket done and
 then making another ticket that focuses on integration-style tests. This
 will be a bit tricker to do but I have some ideas of how to do it with
 snowbox. I do manual testing with snowbox before PRs and I have an idea on
 how to automate that. Since it's already in a docker container we can
 probably loop that into our CI.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by cohosh):

 * Attachment "common-safelog-coverage.html" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by cohosh):

 * Attachment "client-lib-coverage.html" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by cohosh):

 * Attachment "common-messages-coverage.html" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by cohosh):

 * Attachment "broker-coverage.html" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by cohosh):

 * Attachment "client-coverage.html" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by cohosh):

 * status:  assigned => needs_review


Comment:

 Here are some test additions and touch-ups to existing go unit testing
 code: https://github.com/cohosh/snowflake/pull/16

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by gaba):

 * keywords:  ex-sponsor-19, anti-censorship-roadmap => anti-censorship-
 roadmap-september


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
-+-
 Reporter:  ahf  |  Owner:  cohosh
 Type:  task | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ex-sponsor-19, anti-censorship-  |  Actual Points:
  roadmap|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by arlolra):

 * version:  Tor: unspecified =>
 * milestone:  Tor: unspecified =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
-+-
 Reporter:  ahf  |  Owner:  cohosh
 Type:  task | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Circumvention/Snowflake  |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  ex-sponsor-19, anti-censorship-  |  Actual Points:
  roadmap|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by gaba):

 * keywords:  ex-sponsor-19 => ex-sponsor-19, anti-censorship-roadmap


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
-+--
 Reporter:  ahf  |  Owner:  cohosh
 Type:  task | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Circumvention/Snowflake  |Version:  Tor: unspecified
 Severity:  Normal   | Resolution:
 Keywords:  ex-sponsor-19|  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  Sponsor28-must
-+--

Comment (by arlolra):

 > I suppose the goal of this would be to make sure that both versions show
 the same (or similar) behaviours?

 Ya, that they comply with some sort of specification.

 > We'd probably still want some independent tests for each implementation
 since they do differ a bit in how they work (e.g., the proxy-go instance
 uses tokens to handle multiple clients at once).

 That's only because it hasn't been implemented on the js side yet, see
 #25601

 But yes, to  your point, I was thinking more in terms of integration than
 unit testing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
-+--
 Reporter:  ahf  |  Owner:  cohosh
 Type:  task | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Circumvention/Snowflake  |Version:  Tor: unspecified
 Severity:  Normal   | Resolution:
 Keywords:  ex-sponsor-19|  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  Sponsor28-must
-+--

Comment (by cohosh):

 Hm, this is an interesting idea, but it sounds like a lot more work. I
 suppose the goal of this would be to make sure that both versions show the
 same (or similar) behaviours?

 The broker-facing functions (`pollOffer` and `sendAnswer`) and the
 proxying functions appear similarly structured across the two projects at
 least. We'd probably still want some independent tests for each
 implementation since they do differ a bit in how they work (e.g., the
 proxy-go instance uses tokens to handle multiple clients at once).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
-+--
 Reporter:  ahf  |  Owner:  cohosh
 Type:  task | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Circumvention/Snowflake  |Version:  Tor: unspecified
 Severity:  Normal   | Resolution:
 Keywords:  ex-sponsor-19|  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  Sponsor28-must
-+--

Comment (by arlolra):

 Since we have js and go implementations of the proxy, it might be nice to
 have a test runner that can exercise both in some language independent
 way.  Just a thought.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
-+--
 Reporter:  ahf  |  Owner:  cohosh
 Type:  task | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Circumvention/Snowflake  |Version:  Tor: unspecified
 Severity:  Normal   | Resolution:
 Keywords:  ex-sponsor-19|  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  Sponsor28-must
-+--
Description changed by cohosh:

Old description:

> We should aim for high test coverage and proper CI setup for Snowflake as
> early as possible in the process to ensure that we don't cause
> regressions or break things "randomly".
>
> Known issues:
> - We don't currently have any proxy-go tests.
> - Tests in `client/lib/rendezvous.go` rely on specific HTTP response
> bodies which is prone to change and unnecessary

New description:

 We should aim for high test coverage and proper CI setup for Snowflake as
 early as possible in the process to ensure that we don't cause regressions
 or break things "randomly".

 Known issues:
 - We don't currently have many proxy-go tests.
 - Tests in `client/lib/rendezvous.go` rely on specific HTTP response
 bodies which is prone to change and unnecessary

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
-+--
 Reporter:  ahf  |  Owner:  cohosh
 Type:  task | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Circumvention/Snowflake  |Version:  Tor: unspecified
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  Sponsor19
-+--
Changes (by cohosh):

 * status:  new => assigned
 * owner:  (none) => cohosh


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

[Tor Bug Tracker & Wiki]

#29259: Ensure high test coverage for Snowflake
-+--
 Reporter:  ahf  |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Circumvention/Snowflake  |Version:  Tor: unspecified
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  Sponsor19
-+--
Description changed by cohosh:

Old description:

> We should aim for high test coverage and proper CI setup for Snowflake as
> early as possible in the process to ensure that we don't cause
> regressions or break things "randomly".
>
> We also don't currently have any proxy-go tests.

New description:

 We should aim for high test coverage and proper CI setup for Snowflake as
 early as possible in the process to ensure that we don't cause regressions
 or break things "randomly".

 Known issues:
 - We don't currently have any proxy-go tests.
 - Tests in `client/lib/rendezvous.go` rely on specific HTTP response
 bodies which is prone to change and unnecessary

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs