Re: [tor-bugs] #29365 [Metrics/Onionperf]: Add digests and sizes to index.xml

[Tor Bug Tracker & Wiki]

#29365: Add digests and sizes to index.xml
-+-
 Reporter:  irl  |  Owner:  karsten
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  implemented
  team-roadmap-2020-june |  Actual Points:  0.4
Parent ID:  #33321   | Points:  0.5
 Reviewer:  acute|Sponsor:
 |  Sponsor59-must
-+-
Changes (by karsten):

 * status:  needs_revision => closed
 * resolution:   => implemented
 * actualpoints:  0.3 => 0.4


Comment:

 Okay, you're right that the overhead to compute these digests is really
 small. I had the CollecTor use case in mind where we include SHA-256
 digests of large descriptor tarballs. But it's true, the files produced by
 OnionPerf are tiny in comparison.

 I tweaked your patch a bit by making the field more similar to the one
 produced by CollecTor, that is, by calling it `sha256` and encoding the
 digest using base64. Example of the produced file:

 {{{
 
 
   
   
 ...
 }}}

 Rebased and pushed to master, and closing as implemented. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29365 [Metrics/Onionperf]: Add digests and sizes to index.xml

[Tor Bug Tracker & Wiki]

#29365: Add digests and sizes to index.xml
-+-
 Reporter:  irl  |  Owner:  karsten
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.3
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  0.5
 Reviewer:  acute|Sponsor:
 |  Sponsor59-must
-+-
Changes (by acute):

 * status:  needs_review => needs_revision
 * actualpoints:  0.2 => 0.3


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29365 [Metrics/Onionperf]: Add digests and sizes to index.xml

[Tor Bug Tracker & Wiki]

#29365: Add digests and sizes to index.xml
-+-
 Reporter:  irl  |  Owner:  karsten
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.2
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  0.5
 Reviewer:  acute|Sponsor:
 |  Sponsor59-must
-+-

Comment (by acute):

 Replying to [comment:9 karsten]:
 > Even though CollecTor is currently not using this file, we should add
 more information about files being served than just the filename.
 >
 > However, I think that computing file digests is too much, because we'd
 either have to recompute these digests for all files once per day or store
 them somewhere. If we really need these digests on the consuming side,
 then let's consider adding them. But until that's the case, let's try
 something simpler.
 >
 > I wrote a patch that includes sizes and last-modified times along with
 filenames. These can be looked up really quickly while writing the XML
 file. While touching this code I also made sure that the index.xml file
 itself is not contained and I fixed the encoding issue introduced by the
 Python 3 upgrade.
 >
 > Please review
 
[https://gitweb.torproject.org/user/karsten/onionperf.git/commit/?h=task-29365=011359d0ed6580bd8cb00f3ce8c510c4948accb7
 commit 011359d in my task-29365 branch].

 Thank you for the patch! I have read and tested it - no issues there and
 it can be merged.

 Also, I did a quick check  - it takes ~1 second to compute all sha256
 digests for one years' worth of OP data downloaded from Collector on my
 old Lenovo x220 - I don't think recomputing these is an issue on
 processors nowadays.

 Adding sha256 hashes would be a small change (have attached a patch), up
 to you if you want to go ahead with it :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29365 [Metrics/Onionperf]: Add digests and sizes to index.xml

[Tor Bug Tracker & Wiki]

#29365: Add digests and sizes to index.xml
-+-
 Reporter:  irl  |  Owner:  karsten
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.2
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  0.5
 Reviewer:  acute|Sponsor:
 |  Sponsor59-must
-+-
Changes (by acute):

 * Attachment "0001-Adds-file-SHA-256-digests-to-index.xml.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29365 [Metrics/Onionperf]: Add digests and sizes to index.xml

[Tor Bug Tracker & Wiki]

#29365: Add digests and sizes to index.xml
-+-
 Reporter:  irl  |  Owner:  karsten
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.2
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  0.5
 Reviewer:  acute|Sponsor:
 |  Sponsor59-must
-+-
Changes (by karsten):

 * reviewer:   => acute


Comment:

 acute kindly said that she'd be happy to review this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29365 [Metrics/Onionperf]: Add digests and sizes to index.xml

[Tor Bug Tracker & Wiki]

#29365: Add digests and sizes to index.xml
---+
 Reporter:  irl|  Owner:  karsten
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.2
Parent ID:  #33321 | Points:  0.5
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * actualpoints:   => 0.2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29365 [Metrics/Onionperf]: Add digests and sizes to index.xml

[Tor Bug Tracker & Wiki]

#29365: Add digests and sizes to index.xml
---+
 Reporter:  irl|  Owner:  karsten
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321 | Points:  0.5
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  accepted => needs_review


Comment:

 Even though CollecTor is currently not using this file, we should add more
 information about files being served than just the filename.

 However, I think that computing file digests is too much, because we'd
 either have to recompute these digests for all files once per day or store
 them somewhere. If we really need these digests on the consuming side,
 then let's consider adding them. But until that's the case, let's try
 something simpler.

 I wrote a patch that includes sizes and last-modified times along with
 filenames. These can be looked up really quickly while writing the XML
 file. While touching this code I also made sure that the index.xml file
 itself is not contained and I fixed the encoding issue introduced by the
 Python 3 upgrade.

 Please review
 
[https://gitweb.torproject.org/user/karsten/onionperf.git/commit/?h=task-29365=011359d0ed6580bd8cb00f3ce8c510c4948accb7
 commit 011359d in my task-29365 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29365 [Metrics/Onionperf]: Add digests and sizes to index.xml

[Tor Bug Tracker & Wiki]

#29365: Add digests and sizes to index.xml
---+
 Reporter:  irl|  Owner:  karsten
 Type:  enhancement| Status:  accepted
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321 | Points:  0.5
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  reopened => accepted
 * owner:  metrics-team => karsten


Comment:

 I'll give this a try.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29365 [Metrics/Onionperf]: Add digests and sizes to index.xml

[Tor Bug Tracker & Wiki]

#29365: Add digests and sizes to index.xml
---+--
 Reporter:  irl|  Owner:  metrics-team
 Type:  enhancement| Status:  reopened
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  0.5
 Reviewer: |Sponsor:  Sponsor59
---+--
Changes (by gaba):

 * keywords:   => metrics-team-roadmap-2020
 * points:   => 0.5
 * sponsor:   => Sponsor59


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29365 [Metrics/Onionperf]: Add digests and sizes to index.xml

[Tor Bug Tracker & Wiki]

#29365: Add digests and sizes to index.xml
---+--
 Reporter:  irl|  Owner:  metrics-team
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by gaba):

 * sponsor:  Sponsor13 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs