Re: [tor-bugs] #29696 [Metrics/Statistics]: Fix platform dependencies in data-processing modules

[Tor Bug Tracker & Wiki]

#29696: Fix platform dependencies in data-processing modules
+-
 Reporter:  karsten |  Owner:  karsten
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+-
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Thanks for the review! I think it's sufficient if you looked at the code.
 I already tested the branch using metrics-test, so that should be fine. I
 merged the changes to master, made a backup of the `tordir` database, and
 deployed the changes. We'll see in the next days if things fall apart, but
 I'm optimistic that they don't. Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29696 [Metrics/Statistics]: Fix platform dependencies in data-processing modules

[Tor Bug Tracker & Wiki]

#29696: Fix platform dependencies in data-processing modules
+-
 Reporter:  karsten |  Owner:  karsten
 Type:  defect  | Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+-
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 I have not been able to test this yet with metrics-test, but the commits
 make sense.

 I think we can merge this. I'll leave it to you to decide if you want to
 wait for me to run metrics-test though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29696 [Metrics/Statistics]: Fix platform dependencies in data-processing modules

[Tor Bug Tracker & Wiki]

#29696: Fix platform dependencies in data-processing modules
+--
 Reporter:  karsten |  Owner:  karsten
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by karsten):

 * status:  assigned => needs_review


Comment:

 Please review my [https://gitweb.torproject.org/user/karsten/metrics-
 web.git/log/?h=task-29696 metrics-web task-29696 branch] which can be
 tested using my [https://github.com/kloesing/metrics-test/tree/task-29696
 metrics-test task-29696 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs