Re: [tor-bugs] #29731 [Applications/Tor Browser]: tor compilation hangs frequently when building Windows testbuilds

[Tor Bug Tracker & Wiki]

#29731: tor compilation hangs frequently when building Windows testbuilds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, GeorgKoppen201904,  |  Actual Points:
  TorBrowserTeam201905R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 This looks good to me, and I was also able to reproduce a build with this
 patch. I merged it to master with commit
 5c0b72bce234088834297436ff20fc6942e935a3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29731 [Applications/Tor Browser]: tor compilation hangs frequently when building Windows testbuilds

[Tor Bug Tracker & Wiki]

#29731: tor compilation hangs frequently when building Windows testbuilds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201904,  |  Actual Points:
  TorBrowserTeam201905R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm => tbb-rbm, GeorgKoppen201904, TorBrowserTeam201905R
 * status:  new => needs_review


Comment:

 Replying to [comment:4 gk]:
 > Replying to [comment:2 gk]:
 > > I wonder why we still need to use `faketime` here at all...
 >
 > #20426 has historical context. However, we did not set `-Wl,--no-insert-
 timestamp` back then. So, I am wondering whether doing that now would work
 and help with this ticket.

 This bug got so annyoing in my dev workflow that I wrote a fix for it and
 tested the result. I still get reproducible output without using
 `faketime` here. `bug_29731_v2` (https://gitweb.torproject.org/user/gk
 /tor-browser-
 build.git/commit/?h=bug_29731_v2=dd007eb1419dac3905a5aa53dbbab02bea19d92b)
 has a fix for review.

 Note: macOS is affected by the same problem and I'll open a separate bug
 for that. However, that's not as problematic for me right now as I usually
 don't build macOS nightly bundles in my setup.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29731 [Applications/Tor Browser]: tor compilation hangs frequently when building Windows testbuilds

[Tor Bug Tracker & Wiki]

#29731: tor compilation hangs frequently when building Windows testbuilds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Replying to [comment:2 gk]:
 > I wonder why we still need to use `faketime` here at all...

 #20426 has historical context. However, we did not set `-Wl,--no-insert-
 timestamp` back then. So, I am wondering whether doing that now would work
 and help with this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29731 [Applications/Tor Browser]: tor compilation hangs frequently when building Windows testbuilds

[Tor Bug Tracker & Wiki]

#29731: tor compilation hangs frequently when building Windows testbuilds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Interestingly enough I seem to have less issues by compiling `tor`
 separately with `./rbm/rbm build tor --target nightly --target torbrowser-
 windows-x86_64`. I've not double-checked whether that's only luck or
 imagination, though. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29731 [Applications/Tor Browser]: tor compilation hangs frequently when building Windows testbuilds

[Tor Bug Tracker & Wiki]

#29731: tor compilation hangs frequently when building Windows testbuilds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: boklm (added)


Comment:

 I wonder why we still need to use `faketime` here at all...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29731 [Applications/Tor Browser]: tor compilation hangs frequently when building Windows testbuilds

[Tor Bug Tracker & Wiki]

#29731: tor compilation hangs frequently when building Windows testbuilds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Oh, it can happen the `install` target as well:
 {{{
 boklm 3761  0.0  0.1  29848 16108 ?S11:38   0:00 make
 install
 boklm 3769  0.0  0.1  29816 16104 ?S11:38   0:00 make
 install-exec-am install-data-am
 boklm 3773  0.0  0.0  21036  2988 ?S11:38   0:00 /bin/bash
 -c ( cd "/var/tmp/build/tor-911f95ed9203/src/rust" ; \
 .CARGO_TARGET_DIR="/var/tmp/build/tor-911f95ed9203/src/rust/target" \
 .cargo build --release  \ .--frozen \ .--manifest-path "/var/tmp/build
 /tor-911f95ed9203/src/rust/tor_rust/Cargo.toml" )
 boklm 3774  0.0  0.0  21040  2240 ?S11:38   0:00 /bin/bash
 -c ( cd "/var/tmp/build/tor-911f95ed9203/src/rust" ; \
 .CARGO_TARGET_DIR="/var/tmp/build/tor-911f95ed9203/src/rust/target" \
 .cargo build --release  \ .--frozen \ .--manifest-path "/var/tmp/build
 /tor-911f95ed9203/src/rust/tor_rust/Cargo.toml" )
 boklm 3775  0.0  0.1  43512 12084 ?Sl   11:38   0:00 cargo
 build --release --frozen --manifest-path /var/tmp/build/tor-
 911f95ed9203/src/rust/tor_rust/Cargo.toml
 }}}
 But it's Rust related, too. Smells like a `faketime` issue (which would
 fit to the fact that I saw this once with macOS as well, recently, but
 never Linux).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs