Re: [tor-bugs] #29740 [Core Tor/Tor]: Fix memory leaks in shared random unit tests: simple version

[Tor Bug Tracker & Wiki]

#29740: Fix memory leaks in shared random unit tests: simple version
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Major| Resolution:  fixed
 Keywords:  tor-ci, tor-test, memory-|  Actual Points:  0.3
  management, 029-backport, 034-backport,|
  035-backport, 040-backport, nickm-merge,   |
  dgoulet-merge  |
Parent ID:   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.3.5.x-final => Tor: 0.2.9.x-final


Comment:

 Merged to 0.2.9 and 0.3.4 and merged forward.
 Merged #29740 and #28656 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29740 [Core Tor/Tor]: Fix memory leaks in shared random unit tests: simple version

[Tor Bug Tracker & Wiki]

#29740: Fix memory leaks in shared random unit tests: simple version
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Very High|  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Major| Resolution:
 Keywords:  tor-ci, tor-test, memory-|  Actual Points:  0.3
  management, 029-backport, 034-backport,|
  035-backport, 040-backport, nickm-merge,   |
  dgoulet-merge  |
Parent ID:   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.4.0.x-final => Tor: 0.3.5.x-final


Comment:

 I've merged PR 802 above into 0.4.0 and forward to get the comment change.
 Marking for backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29740 [Core Tor/Tor]: Fix memory leaks in shared random unit tests: simple version

[Tor Bug Tracker & Wiki]

#29740: Fix memory leaks in shared random unit tests: simple version
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Major| Resolution:
 Keywords:  tor-ci, tor-test, memory-|  Actual Points:  0.3
  management, 029-backport, 034-backport,|
  035-backport, 040-backport, nickm-merge,   |
  dgoulet-merge  |
Parent ID:   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29740 [Core Tor/Tor]: Fix memory leaks in shared random unit tests: simple version

[Tor Bug Tracker & Wiki]

#29740: Fix memory leaks in shared random unit tests: simple version
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Major| Resolution:
 Keywords:  tor-ci, tor-test, memory-|  Actual Points:  0.3
  management, 029-backport, 034-backport,|
  035-backport, 040-backport, nickm-merge,   |
  dgoulet-merge  |
Parent ID:   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-

Comment (by teor):

 One appveyor test failed due to #29645. I'm going to relaunch the test to
 make sure there aren't any more failures.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29740 [Core Tor/Tor]: Fix memory leaks in shared random unit tests: simple version

[Tor Bug Tracker & Wiki]

#29740: Fix memory leaks in shared random unit tests: simple version
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Major| Resolution:
 Keywords:  tor-ci, tor-test, memory-|  Actual Points:  0.3
  management, 029-backport, 034-backport,|
  035-backport, 040-backport, nickm-merge,   |
  dgoulet-merge  |
Parent ID:   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by teor):

 * status:  reopened => needs_review
 * actualpoints:  0.1 => 0.3
 * parent:  #29706 =>
 * milestone:  Tor: 0.3.5.x-final => Tor: 0.4.0.x-final


Comment:

 It turns out we need to apply a9c3101 from #29706 to avoid all leaks:
 https://trac.torproject.org/projects/tor/ticket/29706#comment:12

 The pull requests are:

 0.2.9, one commit added:
 https://github.com/torproject/tor/pull/774

 0.3.4, merged, and one comment commit added:
 https://github.com/torproject/tor/pull/801

 0.4.0, comments merged, the code changes are already in 0.4.0:
 https://github.com/torproject/tor/pull/802

 (#29706 is too big to backport, so I'm un-parenting this ticket.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29740 [Core Tor/Tor]: Fix memory leaks in shared random unit tests: simple version

[Tor Bug Tracker & Wiki]

#29740: Fix memory leaks in shared random unit tests: simple version
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  reopened
 Priority:  Very High|  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Major| Resolution:
 Keywords:  tor-ci, tor-test, memory-|  Actual Points:  0.1
  management, 029-backport, 034-backport,|
  035-backport, 040-backport, nickm-merge,   |
  dgoulet-merge  |
Parent ID:  #29706   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by teor):

 * status:  closed => reopened
 * resolution:  fixed =>
 * milestone:  Tor: 0.4.1.x-final => Tor: 0.3.5.x-final


Comment:

 #29706 is not closed. And this change should be backported to 0.2.9 and
 later.
 Putting in 0.3.5, because #29706 was merged to 0.4.0 and later.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29740 [Core Tor/Tor]: Fix memory leaks in shared random unit tests: simple version

[Tor Bug Tracker & Wiki]

#29740: Fix memory leaks in shared random unit tests: simple version
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Major| Resolution:  fixed
 Keywords:  tor-ci, tor-test, memory-|  Actual Points:  0.1
  management, 029-backport, 034-backport,|
  035-backport, 040-backport, nickm-merge,   |
  dgoulet-merge  |
Parent ID:  #29706   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 #29706 is closed; closing this

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29740 [Core Tor/Tor]: Fix memory leaks in shared random unit tests: simple version

[Tor Bug Tracker & Wiki]

#29740: Fix memory leaks in shared random unit tests: simple version
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Major| Resolution:
 Keywords:  tor-ci, tor-test, memory-|  Actual Points:  0.1
  management, 029-backport, 034-backport,|
  035-backport, 040-backport, nickm-merge,   |
  dgoulet-merge  |
Parent ID:  #29706   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by teor):

 * priority:  High => Very High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29740 [Core Tor/Tor]: Fix memory leaks in shared random unit tests: simple version

[Tor Bug Tracker & Wiki]

#29740: Fix memory leaks in shared random unit tests: simple version
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Major| Resolution:
 Keywords:  tor-ci, tor-test, memory-|  Actual Points:  0.1
  management, 029-backport, 034-backport,|
  035-backport, 040-backport, nickm-merge,   |
  dgoulet-merge  |
Parent ID:  #29706   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by teor):

 * keywords:
 tor-ci, tor-test, memory-management, 029-backport, 034-backport,
 035-backport, 040-backport
 =>
 tor-ci, tor-test, memory-management, 029-backport, 034-backport,
 035-backport, 040-backport, nickm-merge, dgoulet-merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29740 [Core Tor/Tor]: Fix memory leaks in shared random unit tests: simple version

[Tor Bug Tracker & Wiki]

#29740: Fix memory leaks in shared random unit tests: simple version
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Major| Resolution:
 Keywords:  tor-ci, tor-test, memory-|  Actual Points:  0.1
  management, 029-backport, 034-backport,|
  035-backport, 040-backport |
Parent ID:  #29706   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => merge_ready
 * reviewer:   => asn


Comment:

 asn reviewed in #29706.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs