Re: [tor-bugs] #30092 [Core Tor/Tor]: Add a probability-to-apply field for circuitpadidng machines

[Tor Bug Tracker & Wiki]

#30092: Add a probability-to-apply field for circuitpadidng machines
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:  0.5
  padding, circpad-researchers-maybe-want|
Parent ID:   | Points:  2
 Reviewer:  asn  |Sponsor:
 |  Sponsor2-can
-+-
Changes (by mikeperry):

 * keywords:  wtf-pad, tor-relay, tor-cell, padding => wtf-pad, tor-relay,
 tor-cell, padding, circpad-researchers-maybe-want


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30092 [Core Tor/Tor]: Add a probability-to-apply field for circuitpadidng machines

[Tor Bug Tracker & Wiki]

#30092: Add a probability-to-apply field for circuitpadidng machines
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:  0.5
  padding|
Parent ID:   | Points:  2
 Reviewer:  asn  |Sponsor:
 |  Sponsor2-can
-+-
Changes (by asn):

 * milestone:   => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30092 [Core Tor/Tor]: Add a probability-to-apply field for circuitpadidng machines

[Tor Bug Tracker & Wiki]

#30092: Add a probability-to-apply field for circuitpadidng machines
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:  0.5
  padding|
Parent ID:   | Points:  2
 Reviewer:  asn  |Sponsor:
 |  Sponsor2-can
-+-
Changes (by mikeperry):

 * keywords:  wtf-pad, tor-relay, tor-cell, padding, 041-proposed => wtf-
 pad, tor-relay, tor-cell, padding
 * milestone:  Tor: 0.4.1.x-final =>


Comment:

 I agree with asn in comment:7. This may or may not help, and it seems like
 we'll need a probability_to_launch_new_circ option as well, somehow, if we
 do need this.

 Please let me know if this seems useful for padding research.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30092 [Core Tor/Tor]: Add a probability-to-apply field for circuitpadidng machines

[Tor Bug Tracker & Wiki]

#30092: Add a probability-to-apply field for circuitpadidng machines
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:  0.5
  padding, 041-proposed  |
Parent ID:   | Points:  2
 Reviewer:  asn  |Sponsor:
 |  Sponsor2-can
-+-
Changes (by mikeperry):

 * parent:  #28634 =>


Comment:

 No longer needed for #28634. I started working on this in mikeperry-
 github/ticket30092 (same PR; WIP commit there that doesn't compile) but
 I'm going to switch to higher prio tickets before finishing this up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30092 [Core Tor/Tor]: Add a probability-to-apply field for circuitpadidng machines

[Tor Bug Tracker & Wiki]

#30092: Add a probability-to-apply field for circuitpadidng machines
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:  0.5
  padding, 041-proposed  |
Parent ID:  #28634   | Points:  2
 Reviewer:  asn  |Sponsor:
 |  Sponsor2-can
-+-

Comment (by asn):

 BTW as a more general comment in this ticket, we should think a lot before
 we use this feature because the overhead danger is high (depending on the
 probability) and reaping the benefits is not always as straightforward.

 For example, consider using this feature for ticket #28634 to make general
 circuits look more random and blend in with random-lookin HS circuits. In
 that case, it's true that we increase the false positive rate of
 identifying a single intro or rend circuit, but if you look at the whole
 HS circuit dance, you can see that an HS client starts using 2 circuits at
 the same time (intro and rend, let's ignore hsdir for now). This ticket
 won't make normal clients start using 2 circuits at once, so even tho a
 single circuit might look random if the `probability` triggers, the fact
 that it's missing the second circuit  might still act as an identifier in
 that the session is not actually an HS dance and it's faking it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30092 [Core Tor/Tor]: Add a probability-to-apply field for circuitpadidng machines

[Tor Bug Tracker & Wiki]

#30092: Add a probability-to-apply field for circuitpadidng machines
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:  0.5
  padding, 041-proposed  |
Parent ID:  #28634   | Points:  2
 Reviewer:  asn  |Sponsor:
 |  Sponsor2-can
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30092 [Core Tor/Tor]: Add a probability-to-apply field for circuitpadidng machines

[Tor Bug Tracker & Wiki]

#30092: Add a probability-to-apply field for circuitpadidng machines
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:  0.5
  padding, 041-proposed  |
Parent ID:  #28634   | Points:  2
 Reviewer:  asn  |Sponsor:
 |  Sponsor2-can
-+-

Comment (by asn):

 OK this LGTM.

 I think a test would be nice tho since it has grown to non-trivial
 complexity after the last commit. Here is an easy way to test this:

 - Put the body of `if (machine->conditions.apply_with_probability > 0) {`
 into its own function which is gonna be unittested.
 - Create a mock machine and a mock circuit.
 - Call the new function a few times and check that
 `circ->padding_apply_coin_tossed` is behaving properly.

 I think this can be done without mocking `crypto_rand_double()` but you
 could also mock it so that it returns predictable stuff to make it more
 easy.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30092 [Core Tor/Tor]: Add a probability-to-apply field for circuitpadidng machines

[Tor Bug Tracker & Wiki]

#30092: Add a probability-to-apply field for circuitpadidng machines
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:  0.5
  padding, 041-proposed  |
Parent ID:  #28634   | Points:  2
 Reviewer:  asn  |Sponsor:
 |  Sponsor2-can
-+-
Changes (by asn):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30092 [Core Tor/Tor]: Add a probability-to-apply field for circuitpadidng machines

[Tor Bug Tracker & Wiki]

#30092: Add a probability-to-apply field for circuitpadidng machines
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:  0.5
  padding, 041-proposed  |
Parent ID:  #28634   | Points:  2
 Reviewer:   |Sponsor:
 |  Sponsor2-can
-+-
Changes (by mikeperry):

 * parent:   => #28634


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30092 [Core Tor/Tor]: Add a probability-to-apply field for circuitpadidng machines

[Tor Bug Tracker & Wiki]

#30092: Add a probability-to-apply field for circuitpadidng machines
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:  0.5
  padding, 041-proposed  |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
 |  Sponsor2-can
-+-
Changes (by nickm):

 * milestone:   => Tor: 0.4.1.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30092 [Core Tor/Tor]: Add a probability-to-apply field for circuitpadidng machines

[Tor Bug Tracker & Wiki]

#30092: Add a probability-to-apply field for circuitpadidng machines
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:  0.5
  padding, 041-proposed  |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
 |  Sponsor2-can
-+-
Changes (by mikeperry):

 * status:  new => needs_review
 * actualpoints:   => 0.5


Comment:

 https://github.com/torproject/tor/pull/916

 This was easy, but I'm not sure how best to test it. Open to suggestions
 if we feel it is necessary to test.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs