Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  openssl ux usability 035-backport|  Actual Points:  0.2
  040-backport dgoulet-merge |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.4.0.x-final => Tor: 0.3.5.x-final


Comment:

 Backported to 0.3.5.
 Merged with the other 0.3.5 and 0.4.0 backports on 2019-08-12.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  openssl ux usability 035-backport|  Actual Points:  0.2
  040-backport dgoulet-merge |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * status:  reopened => merge_ready


Comment:

 We missed a backport on this ticket, because we closed it after merging to
 master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  openssl ux usability 035-backport|  Actual Points:  0.2
  040-backport dgoulet-merge |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * keywords:  openssl ux usability 035-backport? 040-backport? dgoulet-merge
 => openssl ux usability 035-backport 040-backport dgoulet-merge
 * status:  closed => reopened
 * milestone:  Tor: 0.4.1.x-final => Tor: 0.4.0.x-final
 * resolution:  fixed =>
 * actualpoints:   => 0.2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  openssl ux usability 035-backport?   |  Actual Points:
  040-backport? dgoulet-merge|
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by dgoulet):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  openssl ux usability 035-backport?   |  Actual Points:
  040-backport? dgoulet-merge|
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * keywords:  openssl ux usability 035-backport? 040-backport? => openssl ux
 usability 035-backport? 040-backport? dgoulet-merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  openssl ux usability 035-backport?   |  Actual Points:
  040-backport?  |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 LGTM now; thank you!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  openssl ux usability 035-backport?   |  Actual Points:
  040-backport?  |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  openssl ux usability 035-backport?   |  Actual Points:
  040-backport?  |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Sorry for the delay -- I've been on vacation. I'll try to look at this
 again soon.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  openssl ux usability 035-backport?   |  Actual Points:
  040-backport?  |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by bmwiedemann):

 I think I got it right now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  openssl ux usability 035-backport?   |  Actual Points:
  040-backport?  |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by bmwiedemann):

 I could use some help there. It wants a ref of an old change.
 git blame gave me commit 3e3ec7 referencing issue 17549
 but commit 7607ad2 seems to be the original source
 and then how to find the release from that?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  openssl ux usability 035-backport?   |  Actual Points:
  040-backport?  |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 Looks better -- one problem is that the lintChanges.py script says that
 your changes file is not in the requested format, so CI is failing.  Could
 you make sure that `make check` and `make check-local` both pass?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  openssl ux usability 035-backport?   |  Actual Points:
  040-backport?  |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by bmwiedemann):

 I revised the patch as proposed and targeted it at maint-0.3.5

 also gave it a quick round of testing and got the notice.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  openssl ux usability 035-backport?   |  Actual Points:
  040-backport?  |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision
 * keywords:  openssl => openssl ux usability 035-backport? 040-backport?


Comment:

 Thanks for the patch!

 Teor is right -- I'm really glad that openssl is aiming for ABI
 compatibility now, but they are still have enough complexity going on that
 I'm not confident that they won't mess it up in the future.

 With that in mind, I'd suggest a middle-ground message. Let's log at
 NOTICE instead of INFO or WARN, and let's say something like "We compiled
 with OpenSSL X and we're running with OpenSSL Y. These two versions should
 be binary compatible."  That way if people do run into bugs some time they
 can report that message.

 Minor bookkeeping: let's base this on maint-0.3.5 rather than master so
 that we can backport it to LTS.  We'll also need a "changes" file as
 described in doc/HACKING/CodingStandards.md.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  openssl   |  Actual Points:
Parent ID:| Points:  0.2
 Reviewer:  nickm |Sponsor:
--+

Comment (by bmwiedemann):

 subscribing here

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  openssl   |  Actual Points:
Parent ID:| Points:  0.2
 Reviewer:  nickm |Sponsor:
--+
Changes (by teor):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  openssl   |  Actual Points:
Parent ID:| Points:  0.2
 Reviewer:  nickm |Sponsor:
--+

Comment (by teor):

 I think we've had issues in the past where OpenSSL has promised version
 compatibility, but failed to deliver.

 I've assigned review to nickm, because he knows about our issues with
 OpenSSL library and header versions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs