Re: [tor-bugs] #30206 [Circumvention/Snowflake]: Segfault in proxy-go

[Tor Bug Tracker & Wiki]

#30206: Segfault in proxy-go
-+
 Reporter:  irl  |  Owner:  cohosh
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by cohosh):

 Replying to [comment:12 arlolra]:
 >
 > One thing of note is that the goroutine was removed, which blocks
 `runSession()` from returning.  There's a similar question here as in
 ticket:30511#comment:4 on whether that deserves to called asynchronously.
 Yeah, we might want to add a timeout. I replied there:
 https://trac.torproject.org/projects/tor/ticket/30511#comment:5

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30206 [Circumvention/Snowflake]: Segfault in proxy-go

[Tor Bug Tracker & Wiki]

#30206: Segfault in proxy-go
-+
 Reporter:  irl  |  Owner:  cohosh
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by arlolra):

 Replying to [comment:11 cohosh]:
 > This patch looks good to me. I'm fine if you want to go ahead and merge
 it.

 Merged as https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/commit/?id=2e4383434f33a4f8e801974bbe70d8a4568b3d93

 One thing of note is that the goroutine was removed, which blocks
 `runSession()` from returning.  There's a similar question here as in
 ticket:30511#comment:4 on whether that deserves to called asynchronously.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30206 [Circumvention/Snowflake]: Segfault in proxy-go

[Tor Bug Tracker & Wiki]

#30206: Segfault in proxy-go
-+
 Reporter:  irl  |  Owner:  cohosh
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by cohosh):

 Good catch! Thanks for that.

 This patch looks good to me. I'm fine if you want to go ahead and merge
 it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30206 [Circumvention/Snowflake]: Segfault in proxy-go

[Tor Bug Tracker & Wiki]

#30206: Segfault in proxy-go
-+
 Reporter:  irl  |  Owner:  cohosh
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by arlolra):

 If `sendAnswer()` returns an error, `pc.Destroy()` is called and the token
 is returned,
 https://github.com/keroserene/snowflake/blob/master/proxy-
 go/snowflake.go#L370

 However, `makePeerConnectionFromOffer()` will have now set a timeout that
 will also call `pc.Destroy()`,
 https://github.com/keroserene/snowflake/blob/master/proxy-
 go/snowflake.go#L345

 This patch moves the timeout to after `sendAnswer` returns,
 
https://github.com/keroserene/snowflake/commit/2e4383434f33a4f8e801974bbe70d8a4568b3d93

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs