Re: [tor-bugs] #30224 [Core Tor/Tor]: Add the tor versions for bridge-distribution-request

[Tor Bug Tracker & Wiki]

#30224: Add the tor versions for bridge-distribution-request
+
 Reporter:  teor|  Owner:  teor
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  tor-spec, fast-fix  |  Actual Points:  0.2
Parent ID:  | Points:  0.1
 Reviewer:  catalyst|Sponsor:  Sponsor19-can
+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Thanks for the patch and the review! I've merged this to torspec.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30224 [Core Tor/Tor]: Add the tor versions for bridge-distribution-request

[Tor Bug Tracker & Wiki]

#30224: Add the tor versions for bridge-distribution-request
+
 Reporter:  teor|  Owner:  teor
 Type:  defect  | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-spec, fast-fix  |  Actual Points:  0.2
Parent ID:  | Points:  0.1
 Reviewer:  catalyst|Sponsor:  Sponsor19-can
+
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:4 teor]:
 > Here's how I found the feature version in tor:
 Thanks! I've confirmed this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30224 [Core Tor/Tor]: Add the tor versions for bridge-distribution-request

[Tor Bug Tracker & Wiki]

#30224: Add the tor versions for bridge-distribution-request
+
 Reporter:  teor|  Owner:  teor
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-spec, fast-fix  |  Actual Points:  0.2
Parent ID:  | Points:  0.1
 Reviewer:  catalyst|Sponsor:  Sponsor19-can
+
Changes (by teor):

 * actualpoints:  0.1 => 0.2


Comment:

 Here's how I found the feature version in tor:
 {{{
 $ git log -S bridge-distribution-request --reverse
 commit ebab521525
 Author: Roger Dingledine 
 Date:   Sun Nov 13 02:39:16 2016 -0500

 Add new BridgeDistribution config option

 Bridge relays can use it to add a "bridge-distribution-request" line
 to their bridge descriptor, which tells BridgeDB how they'd like their
 bridge address to be given out.

 Implements tickets 18329.
 ...
 $ git describe --contains ebab521525
 tor-0.3.2.3-alpha~15^2~4
 }}}

 And here's how I found the backport versions:
 {{{
 $ git log tp/maint-0.3.1 -S bridge-distribution-request --reverse
 commit 9f2efd02a1 (nickm/ticket18329_minimal_025)
 Author: Nick Mathewson 
 Date:   Mon Nov 13 20:44:51 2017 -0500

 Minimal implementation of bridge-distribution-request

 Just advertise the line when we're a bridge, using "any" if we're
 published or "none" if we aren't.

 This is done in lieu of a full backport of #18329.
 $ git tag --contains 9f2efd02a1 | sort -V
 tor-0.2.5.16
 tor-0.2.8.17
 tor-0.2.9.14
 tor-0.2.9.15
 tor-0.2.9.16
 tor-0.2.9.17
 tor-0.3.0.13
 tor-0.3.1.9
 tor-0.3.1.10
 tor-0.3.2.5-alpha
 ...
 }}}

 I didn't use `sort -V` when I was writing the patch, so I got the 0.3.1
 backport version wrong. I pushed a commit that changes the version to
 0.3.1.9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30224 [Core Tor/Tor]: Add the tor versions for bridge-distribution-request

[Tor Bug Tracker & Wiki]

#30224: Add the tor versions for bridge-distribution-request
+
 Reporter:  teor|  Owner:  teor
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-spec, fast-fix  |  Actual Points:  0.1
Parent ID:  | Points:  0.1
 Reviewer:  catalyst|Sponsor:  Sponsor19-can
+

Comment (by catalyst):

 The text of the changes looks good. It would be great if someone who knew
 the relevant history could fact-check the change. (I think I don't know
 enough to do so without possibly extensive research.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30224 [Core Tor/Tor]: Add the tor versions for bridge-distribution-request

[Tor Bug Tracker & Wiki]

#30224: Add the tor versions for bridge-distribution-request
+
 Reporter:  teor|  Owner:  teor
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-spec, fast-fix  |  Actual Points:  0.1
Parent ID:  | Points:  0.1
 Reviewer:  catalyst|Sponsor:  Sponsor19-can
+
Changes (by asn):

 * reviewer:   => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30224 [Core Tor/Tor]: Add the tor versions for bridge-distribution-request

[Tor Bug Tracker & Wiki]

#30224: Add the tor versions for bridge-distribution-request
+
 Reporter:  teor|  Owner:  teor
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-spec, fast-fix  |  Actual Points:  0.1
Parent ID:  | Points:  0.1
 Reviewer:  |Sponsor:  Sponsor19-can
+
Changes (by teor):

 * status:  assigned => needs_review


Comment:

 https://github.com/torproject/torspec/pull/77

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs