Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-september, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by gaba):

 * keywords:
 tor-hs, tbb-usability, hs-auth, network-team-roadmap-2019-Q1Q2, tor-
 spec
 =>
 tor-hs, tbb-usability, hs-auth, network-team-roadmap-september, tor-
 spec


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by mcs):

 Anyone who is not watching #30237 but who is interested in the browser UI
 aspects of this effort should read ticket:30237#comment:19.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by mcs):

 Replying to [comment:26 dgoulet]:
 > Apparently (feedback from mcs), the extended errors is sent out properly
 but only after `SocksTimeout`. Most likely, the connection is not properly
 closed when the extended error is set.

 A little more info about this: when we use `SocksTimeout 15`, the correct
 SOCKS error is sent after 30 seconds the first time we try to load the v3
 .onion, but it is sent after 15 seconds the second time we try to load it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by dgoulet):

 Apparently (feedback from mcs), the extended errors is sent out properly
 but only after `SocksTimeout`. Most likely, the connection is not properly
 closed when the extended error is set.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  accepted => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * owner:  (none) => dgoulet
 * status:  assigned => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Did an initial review on the PR!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 PR: https://github.com/torproject/tor/pull/1087
 Branch: `ticket30382_042_01`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Waiting for the unittests here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by asn):

 Replying to [comment:18 dgoulet]:
 > Code in `ticket30382_042_01`. I need asn to look at it to see if the
 approach seems sensible.
 >
 > Lots of pieces have been touched but in theory code behavior changed
 very little.

 Approach does seem sensible if it actually works as intended. Bonus points
 if it's testable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  accepted => needs_review
 * reviewer:   => asn


Comment:

 Code in `ticket30382_042_01`. I need asn to look at it to see if the
 approach seems sensible.

 Lots of pieces have been touched but in theory code behavior changed very
 little.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  needs_review => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-

Comment (by dgoulet):

 Ok I just posted a new version after discussing with asn. It is also now
 on tor-dev@:

 https://lists.torproject.org/pipermail/tor-dev/2019-May/013835.html

 I'll get onto the coding part soon.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-

Comment (by mcs):

 To follow up on the conversation we had on IRC, the Tor Browser code
 (Firefox 60esr) translates unknown SOCKS5 error codes to
 `PR_CONNECT_REFUSED_ERROR`, aka connection refused. Examples:
 [https://gitweb.torproject.org/tor-
 browser.git/tree/netwerk/socket/nsSOCKSIOLayer.cpp?h=tor-
 browser-60.7.0esr-9.0-1-build1#n836
 nsSOCKSSocketInfo::ReadV5UsernameResponse()] and
 [https://gitweb.torproject.org/tor-
 browser.git/tree/netwerk/socket/nsSOCKSIOLayer.cpp?h=tor-
 browser-60.7.0esr-9.0-1-build1#n947
 nsSOCKSSocketInfo::ReadV5ConnectResponseTop()].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-

Comment (by mcs):

 Replying to [comment:13 dgoulet]:
 > Hmmm `SocksPort` flag could be an option. The other way is to create a
 new authentication method like prop229 does and thus the new error code
 are only returned if TB authenticated with this method. Former is simple,
 later is more involving but probably more portable for future compat?

 I don't know what the right answer is, but on the browser side we could
 accommodate either solution. A new SOCKS5 auth method would be more work
 for us, but should be do-able. But maybe other SOCKS5 clients won't care
 if they receive new error codes? I don't know.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-

Comment (by dgoulet):

 Replying to [comment:12 mcs]:
 > Replying to [comment:11 dgoulet]:
 > > In my torspec repo:
 https://git.torproject.org/user/dgoulet/torspec.git
 > >
 > > Branch: `ticket30382_01`
 > >
 > > I think there are too many codes there for what we need here but I
 wanted to at least get the basic errors implemented as well. The last two
 are the one TB needs for this.
 >
 > Kathy and I think the proposal looks good. Just a couple of comments:
 > - I had trouble understanding the note near the beginning. Maybe reword
 to: "When Tor Browser supports HTTPCONNECT, we plan to stop using these
 SOCKS5 extensions."

 Was mostly a "future warning" for us to only extend SOCKS5 error code
 because it is a "bandaid" and ultimately `HTTPCONNECT` is the way forward.
 I'll rephrase.

 > - Regarding compatibility, it seems like it would be safer for tor to
 not emit these new error codes unless enabled via a config option (maybe a
 SocksPort flag). Otherwise, non Tor Browser clients that use the SocksPort
 may be unhappy. Or maybe enable by default but provide an "escape hatch"
 that allows them to be disabled somehow.

 Hmmm `SocksPort` flag could be an option. The other way is to create a new
 authentication method like prop229 does and thus the new error code are
 only returned if TB authenticated with this method. Former is simple,
 later is more involving but probably more portable for future compat?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-

Comment (by mcs):

 Replying to [comment:11 dgoulet]:
 > In my torspec repo: https://git.torproject.org/user/dgoulet/torspec.git
 >
 > Branch: `ticket30382_01`
 >
 > I think there are too many codes there for what we need here but I
 wanted to at least get the basic errors implemented as well. The last two
 are the one TB needs for this.

 Kathy and I think the proposal looks good. Just a couple of comments:
 - I had trouble understanding the note near the beginning. Maybe reword
 to: "When Tor Browser supports HTTPCONNECT, we plan to stop using these
 SOCKS5 extensions."
 - Regarding compatibility, it seems like it would be safer for tor to not
 emit these new error codes unless enabled via a config option (maybe a
 SocksPort flag). Otherwise, non Tor Browser clients that use the SocksPort
 may be unhappy. Or maybe enable by default but provide an "escape hatch"
 that allows them to be disabled somehow.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2, tor-spec   |
Parent ID:  #14389   | Points:  6
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * keywords:  tor-hs, tbb-usability, hs-auth, network-team-roadmap-2019-Q1Q2
 =>
 tor-hs, tbb-usability, hs-auth, network-team-roadmap-2019-Q1Q2, tor-
 spec
 * status:  accepted => needs_review


Comment:

 In my torspec repo: https://git.torproject.org/user/dgoulet/torspec.git

 Branch: `ticket30382_01`

 I think there are too many codes there for what we need here but I wanted
 to at least get the basic errors implemented as well. The last two are the
 one TB needs for this. Going in `needs_review`, once we are happy with the
 spec, lets put it back in `Assigned` so we can do the code and post the
 proposal on tor-dev@.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth,  |  Actual Points:
  network-team-roadmap-2019-Q1Q2 |
Parent ID:  #14389   | Points:  6
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by gaba):

 * keywords:  tor-hs, tbb-usability, hs-auth => tor-hs, tbb-usability, hs-
 auth, network-team-roadmap-2019-Q1Q2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
+--
 Reporter:  asn |  Owner:  dgoulet
 Type:  defect  | Status:  accepted
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth  |  Actual Points:
Parent ID:  #14389  | Points:  6
 Reviewer:  |Sponsor:
|  Sponsor27-must
+--

Comment (by dgoulet):

 Lets go with SOCKS5 error extension code! We'll re-use the prop229 and
 open a new one for only extending error codes!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
+--
 Reporter:  asn |  Owner:  dgoulet
 Type:  defect  | Status:  accepted
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth  |  Actual Points:
Parent ID:  #14389  | Points:  6
 Reviewer:  |Sponsor:
|  Sponsor27-must
+--

Comment (by asn):

 ACK. Makes sense.

 While it seems like we are moving towards the SOCKS direction, I should
 mention that comment:52:ticket:14389 also asks for some enhancements to
 our SOCKS handshake. We should probably oen a new ticket for this. Also,
 wrt this ticket, we should consider how to use prop#229 for any additional
 SOCKS error codes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
+--
 Reporter:  asn |  Owner:  dgoulet
 Type:  defect  | Status:  accepted
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth  |  Actual Points:
Parent ID:  #14389  | Points:  6
 Reviewer:  |Sponsor:
|  Sponsor27-must
+--

Comment (by mcs):

 Replying to [comment:6 dgoulet]:
 > So, if I'm not mistaken, you will get a connect failure _before_ you get
 the control port event because tor will return the SOCKS failure before
 that control port "empty queue" event is triggered.

 That makes sense and is good to know. I asked because the technique used
 by Arthur's old v2 auth Torbutton patch from ticket:14389#comment:14
 relies on receiving the control port event before the browser receives a
 connection failure indication via SOCKS. Unfortunately, it seems like we
 are back to adding a new error code to SOCKS5 or figuring out how to
 switch the browser to use HTTP CONNECT (which is a large and risky task
 due to the complexity of Firefox's networking stack and how HTTP CONNECT
 was implemented there).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
+--
 Reporter:  asn |  Owner:  dgoulet
 Type:  defect  | Status:  accepted
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth  |  Actual Points:
Parent ID:  #14389  | Points:  6
 Reviewer:  |Sponsor:
|  Sponsor27-must
+--

Comment (by dgoulet):

 Replying to [comment:5 mcs]:
 > Specifically, I wonder if it will be safe for Tor Browser to assume the
 control port event will be sent before the browser receives a failure for
 the CONNECT, or at least to assume that will occur in most cases.

 Hmmm... Control port events, when they occur, are queued in a list and
 then an tor main loop event will send the queued events on the socket.

 So, if I'm not mistaken, you will get a connect failure _before_ you get
 the control port event because tor will return the SOCKS failure before
 that control port "empty queue" event is triggered.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
+--
 Reporter:  asn |  Owner:  dgoulet
 Type:  defect  | Status:  accepted
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth  |  Actual Points:
Parent ID:  #14389  | Points:  6
 Reviewer:  |Sponsor:
|  Sponsor27-must
+--

Comment (by mcs):

 This all make sense to Kathy and me. One quick question — what will the
 timing be for:
 1. tor generating a `CLIENT_AUTH_NEEDED` event
 2. tor failing the SOCKS CONNECT
 ?

 Specifically, I wonder if it will be safe for Tor Browser to assume the
 control port event will be sent before the browser receives a failure for
 the CONNECT, or at least to assume that will occur in most cases.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
+--
 Reporter:  asn |  Owner:  dgoulet
 Type:  defect  | Status:  accepted
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth  |  Actual Points:
Parent ID:  #14389  | Points:  6
 Reviewer:  |Sponsor:
|  Sponsor27-must
+--
Changes (by dgoulet):

 * sponsor:   => Sponsor27-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
+--
 Reporter:  asn |  Owner:  dgoulet
 Type:  defect  | Status:  accepted
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth  |  Actual Points:
Parent ID:  #14389  | Points:  6
 Reviewer:  |Sponsor:
+--
Changes (by dgoulet):

 * owner:  (none) => dgoulet
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
+--
 Reporter:  asn |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth  |  Actual Points:
Parent ID:  #14389  | Points:  6
 Reviewer:  |Sponsor:
+--
Changes (by asn):

 * reviewer:  6 =>
 * points:   => 6


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30382 [Core Tor/Tor]: Provide control port event for when we are missing v3 client auth for an onion

[Tor Bug Tracker & Wiki]

#30382: Provide control port event for when we are missing v3 client auth for an
onion
+--
 Reporter:  asn |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, tbb-usability, hs-auth  |  Actual Points:
Parent ID:  #14389  | Points:
 Reviewer:  6   |Sponsor:
+--

Comment (by asn):

 I was thinking that the `CLIENT_AUTH_NEEDED` event would also need a
 `reason` field so that it can distinguish between `client auth is wrong`
 and `client auth is missing`, so that TB can give better error messages
 (see #30237).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs