Re: [tor-bugs] #30518 [Applications/Tor Browser]: Android - Add missing command line options

[Tor Bug Tracker & Wiki]

#30518: Android - Add missing command line options
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-8.5, |  Actual Points:  0
  TorBrowserTeam201910R  |
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * actualpoints:   => 0


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30518 [Applications/Tor Browser]: Android - Add missing command line options

[Tor Bug Tracker & Wiki]

#30518: Android - Add missing command line options
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-8.5, |  Actual Points:
  TorBrowserTeam201910R  |
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Great, looks good, I think we're done here. Thanks! The tor-browser-build
 patch was reverted in #30460.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30518 [Applications/Tor Browser]: Android - Add missing command line options

[Tor Bug Tracker & Wiki]

#30518: Android - Add missing command line options
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-8.5, |  Actual Points:
  TorBrowserTeam201910R  |
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-8.5, TorBrowserTeam201910 => tbb-mobile,
 tbb-8.5, TorBrowserTeam201910R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30518 [Applications/Tor Browser]: Android - Add missing command line options

[Tor Bug Tracker & Wiki]

#30518: Android - Add missing command line options
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-8.5, |  Actual Points:
  TorBrowserTeam201910   |
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by sisbell):

 * status:  new => needs_review


Comment:

 We can close this. Its supported here

 
https://github.com/thaliproject/Tor_Onion_Proxy_Library/commit/fcebb29b8299d6a7de262115e64ec2fda2b0c168
 #diff-9aaca4263fb73e2f8615d49825b318f2

 https://github.com/thaliproject/Tor_Onion_Proxy_Library/issues/130

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30518 [Applications/Tor Browser]: Android - Add missing command line options

[Tor Bug Tracker & Wiki]

#30518: Android - Add missing command line options
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-8.5, |  Actual Points:
  TorBrowserTeam201910   |
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  tbb-mobile, tbb-8.5, TorBrowserTeam201908 => tbb-mobile,
 tbb-8.5, TorBrowserTeam201910
 * points:   => 0.25


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30518 [Applications/Tor Browser]: Android - Add missing command line options

[Tor Bug Tracker & Wiki]

#30518: Android - Add missing command line options
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.5-must, tbb-mobile,|  Actual Points:
  TorBrowserTeam201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-8.5-must, tbb-mobile, TorBrowserTeam201905R =>
 tbb-8.5-must, tbb-mobile, TorBrowserTeam201905
 * status:  needs_review => new


Comment:

 Replying to [comment:6 sisbell]:
 > We should use the preferences that orbot is using to enable/disable
 IPv6Traffic so we maintain support for Orbot as well. I'll branch and add
 this to tor-android-service.

 Setting to `new` meanwhile. Please, reset for review once the branch is
 done, thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30518 [Applications/Tor Browser]: Android - Add missing command line options

[Tor Bug Tracker & Wiki]

#30518: Android - Add missing command line options
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.5-must, tbb-mobile,|  Actual Points:
  TorBrowserTeam201905R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 We should use the preferences that orbot is using to enable/disable
 IPv6Traffic so we maintain support for Orbot as well. I'll branch and add
 this to tor-android-service.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30518 [Applications/Tor Browser]: Android - Add missing command line options

[Tor Bug Tracker & Wiki]

#30518: Android - Add missing command line options
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.5-must, tbb-mobile,|  Actual Points:
  TorBrowserTeam201905R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 This issue also came up in the Orbot project in a commit that occurred
 after forking to tor-android-service

 
https://github.com/guardianproject/orbot/commit/12b91c44f3af675dd0db5a3bacbf232c0f8d61f4

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30518 [Applications/Tor Browser]: Android - Add missing command line options

[Tor Bug Tracker & Wiki]

#30518: Android - Add missing command line options
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.5-must, tbb-mobile,|  Actual Points:
  TorBrowserTeam201905R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-8.5-must => tbb-8.5-must, tbb-mobile,
   TorBrowserTeam201905R


Comment:

 Alright, what could go wrong: pushed to `master` (commit
 619cf8e9c1826812936b491711f67107aaf24fe7) and `maint-8.5` (commit
 a9fa9bf0e3bb67c235e677f02ac5f3a5b74dfb59).

 Please create additional bugs for doing the remaining work here (I guess
 the patch should get as well into TOPL in the next iteration) and close
 the ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30518 [Applications/Tor Browser]: Android - Add missing command line options

[Tor Bug Tracker & Wiki]

#30518: Android - Add missing command line options
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-8.5-must  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sysrqb):

 * status:  new => needs_review


Comment:

 Okay, branch `bug30518` in my repo. I am a little scared of this, but I
 think it's good.

 {{{
 $ ~/.mozbuild/android-sdk-linux/platform-tools/adb shell cat
 /data/data/org.torproject.torbrowser_nightly/app_torservice/torrc
 AutomapHostsOnResolve 1
 ControlPortWriteToFile
 /data/data/org.torproject.torbrowser_nightly/app_torservice/lib/tor/control.txt
 ControlPort auto
 CookieAuthentication 1
 CookieAuthFile
 
/data/data/org.torproject.torbrowser_nightly/app_torservice/lib/tor/control_auth_cookie
 DisableNetwork 1
 DNSPort 5400
 HTTPTunnelPort 8218
 ReducedConnectionPadding 1
 RunAsDaemon 1
 SafeSocks 0
 SOCKSPort auto KeepAliveIsolateSOCKSAuth IPv6Traffic PreferIPv6
 StrictNodes 0
 TestSocks 0
 TransPort 9140
 UseBridges 0
 VirtualAddrNetwork 10.192.0.0/10
 }}}

 As mentioned in #30284, we should cleanup other config options later, too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30518 [Applications/Tor Browser]: Android - Add missing command line options

[Tor Bug Tracker & Wiki]

#30518: Android - Add missing command line options
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-8.5-must  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sysrqb):

 Okay, I have a tor-browser-build branch (currently building) that patches
 TOPL such that `IPv6Traffic` `PreferIPv6` and `KeepAliveIsolateSOCKSAuth`
 are always added when the SocksPort is defined in the torrc. This isn't a
 good patch, but given the current constraints I think this is sufficient.
 I tested this patch on Android 4.1, 4.4, 5.1, 6, and 8. They all accept
 these new SocksPort flags without any apparent issues.

 I'll set this to `needs-review` after the branch finishes building and the
 tests still look good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30518 [Applications/Tor Browser]: Android - Add missing command line options

[Tor Bug Tracker & Wiki]

#30518: Android - Add missing command line options
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-8.5-must  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sisbell):

 IPv6Traffic PreferIPv6 KeepAliveIsolateSOCKSAuth are socks port flags in
 the config file, so that's probably where we want to add them.

 Android is using CookieAuthentication, we'd need another issue opened if
 we want to support HashedControlPassword.

 GeoIpFile and GeoIPv6File are already supported in torrc config file.
 DataDirectory is not currently supported so would need to be added.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs