Re: [tor-bugs] #31548 [Core Tor/Tor]: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints intro points

2019-11-24 Thread Tor Bug Tracker & Wiki 
#31548: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints 
intro
points
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  consider-backport-after-0424, tor-   |  Actual Points:  0.2
  hs, service, hs-v3, 035-backport,  |
  040-backport, 041-backport, 042-should |
Parent ID:  #29995   | Points:  0.2
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.4.1.x-final => Tor: 0.3.5.x-final


Comment:

 Merged to 0.3.5 and later.

 Merged #32575, #31939, #31548, #30344, #30258, #28970, #31091, and #32108
 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31548 [Core Tor/Tor]: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints intro points

2019-10-14 Thread Tor Bug Tracker & Wiki 
#31548: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints 
intro
points
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0424, tor-   |  Actual Points:  0.2
  hs, service, hs-v3, 035-backport,  |
  040-backport, 041-backport, 042-should |
Parent ID:  #29995   | Points:  0.2
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by teor):

 * keywords:
 tor-hs, service, hs-v3, 035-backport, 040-backport, 041-backport,
 042-should
 =>
 consider-backport-after-0424, tor-hs, service, hs-v3, 035-backport,
 040-backport, 041-backport, 042-should
 * version:   => Tor: 0.3.2.1-alpha
 * actualpoints:   => 0.2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31548 [Core Tor/Tor]: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints intro points

2019-10-07 Thread Tor Bug Tracker & Wiki 
#31548: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints 
intro
points
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, service, hs-v3,  |  Actual Points:
  035-backport, 040-backport, 041-backport,  |
  042-should |
Parent ID:  #29995   | Points:  0.2
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.1.x-final


Comment:

 Okay. I've made a squashed branch `ticket31548_035_01_squashed` with PR at
 https://github.com/torproject/tor/pull/1395

 Merged it to master, marking for backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31548 [Core Tor/Tor]: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints intro points

2019-10-07 Thread Tor Bug Tracker & Wiki 
#31548: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints 
intro
points
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, service, hs-v3,  |  Actual Points:
  035-backport, 040-backport, 041-backport,  |
  042-should |
Parent ID:  #29995   | Points:  0.2
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31548 [Core Tor/Tor]: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints intro points

2019-10-03 Thread Tor Bug Tracker & Wiki 
#31548: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints 
intro
points
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, service, hs-v3,  |  Actual Points:
  035-backport, 040-backport, 041-backport,  |
  042-should |
Parent ID:  #29995   | Points:  0.2
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Done, removed the `XXX` in the fixup commit:
 afcca119989a5b078cbfee8641024997af133e2b

 > BTW, do we do this check in v2?

 Nope, v2 is very different on how it picks intro points. I haven't analyze
 if it is also affected but I don't think so, I've never seen that behavior
 on v2.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31548 [Core Tor/Tor]: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints intro points

2019-09-11 Thread Tor Bug Tracker & Wiki 
#31548: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints 
intro
points
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, service, hs-v3,  |  Actual Points:
  035-backport, 040-backport, 041-backport,  |
  042-should |
Parent ID:  #29995   | Points:  0.2
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  accepted => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31548 [Core Tor/Tor]: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints intro points

2019-09-11 Thread Tor Bug Tracker & Wiki 
#31548: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints 
intro
points
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, service, hs-v3,  |  Actual Points:
  035-backport, 040-backport, 041-backport,  |
  042-should |
Parent ID:  #29995   | Points:  0.2
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * owner:  (none) => dgoulet
 * status:  needs_revision => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31548 [Core Tor/Tor]: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints intro points

2019-09-02 Thread Tor Bug Tracker & Wiki 
#31548: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints 
intro
points
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs service hs-v3 035-backport|  Actual Points:
  040-backport 041-backport  |
Parent ID:  #29995   | Points:  0.2
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Great find. LGTM. Just a tiny comment nitpick.

 BTW, do we do this check in v2?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31548 [Core Tor/Tor]: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints intro points

2019-08-29 Thread Tor Bug Tracker & Wiki 
#31548: hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints 
intro
points
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs service hs-v3 035-backport|  Actual Points:
  040-backport 041-backport  |
Parent ID:  #29995   | Points:  0.2
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  new => needs_review
 * reviewer:   => asn
 * points:   => 0.2
 * cc: asn (removed)
 * keywords:  tor-hs service hs-v3 => tor-hs service hs-v3 035-backport
 040-backport 041-backport


Comment:

 I recommend backport up to 035. This is major bugfix in my opinion
 affecting HS reachability quite a bit. This fix also mitigates #31561 that
 makes a service possibly put in the descriptor intro points for which it
 has *no* circuits, never.

 Following is based on maint-0.3.5:

 PR: https://github.com/torproject/tor/pull/1274
 Branch: `ticket31548_035_01`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs