Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:  .5
  TorBrowserTeam201911R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * actualpoints:   => .5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 sysrqb: please add your points.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks. I fixed a typo in the comment (to avoid another round-trip) and
 picked the fix onto `master` (commit
 4f97d497ea11a8325cafeaec6ac51fb10ef56de1) and `maint-9.0` (commit
 54091ab8d4a431458105d2be5346ac5232fea265). It should be available in 9.5a3
 and 9.0.2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  tbb-9.0-issues, tbb-9.0-regression, TorBrowserTeam201911 =>
 tbb-9.0-issues, tbb-9.0-regression, TorBrowserTeam201911R
 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sysrqb):

 Replying to [comment:8 gk]:
 > Replying to [comment:6 sysrqb]:
 > > Okay, i think option (3) is the more simple. We only need `./mach
 android assemble-app`. I also filtered `mk` from the locale list. Branch
 `bug32365_02`.
 >
 > Thanks! I assume the change got introduced in
 https://bugzilla.mozilla.org/show_bug.cgi?id=1443208 and looking at that
 bug your patch looks good. However, I don't think we should filter `mk` as
 you do. *If* we do the filtering no `mk` content is shown. But if we don't
 do it then at least the Torbutton parts (like the `about:tor` page) *are*
 localized if you have an `mk` device. I'd argue that is a win. We probably
 should put a comment above the part where you filtered `mk` as this
 behavior is not obvious.

 That makes sense. I created a new branch reflecting these changes.
 `bug32365_03`

 >
 > What bothers me is that the locale is still not properly propagated to
 our `about:tor` page and fundraising parts. It's just the default link
 that's visible unless you switch the locale. But then after restart you
 see the same again. We should file a ticket for that and get this fixed
 for the next release.

 I debugged this. It is cause by two problems.

 1. In `aboutTor-content.js`:`onPageLoad` we only track changes of
 `intl.locale.os`, however, in Fennec the locale may be set by either
 `intl.locale.os` or `intl.locale.requested`.

 1. When `about:tor` is loaded, `onLocaleChange` is called before
 `onChromeDataUpdate`, therefore the
 `content.document.body.getAttribute("mobile")` conditional in
 `onLocaleChange` is always `undefined` at the first page load.

 I opened #32628 for this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * status:  assigned => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * status:  needs_revision => assigned
 * cc: sysrqb (removed)
 * cc: tbb-team (added)
 * owner:  tbb-team => sysrqb


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-9.0-issues, tbb-9.0-regression, TorBrowserTeam201911R =>
 tbb-9.0-issues, tbb-9.0-regression, TorBrowserTeam201911
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:6 sysrqb]:
 > Okay, i think option (3) is the more simple. We only need `./mach
 android assemble-app`. I also filtered `mk` from the locale list. Branch
 `bug32365_02`.

 Thanks! I assume the change got introduced in
 https://bugzilla.mozilla.org/show_bug.cgi?id=1443208 and looking at that
 bug your patch looks good. However, I don't think we should filter `mk` as
 you do. *If* we do the filtering no `mk` content is shown. But if we don't
 do it then at least the Torbutton parts (like the `about:tor` page) *are*
 localized if you have an `mk` device. I'd argue that is a win. We probably
 should put a comment above the part where you filtered `mk` as this
 behavior is not obvious.

 What bothers me is that the locale is still not properly propagated to our
 `about:tor` page and fundraising parts. It's just the default link that's
 visible unless you switch the locale. But then after restart you see the
 same again. We should file a ticket for that and get this fixed for the
 next release.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-9.0-issues, tbb-9.0-regression, TorBrowserTeam201911 =>
 tbb-9.0-issues, tbb-9.0-regression, TorBrowserTeam201911R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sysrqb):

 Okay, i think option (3) is the more simple. We only need `./mach android
 assemble-app`. I also filtered `mk` from the locale list. Branch
 `bug32365_02`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * status:  new => needs_review


Comment:

 Replying to [comment:4 gk]:
 > Replying to [comment:2 sysrqb]:
 > > Replying to [comment:1 gk]:
 > > > I wonder whether this issue is actually related to #28196, but maybe
 not.
 > > It seems all chrome content is correctly localized, but the Java
 strings are not localized. Hopefully there is a simple fix.
 >
 > Not sure if you are seeing the same bug as I but for me essentially the
 whole browser chrome is *not* localized. The exception here is UI coming
 from Torbutton which *is* localized. So, e.g. the whole Settings menu
 items are only in English.
 Right, sorry, "chrome" wasn't the correct description. I should've said
 something like "privileged-chrome content". For example, `about:firefox`
 is correctly localized, but I see the menu and and preferences are not
 localized.

 It seems the reason for this is Mozilla changed how they create multi-
 locale packages. We have two options.

 1) I have a patch for this in my tor-browser-build repo,
 `bug32365_00`.Unfortunately, the firefox build is broken using this method
 because apparently we broke `./mach android archive-geckoview`, and this
 is called as the final step in `./mach package-multi-locale`. I created a
 tor-browser patch that comments-out calling `./mach android archive-
 geckoview`, as a workaround.

 2) Another alternative is we re-implement `./mach package-multi-locale` in
 the firefox build file. It is relatively straight-forward, see
 `package_l10n` in `python/mozbuild/mozbuild/mach_commands.py`. I have
 another branch with only this tor-browser-build patch, `bug32365_01`.

 Considering option (2) is a small change, that seems like the better
 solution. I'm building a small variant of (2) now, as well - using `./mach
 package` instead of `make package`. It's possible `./mach android
 assemble-app` is the only missing piece.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:2 sysrqb]:
 > Replying to [comment:1 gk]:
 > > I wonder whether this issue is actually related to #28196, but maybe
 not.
 > It seems all chrome content is correctly localized, but the Java strings
 are not localized. Hopefully there is a simple fix.

 Not sure if you are seeing the same bug as I but for me essentially the
 whole browser chrome is *not* localized. The exception here is UI coming
 from Torbutton which *is* localized. So, e.g. the whole Settings menu
 items are only in English.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  tbb-9.0-issues, tbb-9.0-regression => tbb-9.0-issues,
 tbb-9.0-regression, TorBrowserTeam201911


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  High|  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Major   | Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by sysrqb):

 Replying to [comment:1 gk]:
 > I wonder whether this issue is actually related to #28196, but maybe
 not.
 It seems all chrome content is correctly localized, but the Java strings
 are not localized. Hopefully there is a simple fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  High|  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Major   | Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by gk):

 I wonder whether this issue is actually related to #28196, but maybe not.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs