Re: [tor-bugs] #32627 [Core Tor/Tor]: deploy torspec as HTML to GitLab Pages

[Tor Bug Tracker & Wiki]

#32627: deploy torspec as HTML to GitLab Pages
-+-
 Reporter:  eighthave|  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 |  implemented
 Keywords:  torspec, doc, extra-review, 043-can  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  ahf, nickm   |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor/Tor]: deploy torspec as HTML to GitLab Pages

[Tor Bug Tracker & Wiki]

#32627: deploy torspec as HTML to GitLab Pages
-+-
 Reporter:  eighthave|  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  torspec, doc, extra-review, 043-can  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  ahf, nickm   |Sponsor:
-+-
Changes (by ahf):

 * keywords:  torspec, doc, extra-review => torspec, doc, extra-review,
 043-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor/Tor]: deploy torspec as HTML to GitLab Pages

[Tor Bug Tracker & Wiki]

#32627: deploy torspec as HTML to GitLab Pages
+--
 Reporter:  eighthave   |  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  torspec, doc, extra-review  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  ahf, nickm  |Sponsor:
+--

Comment (by eighthave):

 I only included this preprocessor as a temporary measure to help with
 migrating to Markdown (or whatever format).  I don't think it makes sense
 to keep it around beyond its use in migrating to Markdown.  I think one
 workable policy here would be to just say all future edits must be
 Markdown, then the rest of the documents can be migrated as the
 opportunity arises, either piecemeal or all at once.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor/Tor]: deploy torspec as HTML to GitLab Pages

[Tor Bug Tracker & Wiki]

#32627: deploy torspec as HTML to GitLab Pages
+--
 Reporter:  eighthave   |  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  torspec, doc, extra-review  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  ahf, nickm  |Sponsor:
+--
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 I think this is okay; we might decide to do it differently later on, but
 for now, this is far better than nothing.

 (In the long term, maybe we should just have our specs be in markdown
 directly, so they won't need a preprocessor?  I'm not sure there.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor/Tor]: deploy torspec as HTML to GitLab Pages

[Tor Bug Tracker & Wiki]

#32627: deploy torspec as HTML to GitLab Pages
+--
 Reporter:  eighthave   |  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  torspec, doc, extra-review  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  ahf, nickm  |Sponsor:
+--
Changes (by ahf):

 * reviewer:  ahf => ahf, nickm


Comment:

 I think it looks good. Teor wanted Nick to give some input here too.

 Please avoid changing things in the pull-request while we are doing
 reviews. This makes it very hard to review anything :-) We can always do
 changes once things have been merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor/Tor]: deploy torspec as HTML to GitLab Pages

[Tor Bug Tracker & Wiki]

#32627: deploy torspec as HTML to GitLab Pages
+--
 Reporter:  eighthave   |  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  torspec, doc, extra-review  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  ahf |Sponsor:
+--
Changes (by teor):

 * status:  merge_ready => needs_review


Comment:

 Putting back in needs_review, because the PR changed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor/Tor]: deploy torspec as HTML to GitLab Pages

[Tor Bug Tracker & Wiki]

#32627: deploy torspec as HTML to GitLab Pages
+--
 Reporter:  eighthave   |  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  torspec, doc, extra-review  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  ahf |Sponsor:
+--

Comment (by eighthave):

 The current output is visible here: https://eighthave.gitlab.io/torspec/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor/Tor]: deploy torspec as HTML to GitLab Pages

[Tor Bug Tracker & Wiki]

#32627: deploy torspec as HTML to GitLab Pages
+--
 Reporter:  eighthave   |  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  torspec, doc, extra-review  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  ahf |Sponsor:
+--

Comment (by eighthave):

 I updated the merge request to fix all blockquote issues I could find,
 only by adding blank newlines.  And a second commit that makes the
 generated HTML complete with a header and footer.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor/Tor]: deploy torspec as HTML to GitLab Pages

[Tor Bug Tracker & Wiki]

#32627: deploy torspec as HTML to GitLab Pages
+--
 Reporter:  eighthave   |  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  torspec, doc, extra-review  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  ahf |Sponsor:
+--
Changes (by teor):

 * cc: nickm (added)
 * keywords:  torspec, doc => torspec, doc, extra-review


Comment:

 Since this is a new feature, I just want to check with nickm before
 merging it?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor/Tor]: deploy torspec as HTML to GitLab Pages

[Tor Bug Tracker & Wiki]

#32627: deploy torspec as HTML to GitLab Pages
--+
 Reporter:  eighthave |  Owner:  (none)
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  torspec, doc  |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 I think we should merge this for the following reasons:

 1. The output is a bit rough in the edges, but we can fix the formatting
 over time.
 2. We can extend it to include proposals over time and also fix their
 formatting over time.
 3. It will integrate well if/when we move to Gitlab ourselves.
 4. It's only a single additional file in the repository.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor/Tor]: deploy torspec as HTML to GitLab Pages

[Tor Bug Tracker & Wiki]

#32627: deploy torspec as HTML to GitLab Pages
--+
 Reporter:  eighthave |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  torspec, doc  |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by asn):

 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor/Tor]: deploy torspec as HTML to GitLab Pages

[Tor Bug Tracker & Wiki]

#32627: deploy torspec as HTML to GitLab Pages
--+
 Reporter:  eighthave |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  torspec, doc  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by eighthave):

 Having it in `sed` makes the whole GitLab CI process a single file, that's
 working.  The Python script is there for anyone who wants to improve the
 automated conversion, or use it for doing a final conversion to a standard
 format.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor/Tor]: deploy torspec as HTML to GitLab Pages

[Tor Bug Tracker & Wiki]

#32627: deploy torspec as HTML to GitLab Pages
--+
 Reporter:  eighthave |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  torspec, doc  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * keywords:  torspec => torspec, doc
 * type:  defect => enhancement
 * component:  Core Tor => Core Tor/Tor
 * milestone:   => Tor: 0.4.3.x-final


Comment:

 Thanks for this code!

 I think we'd prefer python to sed, but I'll leave that to the reviewer to
 decide.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs