Re: [tor-bugs] #32822 [Core Tor/Tor]: Make authorities add their own IPv6 address to trusted dir servers

[Tor Bug Tracker & Wiki]

#32822: Make authorities add their own IPv6 address to trusted dir servers
---+
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, 044-can  |  Actual Points:  0.4
Parent ID: | Points:  0.2
 Reviewer:  dgoulet|Sponsor:
---+
Changes (by nickm):

 * keywords:  ipv6, 044-should => ipv6, 044-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32822 [Core Tor/Tor]: Make authorities add their own IPv6 address to trusted dir servers

[Tor Bug Tracker & Wiki]

#32822: Make authorities add their own IPv6 address to trusted dir servers
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6, 044-should  |  Actual Points:  0.4
Parent ID:| Points:  0.2
 Reviewer:  dgoulet   |Sponsor:
--+

Comment (by nickm):

 hm, it looks like this is based on #32588, which is already merged in
 master.  Dgoulet, do you have a sense which of these patches we should
 merge and how we should take them?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32822 [Core Tor/Tor]: Make authorities add their own IPv6 address to trusted dir servers

[Tor Bug Tracker & Wiki]

#32822: Make authorities add their own IPv6 address to trusted dir servers
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6, 044-should  |  Actual Points:  0.4
Parent ID:| Points:  0.2
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 This is fine by me tbh. I think we could merge this. Ideal world is unit
 tests but there is just so much we can do I guess.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32822 [Core Tor/Tor]: Make authorities add their own IPv6 address to trusted dir servers

[Tor Bug Tracker & Wiki]

#32822: Make authorities add their own IPv6 address to trusted dir servers
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6, 044-should  |  Actual Points:  0.4
Parent ID:| Points:  0.2
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 It's unlikely that I'll ever write tests for this feature, but someone
 else is welcome to do that, and then merge.

 (Or merge without tests, if they think the code is simple enough.)

 Putting this in needs_review to see what we think here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32822 [Core Tor/Tor]: Make authorities add their own IPv6 address to trusted dir servers

[Tor Bug Tracker & Wiki]

#32822: Make authorities add their own IPv6 address to trusted dir servers
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6, 044-should  |  Actual Points:  0.4
Parent ID:| Points:  0.2
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by teor):

 * keywords:  ipv6 => ipv6, 044-should


Comment:

 I'll look at this ticket again some time during 0.4.4.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32822 [Core Tor/Tor]: Make authorities add their own IPv6 address to trusted dir servers

[Tor Bug Tracker & Wiki]

#32822: Make authorities add their own IPv6 address to trusted dir servers
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6  |  Actual Points:  0.4
Parent ID:| Points:  0.2
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by teor):

 * milestone:  Tor: 0.4.3.x-final => Tor: 0.4.4.x-final


Comment:

 Let's do this in 0.4.4: it's a feature, and there's no need to add it at
 the last minute.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32822 [Core Tor/Tor]: Make authorities add their own IPv6 address to trusted dir servers

[Tor Bug Tracker & Wiki]

#32822: Make authorities add their own IPv6 address to trusted dir servers
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6  |  Actual Points:  0.4
Parent ID:| Points:  0.2
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by teor):

 * actualpoints:  0.3 => 0.4


Comment:

 I added some tests for authority IPv6 ORPort config parsing. They don't
 actually use the authority IPv6 ORPort self-add feature, but they do
 increase the coverage of the related config code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32822 [Core Tor/Tor]: Make authorities add their own IPv6 address to trusted dir servers

[Tor Bug Tracker & Wiki]

#32822: Make authorities add their own IPv6 address to trusted dir servers
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6  |  Actual Points:  0.3
Parent ID:| Points:  0.2
 Reviewer:  dgoulet   |Sponsor:
--+

Comment (by teor):

 I made some fixes, but I still need to do unit tests, so I'm leaving it in
 needs_revision.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32822 [Core Tor/Tor]: Make authorities add their own IPv6 address to trusted dir servers

[Tor Bug Tracker & Wiki]

#32822: Make authorities add their own IPv6 address to trusted dir servers
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6  |  Actual Points:  0.3
Parent ID:| Points:  0.2
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Couple comments on PR. Nothing crazy! looks good!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32822 [Core Tor/Tor]: Make authorities add their own IPv6 address to trusted dir servers

[Tor Bug Tracker & Wiki]

#32822: Make authorities add their own IPv6 address to trusted dir servers
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6  |  Actual Points:  0.3
Parent ID:| Points:  0.2
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by teor):

 * status:  needs_revision => needs_review
 * actualpoints:  0.2 => 0.3


Comment:

 I also forgot to check for an empty IPv6 address in this patch (in a
 different way to the last one).

 I re-did the patch, so I could rewrite the commit message.

 I still need to write some tests, but I'd like a review :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32822 [Core Tor/Tor]: Make authorities add their own IPv6 address to trusted dir servers

[Tor Bug Tracker & Wiki]

#32822: Make authorities add their own IPv6 address to trusted dir servers
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6  |  Actual Points:  0.2
Parent ID:| Points:  0.2
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => needs_revision
 * reviewer:   => dgoulet


Comment:

 One CI build fails with asserts. I just seen that one in another ticket of
 yours. Might not be related to the fix itself?

 In any case, putting back in needs revision to figure that one out.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32822 [Core Tor/Tor]: Make authorities add their own IPv6 address to trusted dir servers

[Tor Bug Tracker & Wiki]

#32822: Make authorities add their own IPv6 address to trusted dir servers
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6  |  Actual Points:  0.2
Parent ID:| Points:  0.2
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  assigned => needs_review


Comment:

 This ticket depends on a new function added in #32588.

 See my PR:
 * master: https://github.com/torproject/tor/pull/1626

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs