Re: [tor-bugs] #32992 [Applications/Tor Browser]: TBB Project for LZMA

[Tor Bug Tracker & Wiki]

#32992: TBB Project for LZMA
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  1
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sisbell):

 * actualpoints:   => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32992 [Applications/Tor Browser]: TBB Project for LZMA

[Tor Bug Tracker & Wiki]

#32992: TBB Project for LZMA
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:16 sisbell]:
 > Moved the gpg key to keyring directory
 >
 > Added the configure_opt_project variable that uses common CC and host
 fields.
 >
 > https://github.com/sisbell/tor-browser-build/commits/bug-32992b

 This looks good to me. I cherry-picked the patch to master as commit
 `bd21fef218312e8c64e932de989a848e98e2027a`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32992 [Applications/Tor Browser]: TBB Project for LZMA

[Tor Bug Tracker & Wiki]

#32992: TBB Project for LZMA
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Moved the gpg key to keyring directory

 Added the configure_opt_project variable that uses common CC and host
 fields.

 https://github.com/sisbell/tor-browser-build/commits/bug-32992b

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32992 [Applications/Tor Browser]: TBB Project for LZMA

[Tor Bug Tracker & Wiki]

#32992: TBB Project for LZMA
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sisbell):

 * status:  needs_revision => needs_review
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202002 => tbb-mobile, tbb-
 rbm, TorBrowserTeam202003R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32992 [Applications/Tor Browser]: TBB Project for LZMA

[Tor Bug Tracker & Wiki]

#32992: TBB Project for LZMA
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 I see my mistake. I have the keyring in wrong location.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32992 [Applications/Tor Browser]: TBB Project for LZMA

[Tor Bug Tracker & Wiki]

#32992: TBB Project for LZMA
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:13 boklm]:


 > Replying to [comment:12 sisbell]:
 >
 > > Replying to [comment:10 boklm]:
 > >
 > > > Replying to [comment:7 sisbell]:
 > > >
 > > >
 > > > >
 > > > > And then building the project, I get an error
 > > > >
 > > > > {{{
 > > > > Error: v5.2.4 is not a signed tag
 > > > > }}}
 > > > >
 > > > > Any ideas on what is going wrong?
 > > > >
 > > > >
 > > >
 > > > I have no idea what's going wrong. Do you have a branch with the
 changes you tried so I can investigate the issue?
 > > >
 > > I created a branch with the key and config that I was using when I
 encountered the errors. I'll do some more testing as well on this
 > >
 > > https://github.com/sisbell/tor-browser-build/commits/bug-32992a
 > >
 >
 >
 > So it seems the issue is that `keyring/xz.gpg` does not contain any key.
 This command outputs nothing:
 > {{{
 > $ gpg --no-default-keyring --keyring keyring/xz.gpg --list-keys
 > }}}
 >
 > And the size of the file is only 32 bytes.

 On my system, I'm seeing

 {{{
 -rw-r--r--   1 shane shane 6513 Mar  1 19:01 xz.gpg
 }}}

 and
 {{{
 $ gpg --no-default-keyring --keyring ./xz.gpg --list-keys
 ./xz.gpg
 
 pub   rsa4096 2010-10-24 [SC] [expires: 2020-12-22]
   3690C240CE51B4670D30AD1C38EE757D69184620
 uid   [ unknown] Lasse Collin 
 sub   rsa4096 2010-10-24 [E] [expires: 2020-12-22]
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32992 [Applications/Tor Browser]: TBB Project for LZMA

[Tor Bug Tracker & Wiki]

#32992: TBB Project for LZMA
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:12 sisbell]:
 > Replying to [comment:10 boklm]:
 > > Replying to [comment:7 sisbell]:
 > >
 > > >
 > > > And then building the project, I get an error
 > > >
 > > > {{{
 > > > Error: v5.2.4 is not a signed tag
 > > > }}}
 > > >
 > > > Any ideas on what is going wrong?
 > > >
 > >
 > > I have no idea what's going wrong. Do you have a branch with the
 changes you tried so I can investigate the issue?
 > I created a branch with the key and config that I was using when I
 encountered the errors. I'll do some more testing as well on this
 >
 > https://github.com/sisbell/tor-browser-build/commits/bug-32992a


 So it seems the issue is that `keyring/xz.gpg` does not contain any key.
 This command outputs nothing:
 {{{
 $ gpg --no-default-keyring --keyring keyring/xz.gpg --list-keys
 }}}

 And the size of the file is only 32 bytes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32992 [Applications/Tor Browser]: TBB Project for LZMA

[Tor Bug Tracker & Wiki]

#32992: TBB Project for LZMA
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:10 boklm]:
 > Replying to [comment:7 sisbell]:
 >
 > >
 > > And then building the project, I get an error
 > >
 > > {{{
 > > Error: v5.2.4 is not a signed tag
 > > }}}
 > >
 > > Any ideas on what is going wrong?
 > >
 >
 > I have no idea what's going wrong. Do you have a branch with the changes
 you tried so I can investigate the issue?
 I created a branch with the key and config that I was using when I
 encountered the errors. I'll do some more testing as well on this

 https://github.com/sisbell/tor-browser-build/commits/bug-32992a

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32992 [Applications/Tor Browser]: TBB Project for LZMA

[Tor Bug Tracker & Wiki]

#32992: TBB Project for LZMA
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by eighthave):

 * cc: hans@… (removed)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32992 [Applications/Tor Browser]: TBB Project for LZMA

[Tor Bug Tracker & Wiki]

#32992: TBB Project for LZMA
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:7 sisbell]:

 >
 > And then building the project, I get an error
 >
 > {{{
 > Error: v5.2.4 is not a signed tag
 > }}}
 >
 > Any ideas on what is going wrong?
 >

 I have no idea what's going wrong. Do you have a branch with the changes
 you tried so I can investigate the issue?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32992 [Applications/Tor Browser]: TBB Project for LZMA

[Tor Bug Tracker & Wiki]

#32992: TBB Project for LZMA
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 No Changes, just broke apart into its own branch

 https://github.com/sisbell/tor-browser-build/commits/bug-32992

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32992 [Applications/Tor Browser]: TBB Project for LZMA

[Tor Bug Tracker & Wiki]

#32992: TBB Project for LZMA
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202002 => tbb-
 mobile, tbb-rbm, TorBrowserTeam202002


Comment:

 No parity involved here, we don't have this on desktop yet, see: #22341.
 For what it's worth ahf over in #22341 suggested back then to start with
 zstd and see how that goes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32992 [Applications/Tor Browser]: TBB Project for LZMA

[Tor Bug Tracker & Wiki]

#32992: TBB Project for LZMA
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 As far as I can tell, it does have a signed tag but I'm unable to verify
 it with rbm build

 From git project for xz

 {{{
 $ git tag -v v5.2.4
 object b5be61cc06088bb07f488f9baf7d447ff47b37c1
 type commit
 tag v5.2.4
 tagger Lasse Collin  1525017879 +0300

 XZ Utils 5.2.4
 gpg: Signature made Sun 29 Apr 2018 09:04:44 AM PDT
 gpg:using RSA key 3690C240CE51B4670D30AD1C38EE757D69184620
 gpg:issuer "lasse.col...@tukaani.org"
 gpg: Good signature from "Lasse Collin "
 [unknown]
 gpg: WARNING: This key is not certified with a trusted signature!
 gpg:  There is no indication that the signature belongs to the
 owner.
 Primary key fingerprint: 3690 C240 CE51 B467 0D30  AD1C 38EE 757D 6918
 4620
 }}}

 I add the following to xz/config

 {{{
 version: 5.2.4
 git_url: https://git.tukaani.org/xz.git
 git_hash: 'v[% c("version") %]'
 tag_gpg_id: 1
 gpg_keyring: xz.gpg
 filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[%
 c("var/build_id") %].tar.gz'
 }}}

 The xz.gpg file has the key

 {{{
 ./xz.gpg
 
 pub   rsa4096 2010-10-24 [SC] [expires: 2020-12-22]
   3690C240CE51B4670D30AD1C38EE757D69184620
 uid   [ unknown] Lasse Collin 
 sub   rsa4096 2010-10-24 [E] [expires: 2020-12-22]
 }}}

 And then building the project, I get an error

 {{{
 Error: v5.2.4 is not a signed tag
 }}}

 Any ideas on what is going wrong?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32992 [Applications/Tor Browser]: TBB Project for LZMA

[Tor Bug Tracker & Wiki]

#32992: TBB Project for LZMA
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * status:  new => needs_revision


Comment:

 Similar to #32991, are there signed git tags available for this?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32992 [Applications/Tor Browser]: TBB Project for LZMA (was: Android Project for LZMA)

[Tor Bug Tracker & Wiki]

#32992: TBB Project for LZMA
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs