Re: [tor-bugs] #33004 [Applications/GetTor]: Modify tests and update README to properly test GetTor locally

[Tor Bug Tracker & Wiki]

#33004: Modify tests and update README to properly test GetTor locally
-+
 Reporter:  cohosh   |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  hiro |Sponsor:
-+
Changes (by cohosh):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged:
 
https://gitweb.torproject.org/gettor.git/commit/?id=4005315b36180649d3d083bc419b2846c33d

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33004 [Applications/GetTor]: Modify tests and update README to properly test GetTor locally

[Tor Bug Tracker & Wiki]

#33004: Modify tests and update README to properly test GetTor locally
-+-
 Reporter:  cohosh   |  Owner:  (none)
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  hiro |Sponsor:
-+-
Changes (by cohosh):

 * status:  needs_review => merge_ready


Comment:

 Thanks hiro!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33004 [Applications/GetTor]: Modify tests and update README to properly test GetTor locally

[Tor Bug Tracker & Wiki]

#33004: Modify tests and update README to properly test GetTor locally
-+--
 Reporter:  cohosh   |  Owner:  (none)
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  hiro |Sponsor:
-+--

Comment (by hiro):

 LGTM

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33004 [Applications/GetTor]: Modify tests and update README to properly test GetTor locally

[Tor Bug Tracker & Wiki]

#33004: Modify tests and update README to properly test GetTor locally
-+--
 Reporter:  cohosh   |  Owner:  (none)
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  hiro |Sponsor:
-+--
Changes (by cohosh):

 * status:  needs_revision => needs_review


Comment:

 Whoops wrong status

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33004 [Applications/GetTor]: Modify tests and update README to properly test GetTor locally

[Tor Bug Tracker & Wiki]

#33004: Modify tests and update README to properly test GetTor locally
-+
 Reporter:  cohosh   |  Owner:  (none)
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  hiro |Sponsor:
-+
Changes (by cohosh):

 * reviewer:  phw, hiro => hiro


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33004 [Applications/GetTor]: Modify tests and update README to properly test GetTor locally

[Tor Bug Tracker & Wiki]

#33004: Modify tests and update README to properly test GetTor locally
-+
 Reporter:  cohosh   |  Owner:  (none)
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  phw, hiro|Sponsor:
-+
Changes (by cohosh):

 * status:  new => needs_revision
 * reviewer:   => phw, hiro


Comment:

 I've added a few commits to clean up the current tests so that they run on
 developer machines:
 https://dip.torproject.org/cohosh/gettor/compare/master...ticket%2F33004

 In particular, these commits:
 - create a database in the testing directory for testing purposes
 - use a test config file instead of a hardcoded file that doesn't exist
 outside of the deployment machine
 - avoid doing any tests that require knowledge of secrets, such as twitter
 auth keys
 - Fix some minor bugs/edge cases

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs