Re: [tor-bugs] #33206 [Metrics/Library]: Parse recently added lines

[Tor Bug Tracker & Wiki]

#33206: Parse recently added lines
-+---
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Metrics/Library  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+---
Changes (by karsten):

 * status:  assigned => needs_information


Comment:

 Putting this on hold until #33205 is reviewed and merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33206 [Metrics/Library]: Parse recently added lines

[Tor Bug Tracker & Wiki]

#33206: Parse recently added lines
-+--
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Library  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:  1
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  needs_information => needs_review
 * actualpoints:   => 1


Comment:

 With #33205 out of the way, please review
 [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/commit/?h=task-33206&id=81570c4dbc097089f367c104c7ef5a77bee29763
 commit 81570c4 in my task-33206 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33206 [Metrics/Library]: Parse recently added lines

[Tor Bug Tracker & Wiki]

#33206: Parse recently added lines
-+-
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Metrics/Library  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:  1
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 All looks good to me, except that we're adding more SortedSet which
 inevitably will be TreeSet which are not serializable, but that's a
 problem for another day.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33206 [Metrics/Library]: Parse recently added lines

[Tor Bug Tracker & Wiki]

#33206: Parse recently added lines
-+-
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Library  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:  1
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 It's indeed a `TreeSet`, but yes, let's discuss serialization issues
 another day. We can still change the internal data structure for
 serialization reasons and convert that data structure to a `SortedSet`
 when the user asks for that. Yay, encapsulation.

 Cool, merged to master and closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs