Re: [tor-bugs] #34024 [Metrics/Onionperf]: Reduce timeout and stallout values

[Tor Bug Tracker & Wiki]

#34024: Reduce timeout and stallout values
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:  implemented
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.2
Parent ID:  #33321 | Points:  1
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => implemented
 * actualpoints:  0.1 => 0.2


Comment:

 Thanks for the review! Pushed to master, adding my 0.1 actual points, and
 closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34024 [Metrics/Onionperf]: Reduce timeout and stallout values

[Tor Bug Tracker & Wiki]

#34024: Reduce timeout and stallout values
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  merge_ready
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.1
Parent ID:  #33321 | Points:  1
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+
Changes (by acute):

 * status:  needs_review => merge_ready
 * reviewer:   => acute
 * actualpoints:   => 0.1


Comment:

 The commit looks good and the transfer behaviour is as expected.
 Adding 0.1 actual points and changing to merge_ready.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34024 [Metrics/Onionperf]: Reduce timeout and stallout values

[Tor Bug Tracker & Wiki]

#34024: Reduce timeout and stallout values
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321 | Points:  1
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  accepted => needs_review
 * cc: metrics-team (added)


Comment:

 Please review
 
[https://gitweb.torproject.org/user/karsten/onionperf.git/commit/?h=tasks-33434-34024-and-34023=3e79f084dfa918e06695a12106672740478a4c79
 commit 3e79f08 in my tasks-33434-34024-and-34023 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34024 [Metrics/Onionperf]: Reduce timeout and stallout values

[Tor Bug Tracker & Wiki]

#34024: Reduce timeout and stallout values
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  accepted
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321 | Points:  1
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  needs_review => accepted
 * owner:  metrics-team => karsten


Comment:

 We discussed this at the weekly team meeting on Thursday and agreed that
 this is an improvement and that we're going to do it. I'm working on a
 patch now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34024 [Metrics/Onionperf]: Reduce timeout and stallout values

[Tor Bug Tracker & Wiki]

#34024: Reduce timeout and stallout values
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  new => needs_review


Comment:

 I looked at measurements made by op-hk2, op-nl2, and op-us2 in the first
 half of May 2020. I wanted to get an idea how many of the 5 MiB
 measurements would have timed out with a timeout of 270 rather than 3600
 seconds. The result was: ''zero''. For comparison, there have been 1,027
 successful 5 MiB measurements in that time, and the slowest four have
 finished in 201 seconds, 186 seconds, 142 seconds, and 128 seconds. And
 while it's conceivable that we would find a non-zero number in other half
 months of measurements, their number will very likely be really small.

 Similar to #34023, let's discuss how to proceed here. My recommendation is
 that we:

  1. use a timeout of 270 seconds for all measurements to avoid overlapping
 measurements and

  2. set the stallout value to 0 to disable the stallout function in TGen.

 More on Thursday at the weekly meeting.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34024 [Metrics/Onionperf]: Reduce timeout and stallout values

[Tor Bug Tracker & Wiki]

#34024: Reduce timeout and stallout values
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by jnewsome):

 * cc: jnewsome (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34024 [Metrics/Onionperf]: Reduce timeout and stallout values

[Tor Bug Tracker & Wiki]

#34024: Reduce timeout and stallout values
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:  Sponsor59
---+--
Changes (by gaba):

 * keywords:   => metrics-team-roadmap-2020
 * points:   => 1
 * sponsor:   => Sponsor59


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34024 [Metrics/Onionperf]: Reduce timeout and stallout values

[Tor Bug Tracker & Wiki]

#34024: Reduce timeout and stallout values
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by karsten):

 Ah, that makes sense. Thanks for the explanation!

 However, I'm going to deploy the three new OnionPerf instances without
 changing weights or timeouts and leave them running for a while to see
 whether results are different from currently running instances. If they
 are not, we'll learn that something in the setup was different, and it
 would be good to keep the number of changes as small as possible. Coming
 back to this in May. Thanks for all the great input so far!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34024 [Metrics/Onionperf]: Reduce timeout and stallout values

[Tor Bug Tracker & Wiki]

#34024: Reduce timeout and stallout values
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by robgjansen):

 In TGen, timeouts are absolute times; the timer starts when the download
 starts, and it counts as an error if it is not completed by the configured
 number of seconds. Stallouts are configured as inter-byte-receive time,
 and only result in a stallout error if the last byte you received was >=
 the configured stallout time. (So if you set a stallout of 10 seconds, and
 you get at least 1 byte every second, the stallout error will not get
 triggered.)

 It seems like you always want to give each download attempt the same
 amount of absolute time (i.e., timeout), and so I think you should disable
 the stallout by setting it to 0 (otherwise an internal default of 30
 seconds is used).

 https://github.com/shadow/tgen/blob/master/doc/TGen-Options.md#stream-
 options

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs