[tor-commits] [tor/master] Fix compiler warning about signed/unsigned conversion.

[nickm]

commit 80da1761a624686e25223b64f5832eab9249568b
Author: George Kadianakis <desnac...@riseup.net>
Date:   Wed Mar 17 20:03:39 2021 +0200

    Fix compiler warning about signed/unsigned conversion.
    
    ```
    src/feature/stats/rephist.c: In function ‘overload_happened_recently’:
    src/feature/stats/rephist.c:215:21: error: comparison between signed and 
unsigned integer expressions [-Werror=sign-compare]
       if (overload_time > approx_time() - 3600 * n_hours) {
    ```
    from https://gitlab.torproject.org/tpo/core/tor/-/issues/40341#note_2729364
---
 src/feature/stats/rephist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/feature/stats/rephist.c b/src/feature/stats/rephist.c
index fb97e0d255..7c0c28804c 100644
--- a/src/feature/stats/rephist.c
+++ b/src/feature/stats/rephist.c
@@ -209,7 +209,7 @@ static overload_stats_t overload_stats;
 
 /** Return true if this overload happened within the last `n_hours`. */
 static bool
-overload_happened_recently(time_t overload_time, unsigned n_hours)
+overload_happened_recently(time_t overload_time, int n_hours)
 {
   /* An overload is relevant if it happened in the last 72 hours */
   if (overload_time > approx_time() - 3600 * n_hours) {


_______________________________________________
tor-commits mailing list
tor-commits@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits