[tor-dev] Adding one more (optional) step to Trac's ticket work-flow
Hello tor-dev! tl;dr; we want to add one more step to Trac ticket work-flow called 'merge_ready' - if you don't want to use it you don't need to During Tor's Dev Meeting in Valencia, the Network Team discussed a code review process[1] for the team and we concluded that for us a two stage review process would make things much better for the team. In order to organize that on our ticket work-flow on Trac, we decided to add the step 'merge_ready'[2] that would come after either 'needs_review' or 'needs_revision' steps. For our team, what that will mean is that we have reviewed the code and believe is ready for Nick to do a second review and merge. The first review will remove load from Nick and we want to eventually have more folks helping Nick on the second review as well. But this change alone will be already a big step. What does that means for someone working on a ticket that is not part of Core Tor development flow? Well, if you don't want to use it in your team or your project flow, you can just ignore it and keep using Trac as normal. We are sending this note to make sure folks knows about it before it happens and of course, to hear any concerns or feedback. Cheers, Isabela [1] https://trac.torproject.org/projects/tor/wiki/org/meetings/2016WinterDevMeeting/Notes/CodeReviews [2] https://storm.torproject.org/shared/pt9FtdJNG_gB_afqayg9dXTJwdDFncgU0HVXJEqmOSr -- PM at TorProject.org gpg fingerprint = 8F2A F9B6 D4A1 4D03 FDF1 B298 3224 4994 1506 4C7B @isa ___ tor-dev mailing list tor-dev@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev
Re: [tor-dev] [::]/8 is marked as private network, why?
> On 29 Mar 2016, at 23:49, Tom Ritter wrote: > > On 29 March 2016 at 02:29, Sebastian Hahn wrote: >> I've been wondering about the private_nets const in src/or/policies. It >> was added in a96c0affcb4cda1a2e0d83d123993d10efc6e396 but Nick doesn't >> remember why, and I'm hoping someone has an idea (maybe teor, who I've >> CCed here, who documented this in a later commit?). If nobody knows why >> we do this I think we should remove it as likely incorrect. > > ::/8 is Reserved by the IETF, it is (a superset of) the deprecated > space for "IPv4 Compatible IPv6 Addresses". The addresses are not to > be reassigned for any other purposes. > > Authoritative source: > http://www.iana.org/assignments/ipv6-address-space/ipv6-address-space.xhtml > > I'm not necessarily sure what private networks are all used for in > Tor, but maybe this explains it and makes sense? /** Private networks. This list is used in two places, once to expand the * "private" keyword when parsing our own exit policy, secondly to ignore * just such networks when building exit policy summaries. It is important * that all authorities agree on that list when creating summaries, so don't * just change this without a proper migration plan and a proposal and stuff. */ So I think we should keep [::]/8 in the list of private addresses. That said, the list of IPv4 and IPv6 private addresses in tor is incomplete, and could be updated based on [0] [1] for IPv6, and [2] for IPv4 ([3] seems to have too much information to be useful). If we want to update it, we should consider: private_nets tor_addr_is_internal (any other checks?) We would need to write a proposal - at the very least, it would need a new consensus method, and some discussion of what happens when clients and exits disagree on the definition of what's private and what's not. I don't think it's something I'll have time for, but if anyone else wants to guide us through the process, I'd be happy to support it and review code. Tim [0]: https://www.iana.org/assignments/ipv6-address-space/ipv6-address-space.xhtml [1]: https://www.iana.org/assignments/iana-ipv6-special-registry/iana-ipv6-special-registry.xhtml [2]: https://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-special-registry.xhtml [3]: https://www.iana.org/assignments/ipv4-address-space/ipv4-address-space.xhtml Tim Wilson-Brown (teor) teor2345 at gmail dot com PGP 968F094B teor at blah dot im OTR CAD08081 9755866D 89E2A06F E3558B7F B5A9D14F signature.asc Description: Message signed with OpenPGP using GPGMail ___ tor-dev mailing list tor-dev@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev
Re: [tor-dev] [::]/8 is marked as private network, why?
On 29 March 2016 at 02:29, Sebastian Hahn wrote: > I've been wondering about the private_nets const in src/or/policies. It > was added in a96c0affcb4cda1a2e0d83d123993d10efc6e396 but Nick doesn't > remember why, and I'm hoping someone has an idea (maybe teor, who I've > CCed here, who documented this in a later commit?). If nobody knows why > we do this I think we should remove it as likely incorrect. ::/8 is Reserved by the IETF, it is (a superset of) the deprecated space for "IPv4 Compatible IPv6 Addresses". The addresses are not to be reassigned for any other purposes. Authoritative source: http://www.iana.org/assignments/ipv6-address-space/ipv6-address-space.xhtml I'm not necessarily sure what private networks are all used for in Tor, but maybe this explains it and makes sense? -tom ___ tor-dev mailing list tor-dev@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev
Re: [tor-dev] Request for feedback/victims: cfc-0.0.2
On Tue, 29 Mar 2016 10:09:15 +0200 Jens Kubieziel wrote: > * Yawning Angel schrieb am 2016-03-27 um 08:12 Uhr: > >* (QoL) Skip useless landing pages (github.com/twitter.com will > > be auto-redirected to the "search" pages). > > When you're logged into Twitter, https://twitter.com/ shows you your > stream of tweets. With the current version, a user can't see its own > stream anymore. Can you redirect to the search page only for > non-logged-in users? Probably since I should be able to see that you're logged in based on the request made (I never used twitter.com to view my own stream, just went to twitter.com/blahblahblah). That said, debugging/implementing something like that requires a twitter account, which I don't have anymore (Nuked because it's a waste of time, horrible medium, etc). For now, this feature can be disabled from the addon preferences. Regards, -- Yawning Angel pgpoB0_DxwzqR.pgp Description: OpenPGP digital signature ___ tor-dev mailing list tor-dev@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev
Re: [tor-dev] Request for feedback/victims: cfc-0.0.2
* Yawning Angel schrieb am 2016-03-27 um 08:12 Uhr: >* (QoL) Skip useless landing pages (github.com/twitter.com will be > auto-redirected to the "search" pages). When you're logged into Twitter, https://twitter.com/ shows you your stream of tweets. With the current version, a user can't see its own stream anymore. Can you redirect to the search page only for non-logged-in users? -- Jens Kubieziel http://www.kubieziel.de 21 ist nur die halbe Wahrheit signature.asc Description: Digital signature ___ tor-dev mailing list tor-dev@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev
[tor-dev] [::]/8 is marked as private network, why?
Hey, I've been wondering about the private_nets const in src/or/policies. It was added in a96c0affcb4cda1a2e0d83d123993d10efc6e396 but Nick doesn't remember why, and I'm hoping someone has an idea (maybe teor, who I've CCed here, who documented this in a later commit?). If nobody knows why we do this I think we should remove it as likely incorrect. Cheers and thanks Sebastian ___ tor-dev mailing list tor-dev@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev
