Re: [tor-relays] interesting tor platform string or tor bug?
> On 11 Jul 2016, at 16:27, 김성민 wrote:
>
> Hi, I'm Ph.D. Student in KAIST, South Korea.
> I'm implementing a modified Tor on top of Intel SGX CPU to improve the
> security issues of Tor as a research.
> (Here is a related paper work [1, 2].)
> For this, we port the Tor source code on the VS2012 to build an SGX project.
> To make Tor running on top of SGX, we modified several lines of code of Tor
> and I think there is some mistake while printing a platform string.
Tor shouldn't produce output like the output we're seeing, unless the platform
name retrieved by tor has been localised.
(Which seems unlikely, as the platform name is reported correctly some times,
and incorrectly other times.)
What do you get if you compile a simple program that only contains the function
that retrieves the Windows platform name?
It looks like you might be corrupting memory or mangling string processing.
But it's very hard to help you unless we know what lines of code you changed,
and how you changed them.
> Currently, We successfully compiled a SGX-Tor binary and we ran it as a Tor
> relay for testing compatibility with existing Tor network.
> We tested a Tor client with our SGX-Tor and it successfully works.
> Is there any issues or rules to be considered for testing our SGX-Tor?
It should pass all the unit tests run using "make check".
It should pass the integration tests run using chutney and "make
test-network-all".
https://gitweb.torproject.org/chutney.git/
If you do find that it's a programming error in tor, feel free to submit a
patch, or a unit test that would catch similar errors in the platform string.
https://trac.torproject.org/projects/tor
Tim
>
> Thanks,
> Seongmin
>
> [1] http://ina.kaist.ac.kr/~dongsuh/paper/kim-hotnets2015.pdf
> [2] http://ina.kaist.ac.kr/~dongsuh/paper/opensgx.pdf
>
> 2016-07-08 9:07 GMT+09:00 Tim Wilson-Brown - teor :
>
> > On 8 Jul 2016, at 09:48, Tim Wilson-Brown - teor wrote:
> >
> >
> >> On 8 Jul 2016, at 09:41, nusenu wrote:
> >>
> >> Hi Seongmin,
> >>
> >> out of curiosity I was wondering whether your so called tor "platform"
> >> string ("??B`?\u0001") or your tor relay [1] was generated by a modified
> >> tor installation on Windows 8 or if we are looking at some bug in
> >> vanilla tor?
> >
> > We plan on authorities rejecting descriptors with non-ASCII characters in
> > 0.2.9, if we get it implemented before the code freeze.
> > https://trac.torproject.org/projects/tor/ticket/18938
>
> Hmm, I can't find an actual descriptor with these characters in it. The
> latest descriptor I can find for this relay has a normal platform line:
> https://collector.torproject.org/recent/relay-descriptors/server-descriptors/2016-07-06-06-05-14-server-descriptors
>
> Could this be a bug in Atlas?
>
> >
> >>
> >> thanks!
> >>
> >>
> >> [1]
> >> https://atlas.torproject.org/#details/21E84B294794821E2898E8ED18402E45E4FC351E
> >>
> >> descriptor containing that platform string:
> >> https://collector.torproject.org/recent/relay-descriptors/server-descriptors/2016-07-07-06-05-14-server-descriptors
> >>
> >> ___
> >> tor-relays mailing list
> >> tor-relays@lists.torproject.org
> >> https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays
> >
> > Tim Wilson-Brown (teor)
> >
> > teor2345 at gmail dot com
> > PGP C855 6CED 5D90 A0C5 29F6 4D43 450C BA7F 968F 094B
> > ricochet:ekmygaiu4rzgsk6n
> >
> >
> >
> >
>
> Tim Wilson-Brown (teor)
>
> teor2345 at gmail dot com
> PGP C855 6CED 5D90 A0C5 29F6 4D43 450C BA7F 968F 094B
> ricochet:ekmygaiu4rzgsk6n
>
>
>
>
>
Tim Wilson-Brown (teor)
teor2345 at gmail dot com
PGP C855 6CED 5D90 A0C5 29F6 4D43 450C BA7F 968F 094B
OTR 8F39BCAC 9C9DDF9A DF5FAE48 1D7D99D4 3B406880
ricochet:ekmygaiu4rzgsk6n
signature.asc
Description: Message signed with OpenPGP using GPGMail
___
tor-relays mailing list
tor-relays@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays
Re: [tor-relays] interesting tor platform string or tor bug?
nusenu: > Yes, both relays on that IP (same ORPort), changed from "Tor 0.2.7.6 > on Windows 8" to that non-ASCII string (that is why I knew he is > probably running Windows 8). Can this be undefined behavior of GetVersionEx() on Windows 10? (I'm not able to verify this) GetVersionEx() has been deprecated since Win8.1 [1]: > With the release of Windows 8.1, the behavior of the GetVersionEx API > has changed in the value it will return for the operating system > version. The value returned by the GetVersionEx function now depends > on how the application is manifested. And tor still use it [2] on all Windows versions. Maybe this version of tor is built from source and manifested for Windows 10 (by auto)? I can't see anything related to 'manifestation' in Tor's build scripts for Windows, so I guess that official binaries are not manifested for Win8.1 or Win10 and detect Win10 as 6.2 (Win8). [1] https://msdn.microsoft.com/en-us/library/windows/desktop/ms724451%28v=vs.85%29.aspx [2] https://gitweb.torproject.org/tor.git/tree/src/common/compat.c#n2711 -- Ivan Markin ___ tor-relays mailing list tor-relays@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays
Re: [tor-relays] interesting tor platform string or tor bug?
Tim Wilson-Brown - teor: > We plan on authorities rejecting descriptors with non-ASCII > characters in 0.2.9, if we get it implemented before the code > freeze. https://trac.torproject.org/projects/tor/ticket/18938 I created a related onionoo feature request https://trac.torproject.org/projects/tor/ticket/19650 signature.asc Description: OpenPGP digital signature ___ tor-relays mailing list tor-relays@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays
Re: [tor-relays] interesting tor platform string or tor bug?
>> We plan on authorities rejecting descriptors with non-ASCII >> characters in 0.2.9, if we get it implemented before the code >> freeze. https://trac.torproject.org/projects/tor/ticket/18938 Glad to hear that. > Hmm, I can't find an actual descriptor with these characters in it. > The latest descriptor I can find for this relay has a normal platform > line: > https://collector.torproject.org/recent/relay-descriptors/server-descriptors/2016-07-06-06-05-14-server-descriptors > > Could this be a bug in Atlas? I ruled that out by lookup up the descriptor. It took me a while to find that descriptor on collector that is why I linked it in my last email: >>> descriptor containing that platform string: >>> https://collector.torproject.org/recent/relay-descriptors/server-descriptors/2016-07-07-06-05-14-server-descriptors @type server-descriptor 1.0 router inaTor 143.248.56.14 9001 0 0 identity-ed25519 -BEGIN ED25519 CERT- AQQABjt2AV0rPf8QKymuUxOZk47xwv+Kw4jsZfj1Uf9wcObZInKOAQAgBABec03t qU4n3KnBE6x6IQ0LL+kLO7scyHWWJmml1vBS6mh/swglXcnfoBkMN3hYTOrzRLwV uVuaDR9zGlKIN66tZVSUjdac5tSa2YUUn2bKibLEjyVPeWXe7kMBSPmeVAs= -END ED25519 CERT- master-key-ed25519 XnNN7alOJ9ypwROseiENCy/pCzu7HMh1liZppdbwUuo platform ¨ÛB`Ÿ protocols Link 1 2 Circuit 1 published 2016-07-07 05:50:30 fingerprint 21E8 4B29 4794 821E 2898 E8ED 1840 2E45 E4FC 351E uptime 218 bandwidth 1048576 1048576 52224 note: the timestamps 07-06 vs 07-06 (relevant descriptor never ended up in a consensus entry, last seen vs. last restarted) > Actually, I should probably say that there are *other* descriptors > from inaTor, which say > """ > platform Tor 0.2.7.6 on Windows 8 > """ > i.e. a totally normal platform string. > > So it looks like a Tor bug -- and a memory corruption one at that. Yes, both relays on that IP (same ORPort), changed from "Tor 0.2.7.6 on Windows 8" to that non-ASCII string (that is why I knew he is probably running Windows 8). signature.asc Description: OpenPGP digital signature ___ tor-relays mailing list tor-relays@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays
Re: [tor-relays] interesting tor platform string or tor bug?
On Thu, Jul 07, 2016 at 08:14:45PM -0400, Roger Dingledine wrote: > > Could this be a bug in Atlas? > > Not a bug in atlas -- I see an actual descriptor in moria1's cache from > inaTor which has these funny symbols in its platform string. Actually, I should probably say that there are *other* descriptors from inaTor, which say """ platform Tor 0.2.7.6 on Windows 8 """ i.e. a totally normal platform string. So it looks like a Tor bug -- and a memory corruption one at that. --Roger ___ tor-relays mailing list tor-relays@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays
Re: [tor-relays] interesting tor platform string or tor bug?
Tim Wilson-Brown - teor: > Hmm, I can't find an actual descriptor with these characters in it. The > latest descriptor I can find for this relay has a normal platform line: > https://collector.torproject.org/recent/relay-descriptors/server-descriptors/2016-07-06-06-05-14-server-descriptors > > Could this be a bug in Atlas? Nope, Onionoo returns the same platform line [1]. [1] https://onionoo.torproject.org/details?lookup=7A9A7CD200D288DD7D78542779DE16070BC8BFFD -- Ivan Markin ___ tor-relays mailing list tor-relays@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays
Re: [tor-relays] interesting tor platform string or tor bug?
On Fri, Jul 08, 2016 at 10:07:56AM +1000, Tim Wilson-Brown - teor wrote: > Hmm, I can't find an actual descriptor with these characters in it. The > latest descriptor I can find for this relay has a normal platform line: > https://collector.torproject.org/recent/relay-descriptors/server-descriptors/2016-07-06-06-05-14-server-descriptors > > Could this be a bug in Atlas? Not a bug in atlas -- I see an actual descriptor in moria1's cache from inaTor which has these funny symbols in its platform string. --Roger ___ tor-relays mailing list tor-relays@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays
Re: [tor-relays] interesting tor platform string or tor bug?
> On 8 Jul 2016, at 09:48, Tim Wilson-Brown - teor wrote:
>
>
>> On 8 Jul 2016, at 09:41, nusenu wrote:
>>
>> Hi Seongmin,
>>
>> out of curiosity I was wondering whether your so called tor "platform"
>> string ("??B`?\u0001") or your tor relay [1] was generated by a modified
>> tor installation on Windows 8 or if we are looking at some bug in
>> vanilla tor?
>
> We plan on authorities rejecting descriptors with non-ASCII characters in
> 0.2.9, if we get it implemented before the code freeze.
> https://trac.torproject.org/projects/tor/ticket/18938
Hmm, I can't find an actual descriptor with these characters in it. The latest
descriptor I can find for this relay has a normal platform line:
https://collector.torproject.org/recent/relay-descriptors/server-descriptors/2016-07-06-06-05-14-server-descriptors
Could this be a bug in Atlas?
>
>>
>> thanks!
>>
>>
>> [1]
>> https://atlas.torproject.org/#details/21E84B294794821E2898E8ED18402E45E4FC351E
>>
>> descriptor containing that platform string:
>> https://collector.torproject.org/recent/relay-descriptors/server-descriptors/2016-07-07-06-05-14-server-descriptors
>>
>> ___
>> tor-relays mailing list
>> tor-relays@lists.torproject.org
>> https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays
>
> Tim Wilson-Brown (teor)
>
> teor2345 at gmail dot com
> PGP C855 6CED 5D90 A0C5 29F6 4D43 450C BA7F 968F 094B
> ricochet:ekmygaiu4rzgsk6n
>
>
>
>
Tim Wilson-Brown (teor)
teor2345 at gmail dot com
PGP C855 6CED 5D90 A0C5 29F6 4D43 450C BA7F 968F 094B
ricochet:ekmygaiu4rzgsk6n
signature.asc
Description: Message signed with OpenPGP using GPGMail
___
tor-relays mailing list
tor-relays@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays
Re: [tor-relays] interesting tor platform string or tor bug?
> On 8 Jul 2016, at 09:41, nusenu wrote:
>
> Hi Seongmin,
>
> out of curiosity I was wondering whether your so called tor "platform"
> string ("??B`?\u0001") or your tor relay [1] was generated by a modified
> tor installation on Windows 8 or if we are looking at some bug in
> vanilla tor?
We plan on authorities rejecting descriptors with non-ASCII characters in
0.2.9, if we get it implemented before the code freeze.
https://trac.torproject.org/projects/tor/ticket/18938
>
> thanks!
>
>
> [1]
> https://atlas.torproject.org/#details/21E84B294794821E2898E8ED18402E45E4FC351E
>
> descriptor containing that platform string:
> https://collector.torproject.org/recent/relay-descriptors/server-descriptors/2016-07-07-06-05-14-server-descriptors
>
> ___
> tor-relays mailing list
> tor-relays@lists.torproject.org
> https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays
Tim Wilson-Brown (teor)
teor2345 at gmail dot com
PGP C855 6CED 5D90 A0C5 29F6 4D43 450C BA7F 968F 094B
ricochet:ekmygaiu4rzgsk6n
signature.asc
Description: Message signed with OpenPGP using GPGMail
___
tor-relays mailing list
tor-relays@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays
[tor-relays] interesting tor platform string or tor bug?
Hi Seongmin,
out of curiosity I was wondering whether your so called tor "platform"
string ("??B`?\u0001") or your tor relay [1] was generated by a modified
tor installation on Windows 8 or if we are looking at some bug in
vanilla tor?
thanks!
[1]
https://atlas.torproject.org/#details/21E84B294794821E2898E8ED18402E45E4FC351E
descriptor containing that platform string:
https://collector.torproject.org/recent/relay-descriptors/server-descriptors/2016-07-07-06-05-14-server-descriptors
signature.asc
Description: OpenPGP digital signature
___
tor-relays mailing list
tor-relays@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays
