[Touch-packages] [Bug 1269177] Re: Running 'unattended-upgrades --dry-run' reboots the machine
A new version from xenial-proposed fixes the issue for me. -- root@ubuntu:~# dpkg -l unattended-upgrades Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Architecture Description +++--=-=-== ii unattended-upgrades 0.90ubuntu0.9 all automatic installation of security upgrades root@ubuntu:~# touch /var/run/reboot-required root@ubuntu:~# unattended-upgrades --dry-run root@ubuntu:~# (reboot does not happen) ** Tags removed: verification-needed-xenial ** Tags added: verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unattended-upgrades in Ubuntu. https://bugs.launchpad.net/bugs/1269177 Title: Running 'unattended-upgrades --dry-run' reboots the machine Status in unattended-upgrades package in Ubuntu: Fix Released Status in unattended-upgrades source package in Xenial: Fix Committed Status in unattended-upgrades source package in Zesty: Fix Committed Status in unattended-upgrades source package in Artful: Fix Committed Status in unattended-upgrades source package in Bionic: Fix Released Bug description: Impact -- An Ubuntu system will unexpectedly reboot if reboot-required exists and you run unattended-upgrades in dry-run mode. Test Case - 1) modify /etc/apt/apt.conf.d/50unattended-upgrades so that Automatic-Reboot is true 2) Ensure all updates are installed 3) sudo touch /var/run/reboot-required 4) run 'sudo unattended-upgrades --dry-run' 5) watch the system reboot With the version of unattended-upgrades from -proposed the system will not reboot. Regression Potential This checks to see if the --dry-run switch is passed to unattended-upgrades before calling the reboot function. I guess it would be a regression to people who expect the system to reboot but that seems like a very strange corner case. Original Description Much to my surprise, when I did a dry-run test of unattended-upgrades my server was forcibly rebooted. I must have had the file '/var/run/reboot-required' present. But needless to say: a --dry-run should NOT perform a reboot of the server with zero warning. Seriously. Output from /var/log/unattended-upgrades.log 2014-01-15 11:14:26,474 INFO Initial blacklisted packages: 2014-01-15 11:14:26,474 INFO Starting unattended upgrades script 2014-01-15 11:14:26,475 INFO Allowed origins are: ['o=Ubuntu,a=precise-security'] 2014-01-15 11:14:35,846 INFO Option --dry-run given, *not* performing real actions 2014-01-15 11:14:35,846 INFO Packages that are upgraded: bind9-host dnsutils libbind9-80 libdns81 libisc83 libisccc80 libisccfg82 liblwres80 libssl1.0.0 linux-generic-pae linux-headers-generic-pae linux-image-generic-pae linux-libc-dev openssl 2014-01-15 11:14:35,847 INFO Writing dpkg log to '/var/log/unattended-upgrades/unattended-upgrades-dpkg_2014-01-15_11:14:35.846820.log' 2014-01-15 11:15:10,610 INFO All upgrades installed 2014-01-15 11:15:10,611 WARNING Found /var/run/reboot-required, rebooting Version: 0.76ubuntu1 As an aside, it makes a lot of sense to me to put the reboot on a timer, even if it's only a one minute (i.e. shutdown -r 1). That would have at least given me a chance to prevent the reboot if I had seen the warning. If that's a configuration setting I don't see it anywhere. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1269177/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1269177] Re: Running 'unattended-upgrades --dry-run' reboots the machine
I was able to reproduce it in a freshly installed VM (VMware).
--
root@ubuntu:~# egrep -v '(^\s*//.*$|^\s*$)'
/etc/apt/apt.conf.d/50unattended-upgrades
Unattended-Upgrade::Allowed-Origins {
"${distro_id}:${distro_codename}";
"${distro_id}:${distro_codename}-security";
"${distro_id}ESM:${distro_codename}";
};
Unattended-Upgrade::Package-Blacklist {
};
Unattended-Upgrade::Automatic-Reboot "true";
root@ubuntu:~# uname -a
Linux ubuntu 4.4.0-104-generic #127-Ubuntu SMP Mon Dec 11 12:16:42 UTC 2017
x86_64 x86_64 x86_64 GNU/Linux
root@ubuntu:~# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:Ubuntu 16.04.3 LTS
Release:16.04
Codename: xenial
root@ubuntu:~# apt-get update && apt-get dist-upgrade -y
Get:1 http://security.ubuntu.com/ubuntu xenial-security InRelease [102 kB]
Hit:2 http://us.archive.ubuntu.com/ubuntu xenial InRelease
Get:3 http://us.archive.ubuntu.com/ubuntu xenial-updates InRelease [102 kB]
Get:4 http://us.archive.ubuntu.com/ubuntu xenial-backports InRelease [102 kB]
Fetched 306 kB in 2s (146 kB/s)
Reading package lists... Done
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
root@ubuntu:~# file /var/run/reboot-required
/var/run/reboot-required: cannot open `/var/run/reboot-required' (No such file
or directory)
root@ubuntu:~# touch /var/run/reboot-required
root@ubuntu:~# unattended-upgrades --dry-run
(ssh disconnects, system reboots)
root@ubuntu:~# cat /var/log/unattended-upgrades/unattended-upgrades.log
2017-12-16 09:59:17,772 INFO Initial blacklisted packages:
2017-12-16 09:59:17,773 INFO Initial whitelisted packages:
2017-12-16 09:59:17,773 INFO Starting unattended upgrades script
2017-12-16 09:59:17,773 INFO Allowed origins are: ['o=Ubuntu,a=xenial',
'o=Ubuntu,a=xenial-security', 'o=UbuntuESM,a=xenial']
2017-12-16 09:59:21,610 INFO No packages found that can be upgraded unattended
and no pending auto-removals
2017-12-16 09:59:21,611 WARNING Found /var/run/reboot-required, rebooting
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to unattended-upgrades in
Ubuntu.
https://bugs.launchpad.net/bugs/1269177
Title:
Running 'unattended-upgrades --dry-run' reboots the machine
Status in unattended-upgrades package in Ubuntu:
Fix Released
Bug description:
Much to my surprise, when I did a dry-run test of unattended-upgrades
my server was forcibly rebooted. I must have had the file '/var/run
/reboot-required' present.
But needless to say: a --dry-run should NOT perform a reboot of the
server with zero warning. Seriously.
Output from /var/log/unattended-upgrades.log
2014-01-15 11:14:26,474 INFO Initial blacklisted packages:
2014-01-15 11:14:26,474 INFO Starting unattended upgrades script
2014-01-15 11:14:26,475 INFO Allowed origins are:
['o=Ubuntu,a=precise-security']
2014-01-15 11:14:35,846 INFO Option --dry-run given, *not* performing real
actions
2014-01-15 11:14:35,846 INFO Packages that are upgraded: bind9-host dnsutils
libbind9-80 libdns81 libisc83 libisccc80 libisccfg82 liblwres80 libssl1.0.0
linux-generic-pae linux-headers-generic-pae linux-image-generic-pae
linux-libc-dev openssl
2014-01-15 11:14:35,847 INFO Writing dpkg log to
'/var/log/unattended-upgrades/unattended-upgrades-dpkg_2014-01-15_11:14:35.846820.log'
2014-01-15 11:15:10,610 INFO All upgrades installed
2014-01-15 11:15:10,611 WARNING Found /var/run/reboot-required, rebooting
Version: 0.76ubuntu1
As an aside, it makes a lot of sense to me to put the reboot on a
timer, even if it's only a one minute (i.e. shutdown -r 1). That would
have at least given me a chance to prevent the reboot if I had seen
the warning. If that's a configuration setting I don't see it
anywhere.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1269177/+subscriptions
--
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1269177] Re: Running 'unattended-upgrades --dry-run' reboots the machine
The bug is still reproducible in xenial. -- # lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 16.04.3 LTS Release:16.04 Codename: xenial # grep Automatic-Reboot /etc/apt/apt.conf.d/50unattended-upgrades Unattended-Upgrade::Automatic-Reboot "true"; //Unattended-Upgrade::Automatic-Reboot-Time "02:00"; # dpkg -l unattended-upgrades Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ NameVersion Architecture Description +++-===-==-==-=== ii unattended-upgrades 0.90ubuntu0.8 all automatic installation of security upgrades # touch /var/run/reboot-required # unattended-upgrades --dry-run (System reboots) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unattended-upgrades in Ubuntu. https://bugs.launchpad.net/bugs/1269177 Title: Running 'unattended-upgrades --dry-run' reboots the machine Status in unattended-upgrades package in Ubuntu: Fix Released Bug description: Much to my surprise, when I did a dry-run test of unattended-upgrades my server was forcibly rebooted. I must have had the file '/var/run /reboot-required' present. But needless to say: a --dry-run should NOT perform a reboot of the server with zero warning. Seriously. Output from /var/log/unattended-upgrades.log 2014-01-15 11:14:26,474 INFO Initial blacklisted packages: 2014-01-15 11:14:26,474 INFO Starting unattended upgrades script 2014-01-15 11:14:26,475 INFO Allowed origins are: ['o=Ubuntu,a=precise-security'] 2014-01-15 11:14:35,846 INFO Option --dry-run given, *not* performing real actions 2014-01-15 11:14:35,846 INFO Packages that are upgraded: bind9-host dnsutils libbind9-80 libdns81 libisc83 libisccc80 libisccfg82 liblwres80 libssl1.0.0 linux-generic-pae linux-headers-generic-pae linux-image-generic-pae linux-libc-dev openssl 2014-01-15 11:14:35,847 INFO Writing dpkg log to '/var/log/unattended-upgrades/unattended-upgrades-dpkg_2014-01-15_11:14:35.846820.log' 2014-01-15 11:15:10,610 INFO All upgrades installed 2014-01-15 11:15:10,611 WARNING Found /var/run/reboot-required, rebooting Version: 0.76ubuntu1 As an aside, it makes a lot of sense to me to put the reboot on a timer, even if it's only a one minute (i.e. shutdown -r 1). That would have at least given me a chance to prevent the reboot if I had seen the warning. If that's a configuration setting I don't see it anywhere. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1269177/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
