[Toybox] [Patch] - ifconfig hw address Makefile clean target

2014-02-26 Thread Ashwini Sharma
Hi Rob, List,

Encountered couple of issues,

1. ifconfig - while setting hw address, the condition check was wrong.
2. Makefile - Clean target didn't remove generated/globals.h and testdir.

attached are the patches for the same.

regards,
Ashwini


Makefile.patch
Description: Binary data


ifconfig.c.patch
Description: Binary data
___
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net


Re: [Toybox] Build issue at changeset 1209:f170f978e81e

2014-02-26 Thread Rob Landley
On 02/26/14 06:30, Ashwini Sharma wrote:
 Hi Rob, List,
 
 The code on mercurial at 
 
 
   changeset 1209:f170f978e81e
 
 is having build failures.
 This fails complaining about FLAG_x macros not being declared, starting
 from 
 __kill__ command.

Sigh, I didn't realize init with  in the option string was checked in.

When toys/pending/init.c is enabled, the header flag generation gets
confused because  doesn't register as a valid option string. (0 says
don't call the option parsing logic,  would be call it and don't do
anything.) I know the scanf() can't handle it, looks like there's a
regex in make.sh that doesn't either. Both expect the quotes to have
something in them.

I'll try to fix it in the morning. Special case treating  as 0,
probably. (Using 0 lets the option parsing logic drop out at compile
time for single command builds, because it's not used;  doesn't.)

Thanks for the heads up,

Rob
___
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net


Re: [Toybox] generic editor code

2014-02-26 Thread David Seikel
On Sat, 1 Feb 2014 20:56:53 +1000 David Seikel onef...@gmail.com
wrote:

 On Sat, 1 Feb 2014 12:21:29 +1000 David Seikel onef...@gmail.com
 wrote:
 
  Oops, found a small design fault.  I'm fixing that now, and will
  send an update later today.
 
 This time for sure.  Fixed up the bottom of terminal bug in dumbsh,
 the resizing, and made the keystrokes / ordinary characters
 determination more sane.  Did a lot of debugging and hopefully solved
 all know bugs except for one in the editor that I'll get to some other
 time.

Rob, I would guess you are still too busy with everything else to get
to this, perhaps I should just keep maintaining it and working on it at
https://github.com/onefang/boxes until you can get around to it?

-- 
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.


signature.asc
Description: PGP signature
___
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net