[Tracker-discuss] [issue120] Allow users to report msg/file instances as misclassified

[Ezio Melotti]

Ezio Melotti added the comment:

Applied in 5872f58e0e4e.

--
status: chatting -> resolved

___
PSF Meta Tracker 

___
___
Tracker-discuss mailing list
Tracker-discuss@python.org
http://mail.python.org/mailman/listinfo/tracker-discuss

[Tracker-discuss] [issue120] Allow users to report msg/file instances as misclassified

[Martin v . Löwis]

Martin v. Löwis added the comment:

Ezio: I think this is fine (except perhaps that developers may be unaware what 
exactly the ham/spam classification means). To test it, you'll find plenty 
messages in the tracker. To change your roles, just use roundup-admin on the 
command line (I think dropping the coordinator role can actually be done 
through the UI - regaining would require to log in with the "admin" account, 
which we don't use in the web interface).

--
nosy: +loewis

___
PSF Meta Tracker 

___
___
Tracker-discuss mailing list
Tracker-discuss@python.org
http://mail.python.org/mailman/listinfo/tracker-discuss

[Tracker-discuss] [issue120] Allow users to report msg/file instances as misclassified

[Ezio Melotti]

Ezio Melotti  added the comment:

The attached patch should enable developers to reclassify spam.
I'm not sure what's the best way to test it though (I would need either a 
spammy message and a non-coordinator account).

--
assignedto:  -> ezio.melotti

___
PSF Meta Tracker 

___Index: schema.py
===
--- schema.py   (revision 88963)
+++ schema.py   (working copy)
@@ -254,9 +254,9 @@
 p = db.security.addPermission(name='View', klass=cl,
   description="Allowed to see content of 
object regardless of spam status",
   properties = ('content', 'summary'))
-
-db.security.addPermissionToRole('User', p)
-
+
+db.security.addPermissionToRole('User', p)
+
 spamcheck = db.security.addPermission(name='View', klass=cl,
   description="allowed to see content 
if not spam",
   properties=('content', 'summary'),
@@ -316,7 +316,7 @@
 # Coordinator permissions
 ##
 for cl in ('issue_type', 'severity', 'component',
-   'version', 'priority', 'stage', 'status', 'resolution', 'issue', 
+   'version', 'priority', 'stage', 'status', 'resolution', 'issue',
'file', 'msg', 'hgrepo'):
 db.security.addPermissionToRole('Coordinator', 'View', cl)
 db.security.addPermissionToRole('Coordinator', 'Edit', cl)
@@ -326,6 +326,7 @@
 db.security.addPermissionToRole('Coordinator', p)
 
 db.security.addPermissionToRole('Coordinator', 'SB: May Classify')
+db.security.addPermissionToRole('Developer', 'SB: May Classify')
 
 # May users view other user information? Comment these lines out
 # if you don't want them to
___
Tracker-discuss mailing list
Tracker-discuss@python.org
http://mail.python.org/mailman/listinfo/tracker-discuss

[Tracker-discuss] [issue120] Allow users to report msg/file instances as misclassified

[Éric Araujo]

Éric Araujo  added the comment:

Allowing all developers to reclassify messages sounds good.

___
PSF Meta Tracker 

___
___
Tracker-discuss mailing list
Tracker-discuss@python.org
http://mail.python.org/mailman/listinfo/tracker-discuss

[Tracker-discuss] [issue120] Allow users to report msg/file instances as misclassified

[Ezio Melotti]

Ezio Melotti  added the comment:

AFAIK reclassification requires "Coordinator" privileges, and there are 
probably a dozen of coordinators.  I think it would be OK to allow all 
"Developers" to reclassify messages.

I recently saw a developer asking on #python-dev if someone with enough 
privileges could reclassify a message, but developers that are not on IRC would 
have to know who has the privileges and send them a mail (or ask to 
tracker-discuss or something).

--
nosy: +ezio.melotti

___
PSF Meta Tracker 

___
___
Tracker-discuss mailing list
Tracker-discuss@python.org
http://mail.python.org/mailman/listinfo/tracker-discuss

[Tracker-discuss] [issue120] Allow users to report msg/file instances as misclassified

[Éric Araujo]

Éric Araujo  added the comment:

> Reclassification requires elevated tracker privileges, for a good reason
Right.  Is there a list of users with admin rights somewhere?

> If triage people don't have access to this function that should probably be
> changed. [...] (The interface, by the way, is accessed from the 'view' of the
> message, if you have the appropriate privileges
I can’t test right now, I don’t remember the id of my message that was 
classified as spam.  Will test as soon as possible.

___
PSF Meta Tracker 

___
___
Tracker-discuss mailing list
Tracker-discuss@python.org
http://mail.python.org/mailman/listinfo/tracker-discuss

[Tracker-discuss] [issue120] Allow users to report msg/file instances as misclassified

[R David Murray]

R David Murray  added the comment:

Reclassification requires elevated tracker privileges, for a good reason (can't 
have spambots reclassifying their own messages :)

If triage people don't have access to this function that should probably be 
changed.  At that point we could document that the way to request 
reclassification is to post a new message asking for the reclassification.  
Then a triage person can fix it.

(The interface, by the way, is accessed from the 'view' of the message, if you 
have the appropriate privileges.)

___
PSF Meta Tracker 

___
___
Tracker-discuss mailing list
Tracker-discuss@python.org
http://mail.python.org/mailman/listinfo/tracker-discuss

[Tracker-discuss] [issue120] Allow users to report msg/file instances as misclassified

[Éric Araujo]

Éric Araujo  added the comment:

David, I hope you won’t mind me adding you to nosy.  What should we do with 
this problem?  When a message gets misclassified as spam, what is the user to 
do?

--
nosy: +eric.araujo, r.david.murray

___
PSF Meta Tracker 

___
___
Tracker-discuss mailing list
Tracker-discuss@python.org
http://mail.python.org/mailman/listinfo/tracker-discuss