Re: [Tracker] more issues with indexer-split
Jamie McCracken wrote: > On Tue, 2008-09-09 at 18:02 +0200, Philip Van Hoof wrote: >> On Tue, 2008-09-09 at 11:56 -0400, Jamie McCracken wrote: >>> On Tue, 2008-09-09 at 16:30 +0100, Martyn Russell wrote: Jamie can we try to get this merge done this week please >>> sure - just need to check your additions which I will try to do >>> tonight >>> >>> obviously post merge you will have to submit major patches to me >>> so best to get as much in as possible before that >> It might make sense for us to continue bleeding edge development in >> the branch and after (your) intensive review merge that diff to >> trunk. >> >> Not sure how others feel about this? > > I dont mind if you want to sync what you have so far with trunk and > then continue on indexer-split > > What you have so far is not ready for a release so it does not make > much difference whether we merge or not at this point. Obviously if > martyn and co feel strongly about merging then I will oblige. I have > full confidence in you guys and am happy to prove it :) Phillip is right. From day to day when we are all working (and not on vacation like now) we tend to range on average from 5 to 20 commits a day. That's quite a lot of review work for you. There are 5 of us working on Tracker right now and it has been that way for a number of months. Unless you want more email of course :P Any thing major would be discussed with you first before it was implemented and potentially done in a separate branch anyway. The only thing I would say is that creating a diff for TRUNK is probably not a good idea. it is probably best to just copy everything right over after doing a pre-merge tag. There are a LOT of file differences and created/deleted files too. If you want me to do the merge, I can, just let me know. -- Regards, Martyn ___ tracker-list mailing list tracker-list@gnome.org http://mail.gnome.org/mailman/listinfo/tracker-list
Re: [Tracker] more issues with indexer-split
On Tue, 2008-09-09 at 18:02 +0200, Philip Van Hoof wrote: > On Tue, 2008-09-09 at 11:56 -0400, Jamie McCracken wrote: > > On Tue, 2008-09-09 at 16:30 +0100, Martyn Russell wrote: > > > > > > > Jamie can we try to get this merge done this week please > > > > sure - just need to check your additions which I will try to do tonight > > > > obviously post merge you will have to submit major patches to me so best to > > get as much in as possible before that > > It might make sense for us to continue bleeding edge development in the > branch and after (your) intensive review merge that diff to trunk. > > Not sure how others feel about this? I dont mind if you want to sync what you have so far with trunk and then continue on indexer-split What you have so far is not ready for a release so it does not make much difference whether we merge or not at this point. Obviously if martyn and co feel strongly about merging then I will oblige. I have full confidence in you guys and am happy to prove it :) jamie ___ tracker-list mailing list tracker-list@gnome.org http://mail.gnome.org/mailman/listinfo/tracker-list
Re: [Tracker] more issues with indexer-split
On Tue, 2008-09-09 at 11:56 -0400, Jamie McCracken wrote: > On Tue, 2008-09-09 at 16:30 +0100, Martyn Russell wrote: > > > > Jamie can we try to get this merge done this week please > > sure - just need to check your additions which I will try to do tonight > > obviously post merge you will have to submit major patches to me so best to > get as much in as possible before that It might make sense for us to continue bleeding edge development in the branch and after (your) intensive review merge that diff to trunk. Not sure how others feel about this? The thing is that our team is changing things quite fast. For our team we need a shared repository anyway. So either it would be a branch, or we'd have our own private team repository (git-like, or indeed a git one - which might make a lot of sense -). Obviously we prefer to do things at the upstream project asap. Private repositories are not cool in at least my opinion. But having to wait for individual approvals of each and every patch ... would also block our methodology a little bit. Anyway ... my proposal for post-merge is to discuss this together at the Maemo Desktop Search hackfest in Berlin. -- Philip Van Hoof, freelance software developer home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org http://pvanhoof.be/blog http://codeminded.be ___ tracker-list mailing list tracker-list@gnome.org http://mail.gnome.org/mailman/listinfo/tracker-list
Re: [Tracker] more issues with indexer-split
On Tue, 2008-09-09 at 16:30 +0100, Martyn Russell wrote: > Martyn Russell wrote: > > Martyn Russell wrote: > >> Hi, > >> > >> So I have been reading up on the things that are remaining for merging. > >> This is the list I have so far which I will be working on: > >> > >> * Check the move files/directories issue. I *think* it works. > > > > Work on this will be continuing Monday. > > This should be fixed now. The to and from strings were simply the wrong > way round. The code has also been improved here to use the file event > queue too which means we can make full use of the state machine also. > > >> * Make private libraries .so files to dynamically load them. > > > > I have made libtracker-common, libtracker-db and libstemmer all .so files. > > > > But I think what you meant was to make each language a .so which we > > dlopen() using something like GModule, right? That we can possibly do > > next week. I don't think this should stop the merge to be honest. There > > are bigger problems to address first. > > I will start on this tomorrow. But we don't need it for the merge. > > >> * The directory mtime issue on startup. > > This is fixed. > > >> Have I missed anything? > > > > New items: > > > > * Check mtime for summary files too. > > I have yet to do this. I spoke briefly to Carlos about it. His opinion > was that it isn't necessary. I agree that it certainly isn't necessary > for the merge. I can look into this some time after the .so issue. > > Jamie can we try to get this merge done this week please sure - just need to check your additions which I will try to do tonight obviously post merge you will have to submit major patches to me so best to get as much in as possible before that jamie ___ tracker-list mailing list tracker-list@gnome.org http://mail.gnome.org/mailman/listinfo/tracker-list
Re: [Tracker] more issues with indexer-split
Martyn Russell wrote: > Martyn Russell wrote: >> Hi, >> >> So I have been reading up on the things that are remaining for merging. >> This is the list I have so far which I will be working on: >> >> * Check the move files/directories issue. I *think* it works. > > Work on this will be continuing Monday. This should be fixed now. The to and from strings were simply the wrong way round. The code has also been improved here to use the file event queue too which means we can make full use of the state machine also. >> * Make private libraries .so files to dynamically load them. > > I have made libtracker-common, libtracker-db and libstemmer all .so files. > > But I think what you meant was to make each language a .so which we > dlopen() using something like GModule, right? That we can possibly do > next week. I don't think this should stop the merge to be honest. There > are bigger problems to address first. I will start on this tomorrow. But we don't need it for the merge. >> * The directory mtime issue on startup. This is fixed. >> Have I missed anything? > > New items: > > * Check mtime for summary files too. I have yet to do this. I spoke briefly to Carlos about it. His opinion was that it isn't necessary. I agree that it certainly isn't necessary for the merge. I can look into this some time after the .so issue. Jamie can we try to get this merge done this week please? -- Regards, Martyn ___ tracker-list mailing list tracker-list@gnome.org http://mail.gnome.org/mailman/listinfo/tracker-list
