Re: The “//” fix confuses cygwin-mount

2018-03-22 Thread Michael Albinus
Chris Zheng  writes:

> Hello Michael,

Hi Chris,

>> Sorry, I meant this:
>> 
>> --8<---cut here---start->8---
>>(concat (file-remote-p filename)
>>(tramp-run-real-handler
>> 'substitute-in-file-name (list localname)))
>> --8<---cut here---end--->8---
>
> Yes. With this it works.

Thanks for the check; I've pushed this.

> However, I observed that when I go to /scpx:E:/ with “C-x C-f”, and
> “C-x C-f” again, the minibuffer shows “/scpx:E://”. Is this intended?

Looks strange. Will check (by tomorrow).

> Thank you,
>
> Chris

Best regards, Michael

___
Tramp-devel mailing list
Tramp-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/tramp-devel


Re: The “//” fix confuses cygwin-mount

2018-03-22 Thread Chris Zheng
On Fri, 23 Mar 2018 05:03:00 +0800,
Michael Albinus wrote:

Hello Michael,

> Michael Albinus  writes:
> 
> Hi Chris,
> 
> > Does it work, if you change the patch like this:
> 
> Sorry, I meant this:
> 
> --8<---cut here---start->8---
> (concat (file-remote-p filename)
> (tramp-run-real-handler
>  'substitute-in-file-name (list localname)))
> --8<---cut here---end--->8---

Yes. With this it works. However, I observed that when I go to
/scpx:E:/ with “C-x C-f”, and “C-x C-f” again, the minibuffer shows
“/scpx:E://”. Is this intended?

> Best regards, Michael.

Thank you,

Chris

___
Tramp-devel mailing list
Tramp-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/tramp-devel


Re: The “//” fix confuses cygwin-mount

2018-03-22 Thread Michael Albinus
Michael Albinus  writes:

Hi Chris,

> Does it work, if you change the patch like this:

Sorry, I meant this:

--8<---cut here---start->8---
  (concat (file-remote-p filename)
  (tramp-run-real-handler
   'substitute-in-file-name (list localname)))
--8<---cut here---end--->8---

Best regards, Michael.

___
Tramp-devel mailing list
Tramp-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/tramp-devel


Re: The “//” fix confuses cygwin-mount

2018-03-22 Thread Michael Albinus
Chris Zheng  writes:

> Dear Michael,

Hi Chris,

> I’m sorry to tell you that the fix isn’t right, as
>
> (tramp-drop-volume-letter "c:/msys64/foo") ⇒ "/msys64/foo"
>
> which is still wrong. The “/msys64” should be removed, too.

Why does (substitute-in-file-name "/foo") returns "c:/msys64/foo"? This
is not covered by the description of `substitute-in-file-name'.

Does it work, if you change the patch like this:

--8<---cut here---start->8---
  (concat (file-remote-p filename)
  (tramp-drop-volume-letter
   (tramp-run-real-handler
(substitute-in-file-name (list localname
--8<---cut here---end--->8---

> Thank you,
>
> Chris

Best regards, Michael.

___
Tramp-devel mailing list
Tramp-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/tramp-devel


Re: The “//” fix confuses cygwin-mount

2018-03-22 Thread Chris Zheng
On Fri, 23 Mar 2018 01:00:57 +0800,
Michael Albinus wrote:
> 
> Chris Zheng  writes:
> 
> > Dear List,
> 
> Hi Chris,

Dear Michael,

> > The commit c24c5dc4a4cc18e7f1ec949efcfe1d4bae541d02 confuses the
> > cygwin-mount that serves the translation from “/c/Windows” to
> > “C:/Windows/” under MS-Windows. With the above commit and
> > cygwin-mount,
> >
> > (substitute-in-file-name "/method:host:/foo")
> > ⇒ "/method:host:c:/msys64/foo"
> 
> Thanks for the report. I've fixed this in both Tramp and Emacs repositories.

I’m sorry to tell you that the fix isn’t right, as

(tramp-drop-volume-letter "c:/msys64/foo") ⇒ "/msys64/foo"

which is still wrong. The “/msys64” should be removed, too.

> > Thank you very much,
> >
> > Chris
> 
> Best regards, Michael.

Thank you,

Chris

___
Tramp-devel mailing list
Tramp-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/tramp-devel


Re: The “//” fix confuses cygwin-mount

2018-03-22 Thread Michael Albinus
Chris Zheng  writes:

> Dear List,

Hi Chris,

> The commit c24c5dc4a4cc18e7f1ec949efcfe1d4bae541d02 confuses the
> cygwin-mount that serves the translation from “/c/Windows” to
> “C:/Windows/” under MS-Windows. With the above commit and
> cygwin-mount,
>
> (substitute-in-file-name "/method:host:/foo")
> ⇒ "/method:host:c:/msys64/foo"

Thanks for the report. I've fixed this in both Tramp and Emacs repositories.

> Thank you very much,
>
> Chris

Best regards, Michael.

___
Tramp-devel mailing list
Tramp-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/tramp-devel